[Freeciv-Dev] [bug #16404] civ start script doesn't work when there is a folder named freeciv
Update of bug #16404 (project freeciv): Severity: 3 - Normal = 2 - Minor Priority: 5 - Normal = 3 - Low Summary: civ start script doesn't work = civ start script doesn't work when there is a folder named freeciv ___ Follow-up Comment #3: Actually, there is the same problem in S2_2, it tries to execute the directory named freeciv. ___ Reply to this item at: http://gna.org/bugs/?16404 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16451] Game crash after ending of turn
Follow-up Comment #5, bug #16451 (project freeciv): I checked this and I really doubt this could be the case. I am afraid that there is an invalid write of data somewhere. ___ Reply to this item at: http://gna.org/bugs/?16451 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16479] Largepox and AI
Update of bug #16479 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?16479 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16480] Usability of Help button on research window
Follow-up Comment #6, bug #16480 (project freeciv): I never use the help button on research window. If I need infos, I usually go to the help. ___ Reply to this item at: http://gna.org/bugs/?16480 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor
Update of bug #16491 (project freeciv): Status:None = Confirmed Planned Release: = 2.2.3 ___ Follow-up Comment #1: Thank you for the informations. It is really easier to debug. It doesn't look like to make problems in trunk. PS: Is this bug fixed in Longturn? Is there a mean to access the bug report and the patch applied? ___ Reply to this item at: http://gna.org/bugs/?16491 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16494] 1: build_tile_data() tile (x, y) has no terrain!
URL: http://gna.org/bugs/?16494 Summary: 1: build_tile_data() tile (x,y) has no terrain! Project: Freeciv Submitted by: pepeto Submitted on: vendredi 20.08.2010 à 08:43 Category: editor Severity: 2 - Minor Priority: 3 - Low Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk, S2_2 Discussion Lock: Any Operating System: None Planned Release: ___ Details: You get lot of this error messages when you try to observe the game globally after you have been detached when you destroyed your own player on the editor. ___ Reply to this item at: http://gna.org/bugs/?16494 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16495] Possible crash in server_remove_player()
URL:
http://gna.org/bugs/?16495
Summary: Possible crash in server_remove_player()
Project: Freeciv
Submitted by: pepeto
Submitted on: vendredi 20.08.2010 à 09:00
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: pepeto
Originator Email:
Open/Closed: Open
Release: trunk, S2_2
Discussion Lock: Any
Operating System: None
Planned Release: 2.2.3, 2.3.0
___
Details:
Using
conn_list_iterate(pplayer-connections, pconn) {
connection_detach(pconn);
} conn_list_iterate_end;
is dangerous, because if there are connections following the connection which
is actually playing in the list, the connection will be empty after the end of
the iteration, causing the loop using freed datas. I didn't make the server
crashing, but this function is used in lot of places in stdinhand.c, so it
probably can cause a crash somewhere.
Fix attached.
___
File Attachments:
---
Date: vendredi 20.08.2010 à 09:00 Name: trunk_server_remove_player.diff
Size: 765 o By: pepeto
http://gna.org/bugs/download.php?file_id=9930
---
Date: vendredi 20.08.2010 à 09:00 Name: S2_2_server_remove_player.diff
Size: 742 o By: pepeto
http://gna.org/bugs/download.php?file_id=9931
___
Reply to this item at:
http://gna.org/bugs/?16495
___
Message posté via/par Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16496] Crash being detached (observer) from a player after player remove
URL: http://gna.org/bugs/?16496 Summary: Crash being detached (observer) from a player after player remove Project: Freeciv Submitted by: pepeto Submitted on: vendredi 20.08.2010 à 09:14 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: ___ Details: Cannot reproduce in S2_2. ___ Reply to this item at: http://gna.org/bugs/?16496 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1872] Remove old and wrong comment in player_destroy()
URL: http://gna.org/patch/?1872 Summary: Remove old and wrong comment in player_destroy() Project: Freeciv Submitted by: pepeto Submitted on: vendredi 20.08.2010 à 09:22 Category: general Priority: 3 - Low Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ File Attachments: --- Date: vendredi 20.08.2010 à 09:22 Name: trunk_player_destroy.diff Size: 612 o By: pepeto http://gna.org/patch/download.php?file_id=9932 ___ Reply to this item at: http://gna.org/patch/?1872 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor
Update of bug #16491 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #2: Fix attached. PS: It would also fix the issues for Longturn. (file #9933) ___ Additional Item Attachment: File name: S2_2_reset_player_shared_info.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16491 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16494] 1: build_tile_data() tile (x, y) has no terrain!
Update of bug #16494 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.3, 2.3.0 ___ Follow-up Comment #1: The property dialog was trying to update. Fix attached. (file #9934) ___ Additional Item Attachment: File name: trunk_S2_2_client_game_reset.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16494 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16496] Crash being detached (observer) from a player after player remove
Follow-up Comment #1, bug #16496 (project freeciv):
Backtrace:
Program received signal SIGSEGV, Segmentation fault.
0x0055714c in genlist_remove (pgenlist=0x875c860, punlink=0x8779b20)
at genlist.c:251
251 while (plink != NULL plink-dataptr != punlink) {
(gdb) bt
#0 0x0055714c in genlist_remove (pgenlist=0x875c860,
punlink=0x8779b20) at genlist.c:251
#1 0x0043b2bb in conn_list_remove (pinfo=0x87b0e00)
at ../utility/speclist.h:157
#2 handle_conn_info (pinfo=0x87b0e00) at packhand.c:1995
#3 0x0044100d in client_handle_packet (type=value optimised out,
packet=0x875c860) at packhand_gen.c:208
#4 0x00417e9e in client_packet_input (packet=value optimised out,
type=115) at client_main.c:557
#5 0x0041d755 in input_from_server (fd=value optimised out)
at clinet.c:382
#6 0x74f27d3f in gdk_io_invoke (source=value optimised out,
condition=value optimised out, data=value optimised out)
at /build/buildd/gtk+2.0-2.20.1/gdk/gdkevents.c:1082
#7 0x72d438c2 in g_main_dispatch (context=0x969560)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:1960
#8 IA__g_main_context_dispatch (context=0x969560)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2513
#9 0x72d47748 in g_main_context_iterate (context=0x969560,
block=value optimised out, dispatch=value optimised out,
self=value optimised out)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2591
#10 0x72d47c55 in IA__g_main_loop_run (loop=0x204bc10)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2799
#11 0x752eabb7 in IA__gtk_main ()
at /build/buildd/gtk+2.0-2.20.1/gtk/gtkmain.c:1219
#12 0x0041723f in ui_main (argc=1, argv=0x7fffe338)
at gui_main.c:1621
#13 0x004182cf in client_main (argc=value optimised out,
argv=0x7fffe338) at client_main.c:501
#14 0x729a0c4d in __libc_start_main (main=value optimised out,
argc=value optimised out, ubp_av=value optimised out,
init=value optimised out, fini=value optimised out,
rtld_fini=value optimised out, stack_end=0x7fffe328)
at libc-start.c:226
#15 0x00412c69 in _start ()
(gdb) bt full
#0 0x0055714c in genlist_remove (pgenlist=0x875c860,
punlink=0x8779b20) at genlist.c:251
plink = 0x206572646e657250
__FUNCTION__ = genlist_remove
#1 0x0043b2bb in conn_list_remove (pinfo=0x87b0e00)
at ../utility/speclist.h:157
No locals.
#2 handle_conn_info (pinfo=0x87b0e00) at packhand.c:1995
pslot = value optimised out
pplayer = 0x0
pconn = 0x8779b20
preparing_client_state = value optimised out
__FUNCTION__ = handle_conn_info
#3 0x0044100d in client_handle_packet (type=value optimised out,
packet=0x875c860) at packhand_gen.c:208
No locals.
#4 0x00417e9e in client_packet_input (packet=value optimised out,
type=115) at client_main.c:557
__FUNCTION__ = client_packet_input
#5 0x0041d755 in input_from_server (fd=value optimised out)
at clinet.c:382
result = true
packet = 0x875c860
type = PACKET_CONN_INFO
__FUNCTION__ = input_from_server
#6 0x74f27d3f in gdk_io_invoke (source=value optimised out,
condition=value optimised out, data=value optimised out)
at /build/buildd/gtk+2.0-2.20.1/gdk/gdkevents.c:1082
closure = 0x154e380
gdk_cond = GDK_INPUT_READ
#7 0x72d438c2 in g_main_dispatch (context=0x969560)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:1960
dispatch = 0x72d85e10 g_io_unix_dispatch
user_data = 0x154e380
callback = 0x74f27cf0 gdk_io_invoke
cb_funcs = 0x72fe1610
cb_data = 0x3d7e5e0
current_source_link = {data = 0x3da3400, next = 0x0}
source = 0x3da3400
current = 0x3d66c60
i = 0
#8 IA__g_main_context_dispatch (context=0x969560)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2513
No locals.
#9 0x72d47748 in g_main_context_iterate (context=0x969560,
block=value optimised out, dispatch=value optimised out,
self=value optimised out)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2591
max_priority = 115
timeout = 0
some_ready = 1
nfds = 4
allocated_nfds = -220903856
fds = value optimised out
__PRETTY_FUNCTION__ = g_main_context_iterate
#10 0x72d47c55 in IA__g_main_loop_run (loop=0x204bc10)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2799
self = 0x87e790
__PRETTY_FUNCTION__ = IA__g_main_loop_run
#11 0x752eabb7 in IA__gtk_main ()
at /build/buildd/gtk+2.0-2.20.1/gtk/gtkmain.c:1219
tmp_list = 0x9746f0
functions = 0x0
init = 0xaf5230
loop = value optimised out
#12 0x0041723f in ui_main (argc=1, argv=0x7fffe338)
at gui_main.c:1621
home = value optimised out
sig =
[Freeciv-Dev] [bug #16496] Crash being detached (observer) from a player after player remove
Update of bug #16496 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.3.0 ___ Follow-up Comment #2: Some connections on client side were keeping an invalid player pointer. And applying patch #1872 were producing appropriated failed assertions. Fix attached. (file #9935) ___ Additional Item Attachment: File name: trunk_handle_player_remove.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16496 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1838] Base multiplayer ruleset on Book's rewonder
Update of patch #1838 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1838 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1856] More efficient is_nation_in_range()
Update of patch #1856 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1856 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16445] Loading civ1 and civ2 rulesets produce error messages
Update of bug #16445 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #1: Fix attached. (file #9936) ___ Additional Item Attachment: File name: trunk_civ1_civ2.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16445 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16449] International traderoutes don't pay attention to minimal distance.
Update of bug #16449 (project freeciv): Status: Need Info = None ___ Follow-up Comment #4: The in-game docs currently say that trade routes are created by producing a Caravan or Freight unit, sending them to another city at least nine tiles away or belonging to a different civilization (my emphasis). This should be mentioned in the help text for the setting _trademindist_. ___ Reply to this item at: http://gna.org/bugs/?16449 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16387] attacker can abuse 'go to' to stop pillager
Update of bug #16387 (project freeciv): Category:None = general Status: Need Info = Wont Fix Assigned to:None = pepeto Open/Closed:Open = Closed ___ Follow-up Comment #7: Shuffled players order is feature, not a bug. ___ Reply to this item at: http://gna.org/bugs/?16387 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16341] Ignore case when sorting players by name
Update of bug #16341 (project freeciv): Category: client-gtk-2.0 = client Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.3.0 ___ Follow-up Comment #3: Patch attached. (file #9937) ___ Additional Item Attachment: File name: trunk_plrdlg_sort_names.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16341 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16469] Freecivic 2.2.2 crashes AD500
Follow-up Comment #8, bug #16469 (project freeciv): I tried to play, I didn't have problem with this savegame, neither with the client. I can't confirm. ___ Reply to this item at: http://gna.org/bugs/?16469 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16469] Freecivic 2.2.2 crashes AD500
Follow-up Comment #9, bug #16469 (project freeciv): Forgot to ask, what client do you play (Gtk2, SDL or Xaw)? ___ Reply to this item at: http://gna.org/bugs/?16469 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16341] Ignore case when sorting players by name
Follow-up Comment #4, bug #16341 (project freeciv): base_compare_strings uses strcmp. shouldn't it be strcasecmp? ___ Reply to this item at: http://gna.org/bugs/?16341 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16341] Ignore case when sorting players by name
Update of bug #16341 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #5: base_compare_strings uses strcmp. shouldn't it be strcasecmp? I didn't check the body of the function, I was pretty sure it was strcasecmp. However, it worked perfectly when I tested. Probably my LC_COLLATE is rightly appropriate for that. I will check more. ___ Reply to this item at: http://gna.org/bugs/?16341 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16341] Ignore case when sorting players by name
Update of bug #16341 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #6: New patch attached: * Added wrappers fc_strcoll() and fc_stricoll(). * Removeed base_compare_strings(). * Use fc_stricoll() instead for sorting player names. (file #9939) ___ Additional Item Attachment: File name: trunk_strcoll_stricoll.diffSize:8 KB ___ Reply to this item at: http://gna.org/bugs/?16341 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1852] contemplate_terrain_improvements() from autosettler.c to aicity.c
Update of patch #1852 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1852 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1849] Allow only one modpack to download at a time
Update of patch #1849 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1849 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16480] Usability of Help button on research window
Follow-up Comment #7, bug #16480 (project freeciv): That certainly works, but i find it inconvenient. Help - Technology only shows me generic help about research. In order to see specifics about a certain tech [which is something i typically want to see more often], i have to: 1) click the triangle to expose the individual techs; 2) scroll down to the desired tech, if i remember the name; 3) finally click on the tech to see its help. Excuse my exaggeration, but this is too much like work. Being able to see help immediately for the item i'm looking at is more helpful. Back to the main point, i agree that the Help button does work as planned, but that the plan isn't obvious to everybody. A tooltip would be nice, or else changing the title Help into something like Display help in dropdown menu. The latter seems like it would fit, but some languages and/or some display resolutions may have a problem with it. ___ Reply to this item at: http://gna.org/bugs/?16480 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16469] Freecivic 2.2.2 crashes AD500
Follow-up Comment #10, bug #16469 (project freeciv): The only binary we provide for 2.2 on Mac OS currently is Gtk2. Is it a safe assumption that if a user self compiled they would let us know? ___ Reply to this item at: http://gna.org/bugs/?16469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16469] Freecivic 2.2.2 crashes AD500
Follow-up Comment #11, bug #16469 (project freeciv): @Anonymous: Have you shut down or restarted your Mac recently? I suspect that X11 as seen on 10.6 isn't meant to run for such long periods of time - i have seen it lose track of windows during extended play sessions. ___ Reply to this item at: http://gna.org/bugs/?16469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server
Follow-up Comment #13, bug #15559 (project freeciv): My -v2 patch (from S2_2 r17797) causes a merge conflict in server/sernet.c. I am attaching a new -v3 patch (from S2_2 r17820) to solve the conflict. If you already applied the -v2 patch, you might $ patch -R p22-plural-listen-v2.diff $ svn up $ patch p22-plural-listen-v3.diff or you might $ svn up $ svn revert server/sernet.c server/meta.c client/clinet.c client.servers.c $ patch p22-plural-listen-v3.diff (file #9941) ___ Additional Item Attachment: File name: p22-plural-listen-v3.diff Size:15 KB ___ Reply to this item at: http://gna.org/bugs/?15559 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16380] Generated files are not deleted by 'make distclean'
Follow-up Comment #2, bug #16380 (project freeciv): According to the The GNU Coding Standards, I think, the generated files are not to be deleted by distclean, but by maintainerclean. Quote from the standards: ‘maintainer-clean’ Delete almost everything that can be reconstructed with this Makefile. This typically includes everything deleted by distclean, plus more: C source files produced by Bison, tags tables, Info files, and so on. Another quote: You may need special tools to reconstruct some of the files that ‘make maintainer-clean’ deletes. Thus no configure check for python would be neccessary. Here's a patch along those lines. JHS (file #9943) ___ Additional Item Attachment: File name: maintainerclean-generated-files.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16380 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor
Follow-up Comment #3, bug #16491 (project freeciv): Your patch (file #9933) fixes the map editor. I watched as the AI players killed most of the Prussian Warriors, without crashing the server. I will discuss the Longturn bug at its page. You found the page at http://redmine.pagema.net/issues/96 ___ Reply to this item at: http://gna.org/bugs/?16491 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats
Update of bug #16305 (project freeciv): Planned Release: = 2.2.3,2.3.0 ___ Follow-up Comment #7: I'll commit these patches to S2_2 and trunk soon if there are no objections. ___ Reply to this item at: http://gna.org/bugs/?16305 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16469] Freecivic 2.2.2 crashes AD500
Follow-up Comment #12, bug #16469 (project freeciv): I also loaded the savegame in the 2.2.2 Gtk client on Ubuntu Linux and pressed Turn Done many times without issue. Perhaps someone with Mac OS could try it? ___ Reply to this item at: http://gna.org/bugs/?16469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15351] warning: unterminated character constant
Follow-up Comment #2, bug #15351 (project freeciv): I think the patch in bug #16464 will make this go away for the current crop. Doubtless they'll creep back in as people (reasonably) use apostrophes in comments. ___ Reply to this item at: http://gna.org/bugs/?15351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16449] Document that international traderoutes don't pay attention to trademindist
Update of bug #16449 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Operating System: Microsoft Windows = None Planned Release: = 2.3.0 Summary: International traderoutes don't pay attention to minimal distance. = Document that international traderoutes don't pay attention to trademindist ___ Follow-up Comment #5: Documentation patch attached for trunk. (Not patching S2_2 as it's a string change.) (file #9944) ___ Additional Item Attachment: File name: trunk-trademindist-doc.diffSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?16449 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16429] Failed sanitycheck.c: Engineers has activity Railroad, but it can't continue at Forest
Follow-up Comment #2, bug #16429 (project freeciv): Don't think it's alliance/pillaging: there's no other unit on the tile in any of the savegames. The Himyarites, who start out owning the land, are only allied to the Normans who are nowhere near. Think it's somehow to do with civil war. In T0370 and T0371 the land and relevant Engineers unit belong to the Himyarites, but in T0372 they both belong to a new Arab player; it looks like the result of civil war. Still not sure why that should make a difference, but it's a clue. * T0370: Grassland, Road/Irrigation, Engineers working on Mine(1) * T0371: Forest, Road, Engineers working on nothing * T0372: Forest, Road, Engineers (now Arab) working on Railroad(1) Global warming and nuclear winter chance are both 0. Checked with the editor that it's the same unit on that tile all three times (ID 4105). ___ Reply to this item at: http://gna.org/bugs/?16429 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #9, bug #15684 (project freeciv): Another cause is if you discover previously unknown territory that would otherwise have been within your borders -- normally your borders expand next turn, but if you save and load, the borders are recalculated and the land is yours the same turn. ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats
Follow-up Comment #8, bug #16305 (project freeciv): Diplomat help text is not changed in the new multiplayer ruleset. ___ Reply to this item at: http://gna.org/bugs/?16305 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats
Follow-up Comment #9, bug #16305 (project freeciv): Rats. Updated patch for trunk attached. (file #9947) ___ Additional Item Attachment: File name: trunk-diplomat-city-sabotage-bis.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?16305 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16499] Space wasted on Messages tab in small widgets layout
URL: http://gna.org/bugs/?16499 Summary: Space wasted on Messages tab in small widgets layout Project: Freeciv Submitted by: jtn Submitted on: Saturday 08/21/10 at 00:23 Category: client-gtk-2.0 Severity: 1 - Wish Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.3,2.3.0 ___ Details: Continuing the small-screens saga... When the option Arrange widgets for small displays is selected but Merge the message notebook and the map notebook isn't, causing the Messages to move to the right of the map rather than below it, the Messages tab tends to be taller and narrower, so having buttons going down the right hand side wastes space and reduces the width available for messages. See before screenshot. Attached patch adds yet another special case to the GUI code to catch this. See after screenshot. Experimentally on my system, this allows the window to be about 260 pixels narrower before scrollbars appear in this configuration than before (about 820x567 with the patch). I've checked all combinations of these two options and also Split bottom notebook area, and I haven't seen this make any of them worse. ___ File Attachments: --- Date: Saturday 08/21/10 at 00:23 Name: S2_2-trunk-small-layout-messages-buttons.diff Size: 911B By: jtn S2_2/trunk r17820: rearrange Message window buttons when using small widgets layout http://gna.org/bugs/download.php?file_id=9948 --- Date: Saturday 08/21/10 at 00:23 Name: before.png Size: 228kB By: jtn S2_2/trunk r17820: rearrange Message window buttons when using small widgets layout http://gna.org/bugs/download.php?file_id=9949 --- Date: Saturday 08/21/10 at 00:23 Name: after.png Size: 203kB By: jtn S2_2/trunk r17820: rearrange Message window buttons when using small widgets layout http://gna.org/bugs/download.php?file_id=9950 ___ Reply to this item at: http://gna.org/bugs/?16499 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16499] Space wasted on Messages tab in small widgets layout
Follow-up Comment #1, bug #16499 (project freeciv): this allows the window to be about 260 pixels narrower Ah no, my mistake; it wasn't a fair comparison as I didn't have all the report tabs open. ___ Reply to this item at: http://gna.org/bugs/?16499 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16500] Merge message/chat notebook and Split bottom notebook area don't interact well
URL: http://gna.org/bugs/?16500 Summary: Merge message/chat notebook and Split bottom notebook area don't interact well Project: Freeciv Submitted by: jtn Submitted on: Saturday 08/21/10 at 00:36 Category: client-gtk-2.0 Severity: 2 - Minor Priority: 1 - Later Status: Need Info Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: We've now got three interacting options in the Gtk2 client: * Arrange widgets for small displays * Merge the message notebook and the map notebook * Split bottom notebook area I've been playing with the various combinations. The latter two don't interact nicely; if they're both set, the Chat tab merges with the map/reports notebook, but the Messages tab is still separate at the bottom/right (depending on the first option). This seems unintuitive. Not sure what the right answer is. The simplest is just to ignore Split bottom notebook area whenever Merge the message notebook and the map notebook is selected (and document this). A quick look at the code suggests this is an oversight rather than deliberate. ___ File Attachments: --- Date: Saturday 08/21/10 at 00:36 Name: normal.png Size: 203kB By: jtn S2_2 r17820: screenshots with both quot;Merge message/chat notebookquot; and quot;Split bottom notebook areaquot; set http://gna.org/bugs/download.php?file_id=9951 --- Date: Saturday 08/21/10 at 00:36 Name: small.png Size: 198kB By: jtn S2_2 r17820: screenshots with both quot;Merge message/chat notebookquot; and quot;Split bottom notebook areaquot; set http://gna.org/bugs/download.php?file_id=9952 ___ Reply to this item at: http://gna.org/bugs/?16500 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen
Follow-up Comment #5, bug #16440 (project freeciv): Bit late but: Is this the right condition? I'd have thought you wanted to split the bar if Arrange widgets for small displays is set but Merge isn't set (because the chat window ends up taller and narrower) -- from your recent changes I'm guessing this is the configuration you're optimising for -- but not if Arrange widgets for small displays isn't set (that just wastes vertical space). Anyway, I can't get the voteinfo bar to display at all whenever I have Merge the message notebook and the map notebook set (with or without this change). Am I missing something, or is that a(nother) bug? ___ Reply to this item at: http://gna.org/bugs/?16440 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16464] gettext warnings in rulesets due to apostrophes
Update of bug #16464 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16464 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16500] Merge message/map notebook and Split bottom notebook area don't interact well
Update of bug #16500 (project freeciv): Summary: Merge message/chat notebook and Split bottom notebook area don't interact well = Merge message/map notebook and Split bottom notebook area don't interact well ___ Reply to this item at: http://gna.org/bugs/?16500 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Upcoming 2.2.3 release
The Freeciv 2.2.3 bugfix release is scheduled for a Sep 5 release. We've fixed many bugs in the previous release, and as a result there are currently about 2-4 untranslated or fuzzy strings in actively maintained translations. You might want to straighten those out. :) Keep up the good work! Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
