[Freeciv-Dev] [bug #18481] lua-5.1, ldebug.c compilation failure
Follow-up Comment #2, bug #18481 (project freeciv): It does not make the warning go away. The attached diff does, however I have no idea what consequences it might have. I don't use LUA, I can't really test it. You split this bug report in two, however the following is relevant to both of them: cc1: warnings being treated as errors ruleset.c: In function 'load_ruleset_game': ruleset.c:3231: warning: cast increases required alignment of target type And ruleset.c:3231 is: 3230 food_ini = secfile_lookup_int_vec(file, (size_t *) 3231 game.info.granary_num_inis, 3232 civstyle.granary_food_ini); secfile_lookup_int_vec, where the bus error occurs. The attached diff makes the warnings go away, but not the problem. I believe the patched lua code will produce more bus errors, regardless of the type the pointers are cast to. The solution to this is make a temporary variable, and copy stuff to it. That way it will be aligned. If not that, then add some __alignment__ (8) attribute to that LUA struct. Here is a relevant document: http://cmynhier.blogspot.com/2008/10/memory-alignment-on-sparc-or-300x.html (file #13833) ___ Additional Item Attachment: File name: fc.diffSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?18481 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2893] Road type accessor functions
URL: http://gna.org/patch/?2893 Summary: Road type accessor functions Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2011 05:44:24 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch adds road type accessor functions similar to those in our other classes. ___ File Attachments: --- Date: Thu 11 Aug 2011 05:44:24 PM EEST Name: RoadAccessors.diff Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=13834 ___ Reply to this item at: http://gna.org/patch/?2893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2894] Allow ai type parameter for /create even without module support
URL: http://gna.org/patch/?2894 Summary: Allow ai type parameter for /create even without module support Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2011 07:23:36 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch changes server to always accept ai type parameter to /create. While the only allowed value in current static builds is default, this has several advantages: 1) Command has same format regardless if module support is compiled in or not 2) Less complicated code easier to maintain 3) Future patches depend on this as they allow several statically linked ai types to choose from even when there is no actual loadable module support ___ File Attachments: --- Date: Thu 11 Aug 2011 07:23:36 PM EEST Name: AllowAiTypeAlways.diff Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=13835 ___ Reply to this item at: http://gna.org/patch/?2894 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18486] Xaw-client unit report multiplies units with city count
URL: http://gna.org/bugs/?18486 Summary: Xaw-client unit report multiplies units with city count Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2011 07:49:31 PM EEST Category: client-xaw Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.8, 2.3.1, 2.4.0 ___ Details: There's extra city list iteration around iteration of *all* units in xaw-clients real_units_report_dialog_update(). This means that *all* units, and their upkeep, is counted once for each city, i.e., their count is multiplied by city count. Fix attached. ___ File Attachments: --- Date: Thu 11 Aug 2011 07:49:31 PM EEST Name: XawUnitCountNotMultipliedByCityCount.diff Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=13839 ___ Reply to this item at: http://gna.org/bugs/?18486 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2895] List max used packet number in packets.def
URL: http://gna.org/patch/?2895 Summary: List max used packet number in packets.def Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2011 08:37:56 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch adds comment to beginning of packets.def listing max packet number currently in use. I remember that we used to have that, but now I didn't find it. I assume someone has removed it thinking that it's not needed as one can check last packet number from the end of file. So this patch adds also explanatory comment why one cannot rely on last defined packet to have highest id, and how that makes it important to have max number listed in the beginning. ___ File Attachments: --- Date: Thu 11 Aug 2011 08:37:56 PM EEST Name: MaxPackNumberComment.diff Size: 620B By: cazfi http://gna.org/patch/download.php?file_id=13840 ___ Reply to this item at: http://gna.org/patch/?2895 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2896] Debian packet versioning
URL: http://gna.org/patch/?2896 Summary: Debian packet versioning Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2011 09:20:39 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch improves version numbering of generated debian packets. - Run ./fc_version to get version number instead of relying in it's implementation details and grepping parts of the script - Version label included - Works also outside svn checkout - just doesn't include revision information - ChangeLog entry generated with more correct description ___ File Attachments: --- Date: Thu 11 Aug 2011 09:20:40 PM EEST Name: DebVer.diff Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=13841 ___ Reply to this item at: http://gna.org/patch/?2896 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2868] API_TYPE_CONECTION - API_TYPE_CONNECTION
Update of patch #2868 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2868 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2513] [lua01] rename files (preparation for lua module rework)
Follow-up Comment #11, patch #2513 (project freeciv): The attached patch includes the minimal changes needed to compile freeciv after moving the files. Not yet acceptable, but at least we are going to right direction. 1) I really want to have file moving commit as simple as possible. So if at all possible (and I don't see why it wouldn't be possible) moving of code between files should be separate ticket to be committed *before* this moving of files. 2) I don't think this is yet *minimum* change as there is for example changes to client/Makefile.am which should not be affected at all by the movement of files still used by server only. I'm concentrating to this step first. I'm not yet looking further patches in the seraies at all. ___ Reply to this item at: http://gna.org/patch/?2513 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2513] [lua01] rename files (preparation for lua module rework)
Update of patch #2513 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #12: so you say the order should be: 1. moving code 2. rename files 3. cleanup / changes ___ Reply to this item at: http://gna.org/patch/?2513 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2840] Make autosettlers consider improving resource tiles
Follow-up Comment #6, patch #2840 (project freeciv): I've checked that advisors code in S2_2 didn't use virtual tiles like S2_2 and TRUNK do, so it's not affected by the bug. I'm still running some autogame testing for this patch. ___ Reply to this item at: http://gna.org/patch/?2840 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2889] Allow autosettlers to plan for farmland
Follow-up Comment #3, patch #2889 (project freeciv): One note: With default ruleset this only affects autosettlers working for human players, not current ai (though this is step to correct direction - this makes it easier to fully fix ai later). Problem with ai is another chicken egg case. It sees no benefit in making farmland as long as there's no supermarkets. It sees no benefit in building supermarket as long as there's no farmland. Humna player may build supermarket even before there is farmland (though this means paying building upkeep for nothing until some farmland is made) ___ Reply to this item at: http://gna.org/patch/?2889 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2889] Allow autosettlers to plan for farmland
Update of patch #2889 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi Planned Release: = 2.4.0 ___ Reply to this item at: http://gna.org/patch/?2889 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2521] [metaticket] Generic road code
Update of patch #2521 (project freeciv): Status:None = In Progress Planned Release: 2.4.0 = 2.5.0 ___ Reply to this item at: http://gna.org/patch/?2521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17488] Configure fails without C++ compiler
Update of bug #17488 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17488 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2830] ser - fcser, civ - fcgui
Update of patch #2830 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2830 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2834] genlist mutex
Update of patch #2834 (project freeciv): Planned Release: 2.4.0 = 2.5.0 ___ Follow-up Comment #1: There will be no users for this in 2.4.0, so it would only increase resource usage with no any benefits. ___ Reply to this item at: http://gna.org/patch/?2834 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2867] MySQL configure checks in 64bit RedHat derivatives
Update of patch #2867 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2867 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2897] Morocco files
URL: http://gna.org/patch/?2897 Summary: Morocco files Project: Freeciv Submitted by: karim88 Submitted on: Fri 12 Aug 2011 05:41:12 AM GMT Category: rulesets Priority: 9 - Immediate Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Pealse Add This Filles or Edit it if you don't want to add it ___ File Attachments: --- Date: Fri 12 Aug 2011 05:41:12 AM GMT Name: maroc.ruleset Size: 1kB By: karim88 http://gna.org/patch/download.php?file_id=13844 --- Date: Fri 12 Aug 2011 05:41:12 AM GMT Name: maroc-shield.png Size: 512B By: karim88 http://gna.org/patch/download.php?file_id=13845 --- Date: Fri 12 Aug 2011 05:41:12 AM GMT Name: maroc.png Size: 681B By: karim88 http://gna.org/patch/download.php?file_id=13846 ___ Reply to this item at: http://gna.org/patch/?2897 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
