[Freeciv-Dev] [patch #5355] multiplayer ruleset: Notify the player about techs gained by script.lua

2014-10-19 Thread Jacob Nevins
Update of patch #5355 (project freeciv):

 Assigned to:sveinung = jtn


___

Reply to this item at:

  http://gna.org/patch/?5355

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22827] multiplayer ruleset: i18n problems with script.lua

2014-10-19 Thread Jacob Nevins
Follow-up Comment #2, bug #22827 (project freeciv):

Yes, I will.

___

Reply to this item at:

  http://gna.org/bugs/?22827

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5358] multiplayer ruleset: Inform embassies about techs gained from Lua.

2014-10-19 Thread Jacob Nevins
Update of patch #5358 (project freeciv):

 Assigned to:sveinung = jtn


___

Reply to this item at:

  http://gna.org/patch/?5358

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22827] multiplayer ruleset: i18n problems with script.lua

2014-10-19 Thread Jacob Nevins
Update of bug #22827 (project freeciv):

 Planned Release:  2.5.0-beta2, 2.6.0 = 2.4.4, 2.5.0-beta2, 2.6.0


___

Reply to this item at:

  http://gna.org/bugs/?22827

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5374] rulesets: Document script.lua by adding comments.

2014-10-19 Thread Jacob Nevins
Update of patch #5374 (project freeciv):

  Status:Done = In Progress
 Assigned to:sveinung = jtn
 Open/Closed:  Closed = Open   
 Planned Release:2.6.0, 2.5.0 = 2.6.0, 2.5.0, 2.4.4


___

Reply to this item at:

  http://gna.org/patch/?5374

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22793] Some comments/docs still claim ruleset (etc) files use ISO8859-1 encoding

2014-10-19 Thread Jacob Nevins
Update of bug #22793 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-encoding-docs.patch Size:8 KB
File name: S2_4-encoding-docs.patch   Size:8 KB


___

Reply to this item at:

  http://gna.org/bugs/?22793

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5356] multiplayer ruleset: Explain what goes on with tech giving in script.lua

2014-10-19 Thread Jacob Nevins
Update of patch #5356 (project freeciv):

 Open/Closed:  Closed = Open   


___

Reply to this item at:

  http://gna.org/patch/?5356

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5374] rulesets: Document script.lua by adding comments.

2014-10-19 Thread Jacob Nevins
Update of patch #5374 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #3:

Backport to S2_4, on general principles

(file #22659)
___

Additional Item Attachment:

File name: S2_4-script-lua-comments.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/patch/?5374

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5358] multiplayer ruleset: Inform embassies about techs gained from Lua.

2014-10-19 Thread Jacob Nevins
Update of patch #5358 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?5358

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5356] multiplayer ruleset: Explain what goes on with tech giving in script.lua

2014-10-19 Thread Jacob Nevins
Update of patch #5356 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?5356

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5355] multiplayer ruleset: Notify the player about techs gained by script.lua

2014-10-19 Thread Jacob Nevins
Update of patch #5355 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?5355

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22824] multiplayer ruleset: Savegames not portable against ruleset changes due to saved script variables

2014-10-19 Thread Jacob Nevins
Update of bug #22824 (project freeciv):

  Status:None = In Progress
 Assigned to:None = jtn
 Planned Release: = 2.4.4, 2.5.0, 2.6.0


___

Reply to this item at:

  http://gna.org/bugs/?22824

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22833

 Summary: Client crash when popping up first city dialog
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 19 Oct 2014 11:35:33 BST
Category: client-gtk-3.0
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

A Debian testing (Jessie) user amie78 reports that freeciv-gtk3 crashes when
they try to create their first city, at the point the city dialog would pop
up.

They initially experienced this with freeciv-gtk3 from the Debian 2.4.3-2
package, and reproduced it with a self-compiled version of our upstream 2.4.3
tarball. Backtrace http://pastebin.com/65qFBzLE from that:


(gdb) bt full
#0  __strcmp_ssse3 () at ../sysdeps/x86_64/multiarch/../strcmp.S:209
No locals.
#1  0x00493af4 in cell_data_func (col=optimized out, cell=0x378e870,
model=optimized out, it=optimized out, data=optimized out) at
cma_fe.c:194
pdialog = optimized out
s1 = 0x0
s2 = 0x595ec3 custom
i1 = 1
i2 = -1
param = {minimal_surplus = {0, 0, 0, 0, 0, 0}, require_happy = false,
allow_disorder = false, allow_specialists = true, factor = {1, 1, 1, 1, 1, 1},
happy_factor = 1}
path = optimized out
#2  0x7f4b12e7a39e in apply_cell_attributes () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#3  0x7f4b113f6240 in g_hash_table_foreach () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#4  0x7f4b12e7a411 in gtk_cell_area_real_apply_attributes () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#5  0x7f4b12e83212 in gtk_cell_area_box_apply_attributes () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#6  0x7f4b12fb08f6 in _gtk_marshal_VOID__OBJECT_BOXED_BOOLEAN_BOOLEANv ()
from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#7  0x7f4b116dc474 in ?? () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#8  0x7f4b116f6057 in g_signal_emit_valist () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#9  0x7f4b116f69af in g_signal_emit () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#10 0x7f4b12e7ce01 in gtk_cell_area_apply_attributes () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#11 0x7f4b13136bbd in gtk_tree_view_column_cell_set_cell_data () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#12 0x7f4b12dd5e59 in set_cell_data () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#13 0x7f4b12dd6050 in create_cell () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#14 0x7f4b12dd6177 in gtk_tree_view_accessible_ref_child () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#15 0x7f4b0fc0ac05 in ?? () from
/usr/lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0
No symbol table info available.
#16 0x7f4b116edadb in ?? () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#17 0x7f4b116f6748 in g_signal_emit_valist () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#18 0x7f4b116f6efa in g_signal_emit_by_name () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#19 0x7f4b12dd7f5d in _gtk_tree_view_accessible_add () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#20 0x7f4b13120d66 in gtk_tree_view_row_inserted () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#21 0x7f4b12face6a in _gtk_marshal_VOID__BOXED_BOXED () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#22 0x7f4b116dc245 in g_closure_invoke () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#23 0x7f4b116edf3c in ?? () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#24 0x7f4b116f6748 in g_signal_emit_valist () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#25 0x7f4b116f69af in g_signal_emit () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#26 0x7f4b130f4cec in gtk_tree_model_row_inserted () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#27 0x7f4b12fa03d3 in gtk_list_store_insert () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#28 

[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread Jacob Nevins
Follow-up Comment #1, bug #22833 (project freeciv):

(I've had a word with the Debian maintainer about making users less likely to
run into freeciv-gtk3 until it's less experimental.)

___

Reply to this item at:

  http://gna.org/bugs/?22833

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22827] multiplayer ruleset: i18n problems with script.lua

2014-10-19 Thread Jacob Nevins
Update of bug #22827 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-multiplayer-lua-i18n.patch Size:2 KB
File name: S2_4-multiplayer-lua-i18n.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?22827

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22824] multiplayer ruleset: Savegames not portable against ruleset changes due to saved script variables

2014-10-19 Thread Jacob Nevins
Update of bug #22824 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-S2_4-multiplayer-lua-state.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?22824

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22832] create_command_newcomer() doesn't call player_nation_defaults()

2014-10-19 Thread Jacob Nevins
Update of bug #22832 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-S2_4-create-newcomer-nation.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?22832

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22825] aqueductloss setting description not sufficiently generalised

2014-10-19 Thread Jacob Nevins
Update of bug #22825 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-S2_4-aqueductloss-description.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22825

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22803] Plague should reduce foodbox like starvation does

2014-10-19 Thread Jacob Nevins
Update of bug #22803 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-plague-food-loss.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?22803

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-19 Thread Jacob Nevins
Update of patch #5367 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:  pepeto = jtn

___

Follow-up Comment #2:

Darn, I wrote this patch before noticing that pepeto had taken the ticket.
pepeto, feel free to steal it back for further work.

From the comments, these are the new criteria as of this patch (2, 5, and 6
are my new conditions):

0 Transports which have orders, or are on transports with orders, are less
preferable to transport stacks without orders (to avoid loading on units that
are just passing through); else
0 Transports which are idle are preferable (giving players some control over
loading) -- this does not check transports of transports; else
0 Transports from which the cargo could unload at any time are preferable to
those where the cargo can only disembark in cities/bases; else
0 Transports which are less deeply nested are preferable; else
0 Transport stacks where the outermost transport has more moves left are
preferable (if we're loading now, presumably it's the outermost transport
that's about to move); else
0 Direct transports with more moves left are preferable.

Of these (2) might be the most controversial. I thought it was worth giving
users control over which transport was chosen (as I said in patch #4982, but I
was wrong that it was already possible). Note that this doesn't stop automatic
pathfinding using sentried pontoon bridges etc.

Also: I think that as of patch #4982, the lexicographic ordering was not as
intended; depending on the order of the units on the tile, I think depth might
trump has_orders, which I don't think was intended.
Attached patch also fixes this, but the code is quite ugly. I couldn't think
of a nice idiomatic way to express this kind of comparison in C.

(file #22666, file #22667)
___

Additional Item Attachment:

File name: trunk-choose-transport-3.patch Size:4 KB
File name: S2_5-choose-transport-3.patch  Size:4 KB


___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22823] World-ranged tech requirements have implicit survives flag

2014-10-19 Thread Jacob Nevins
Update of bug #22823 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release:   2.6.0 = 2.4.4, 2.5.0, 2.6.0

___

Follow-up Comment #2:

Also patches for stable branches which correct autogenerated help to match the
semantics on those branches (which aren't changing). (I don't think this
affects any rulesets I know about.)

(file #22668, file #22669)
___

Additional Item Attachment:

File name: trunk-world-tech-survives.patch Size:27 KB
File name: S2_5-S2_4-world-tech-survives.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22823

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21038] Many GUI problems with CJK input method = replace gtk2 DLLs with version =2.24.14

2014-10-19 Thread anonymous
Follow-up Comment #64, bug #21038 (project freeciv):

Is there still a multiplayer community using it? 
Yes, Longturn is still using 2.3
Both LT33 and the current ladder wars are likely to continue for a few more
months. If 2.5 is released in the next six months it is likely that Longturn
will move to 2.5 and skip 2.4 Otherwise LT34 could also be on 2.3 as well.

___

Reply to this item at:

  http://gna.org/bugs/?21038

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread Jacob Nevins
Follow-up Comment #2, bug #22833 (project freeciv):

Viel Gold that appears in the backtrace is a custom governor preset.

___

Reply to this item at:

  http://gna.org/bugs/?22833

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22834] City map not greyed out when governor enabled

2014-10-19 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22834

 Summary: City map not greyed out when governor enabled
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 19 Oct 2014 15:17:18 BST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r26792
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

In the Gtk2 client, when the city governor is in control, the city map view
has a translucent overlay to indicate why it's not sensitive.

In the Gtk3 client, there's no such indication (at least for me, with amplio2
and trident tilesets).




___

Reply to this item at:

  http://gna.org/bugs/?22834

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread Jacob Nevins
Follow-up Comment #3, bug #22833 (project freeciv):

Wait, this is a duplicate of bug #21942. Sigh.

___

Reply to this item at:

  http://gna.org/bugs/?22833

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21942] Crash when opening city window with gtk3

2014-10-19 Thread Jacob Nevins
Update of bug #21942 (project freeciv):

Category:None = client-gtk-3.0 

___

Follow-up Comment #8:

Bug #22833 is another report of this (same backtrace signature).

___

Reply to this item at:

  http://gna.org/bugs/?21942

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5379] Add function to figure out if a unit can do an action given a local DiplRel

2014-10-19 Thread Sveinung Kvilhaugsvik
Update of patch #5379 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5379

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5375] Improve accuracy of enabling the action vs own tile menu item.

2014-10-19 Thread Sveinung Kvilhaugsvik
Update of patch #5375 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5375

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread Jacob Nevins
Follow-up Comment #4, bug #22833 (project freeciv):

So the question is, in cell_data_func() how did 's1' (retrieved from the
GtkListStore model behind the tree view) come to be NULL? Clearly
cell_data_func() wasn't expecting this.

I'm suspicious that the presence of the following is somehow involved:
* customised governor presets
* non-English (German) localisation; I'm not sure what the localisation vs
rule_name story is for the names of presets, but it seems they have been
translated by the time they get this far

___

Reply to this item at:

  http://gna.org/bugs/?22833

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22835] Gold income not computed correctly when server needs to recompute city productions (e.g. when a city grows)

2014-10-19 Thread Rogier
URL:
  http://gna.org/bugs/?22835

 Summary: Gold income not computed correctly when server needs
to recompute city productions (e.g. when a city grows)
 Project: Freeciv
Submitted by: rogier
Submitted on: Sun 19 Oct 2014 05:16:26 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The gold income from a city is not computed correctly when the server needs to
recompute the city productions between turns. This happens for instance when
the city grows. See the attached savegame.

There is one city: Paris. It should have 20 happy citizens and 19 tax
collectors. Current production is coinage. I enabled the CMA, to make sure the
city maintains the desired production values.

Given these settings, Paris is expecting to earn an income of 248 gold for the
next turn, consisting of 202 tax and 46 coinage production.

After finishing the turn however, the actual income appears to have been a
mere 106 gold.

The problem becomes apparent when disabling the CMA before ending the turn: at
the start of the new turn, the expected income is in fact exactly 106 gold.

I suspect the following happens (deduced partly from the freeciv source):

- Before the tax income is computed, the city grows, and the production values
are recomputed by the server, presumably without regard to the CMA
preferences. This resets all tax collectors to researchers.
- The server then uses the newly-computed production values (i.e. the
post-growth values) to compute the income (which I found surprising. I had
assumed that the income was always earned during the *previous* turn).
- Only later does the CMA recompute the city production according to the CMA
preferences, leaving the user utterly puzzled as to why the income is less
than half of what was expected.

If I modify the CMA preferences to maximize gold, which stops the celebration,
and thus the growth, the expected income of 244 is actually earned. This
suggests that the problem only happens when the server needs to recompute city
production values.

Kind regards,

Rogier.





___

File Attachments:


---
Date: Sun 19 Oct 2014 05:16:26 PM UTC  Name:
test-cma-T0001-Y-3999-manual.sav.bz2  Size: 14kB   By: rogier

http://gna.org/bugs/download.php?file_id=22671

___

Reply to this item at:

  http://gna.org/bugs/?22835

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22833] Client crash when popping up first city dialog

2014-10-19 Thread anonymous
Additional Item Attachment, bug #22833 (project freeciv):

File name: .freeciv-client-rc-2.4 Size:8 KB


___

Reply to this item at:

  http://gna.org/bugs/?22833

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22830] pf_map_path() assertion failures when AWACS return to refuel

2014-10-19 Thread pepeto
Update of bug #22830 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?22830

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22831] Many client assertion failures when creating player midgame

2014-10-19 Thread pepeto
Update of bug #22831 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?22831

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-19 Thread pepeto
Follow-up Comment #3, patch #5367 (project freeciv):

2. Idle units should maybe include sentried, fortifying, or fortified ones?

The C condition looks very ugly. I have some idea to improve it (if I have
time before you commit your patch).


___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-19 Thread Jacob Nevins
Follow-up Comment #4, patch #5367 (project freeciv):

 2. Idle units should maybe include sentried, fortifying, or 
 fortified ones?
I explicitly didn't include these, so that users can override the automatic
selection by putting the transport they didn't want chosen into sentry mode.

Yes, this is a UI hack (compensating for the lack of bug #13943), and will
probably confuse someone, but without it the only ways to override unwanted
transport selection probably involve spending movement points; whereas if you
wanted to load onto a fortified transport in the presence of an idle one (and
for some reason you couldn't sentry/fortify the unwanted one), making the
fortified unit temporarily idle for loading then fortifying again doesn't lose
fortified status.

 The C condition looks very ugly. I have some idea to improve 
 it (if I have time before you commit your patch).
Feel free. I'll hold off committing. It is very ugly.

___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev