[Freeciv-Dev] [patch #7589] Share unithand's action not enabled reason

URL: Summary: Share unithand's action not enabled reason Project: Freeciv Submitted by: sveinung Submitted on: Wed 10 Aug 2016 04:07:44 PM UTC Category: general Priority: 5 -

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #3, bug #24942 (project freeciv): Attached patch uses pkg-config to discover Qt and sets --std=c++11 if needed. Besides MSVC, I don't know of compilers using other flags. I didn't use --std=c++0x because it enabled *experimental* C++11 support and is deprecated in recent GCC.

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #6, bug #24942 (project freeciv): > A pc file is provided by Qt itself It didn't back then when we added .m4 files. It's possible that all Qt5 versions have provided them, though. Anyway, compatibility issues with oldest supported (by us) versions need to be checked.

[Freeciv-Dev] [patch #7589] Share unithand's action not enabled reason

Update of patch #7589 (project freeciv): Depends on: => patch #7582 ___ Follow-up Comment #1: Textual dependence on patch #7582. (It adds two action not enabled explanation kinds)

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #4, bug #24942 (project freeciv): Didn't check the patch yet, but couple of general notes before I forget: 1) pkg-config for Qt should set --std=c++11 if it needs it, so it's bug there if we need to set it separately 2) We have macros to set flags only when used compiler

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #5, bug #24942 (project freeciv): Devil is in the details. Really works now... (file #28240) ___ Additional Item Attachment: File name: qt-use-pkg-config-2.patch.bz2 Size:1 KB

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

Update of bug #24935 (project freeciv): Status:None => Ready For Test Planned Release: => 2.5.6, 2.6, 3.0 Contains string changes:None => No

[Freeciv-Dev] [patch #7570] Reduce want of pile of caravans

Update of patch #7570 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7576] SDL client: act sel dlg paradrop and airlift

Update of patch #7576 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7575] SDL client(s): ask for target for "Do..."

Update of patch #7575 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7572] Support user specified target tile for "Do..."

Update of patch #7572 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #24944] Qt client - crash when metaserver is down

Update of bug #24944 (project freeciv): Status: Ready For Test => Duplicate Open/Closed:Open => Closed ___ Follow-up Comment #1: Fixed in bug

[Freeciv-Dev] [bug #24084] citizen_base_mood: comparison is always true due to limited range of data type

Update of bug #24084 (project freeciv): Status: In Progress => Duplicate Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

Follow-up Comment #3, patch #7490 (project freeciv): Same class without C++11, and renamed to "listener", which is more specific. The API has changed a bit and now requires the listener to register once it's ready. Please reopen. (file #28256)

[Freeciv-Dev] [patch #7582] Action not enabled explain actor tgt distance

Update of patch #7582 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7580] Qt client: act sel dlg paradrop and airlift

Update of patch #7580 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7584] webperimental: set default citymindist to 3

Update of patch #7584 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7578] 2nd targeted "Do..." means target own tile

Update of patch #7578 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7579] Qt client: ask for target for "Do..."

Update of patch #7579 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7581] Forbid paradropping to same tile unit already is

Update of patch #7581 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed Contains string changes: No => Yes

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

URL: Summary: Client freezes when connecting to local server Project: Freeciv Submitted by: louis94 Submitted on: jeu. 11 août 2016 01:26:10 UTC Category: client Severity: 3 -

[Freeciv-Dev] [bug #23992] Client page change in queue mess

Update of bug #23992 (project freeciv): Status:None => Ready For Test Planned Release:2.6.0, 3.0.0 => 2.5.6, 2.6.0, 3.0.0 ___ Follow-up Comment #1: Fix. I first

[Freeciv-Dev] [patch #7593] Delete unused act vs own tile functions

URL: Summary: Delete unused act vs own tile functions Project: Freeciv Submitted by: sveinung Submitted on: Thu 11 Aug 2016 01:53:35 AM UTC Category: client Priority: 5 -

[Freeciv-Dev] [patch #7574] Gtk clients: act sel dlg paradrop and airlift

Update of patch #7574 (project freeciv): Summary: Gtk 3 clients: act sel dlg paradrop and airlift => Gtk clients: act sel dlg paradrop and airlift ___ Follow-up Comment #3: Do so for the Gtk 2.0 client too. (file #28244)

[Freeciv-Dev] [patch #7577] Tileset "for_ruleset"

Update of patch #7577 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7573] Gtk clients: ask for target for "Do..."

Update of patch #7573 (project freeciv): Summary: Gtk 3 clients: add "Do To..." => Gtk clients: ask for target for "Do..." ___ Follow-up Comment #2: > This was chosen rather than having "Do..." start asking for the target

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

URL: Summary: Old base "Diplomat_Defense" not recreatable Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2016 10:17:36 PM EEST Category: general Severity: 5 -

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #1, bug #24956 (project freeciv): Base Diplomat_Defense didn't work in cities. Spy_Resistant's impact on building sabotage is therefore irrelevant. Real bug (source of the confusion?): A third party ruleset may contain a Diplomat_Defense base that can be built inside a city.

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

Update of bug #24957 (project freeciv): Category: freeciv-web => general Status:None => Ready For Test Planned Release: => 3.0.0

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #2, bug #24956 (project freeciv): > Base Diplomat_Defense didn't work in cities. It didn't? (Note that since this change is only in TRUNK, also the S2_6 ruleset formats should be considered - not what already existing S2_5 rulesets do)

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #7, bug #24956 (project freeciv): Before S2_6 it was a hardcoded rule that bases cannot exist inside cities. S2_6 allow bases (like any extras) inside cities unless ruleset says otherwise. When they exist inside cities, they should also work as they usually do. For this

[Freeciv-Dev] [patch #7566] Output_Waste_By_Rel_Distance

Update of patch #7566 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Update of bug #24956 (project freeciv): Status:None => Ready For Test Assigned to:None => sveinung Release: => TRUNK Operating System:

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #3, bug #24956 (project freeciv): > It didn't? if (tile_city(pdefender_tile)) { /* Reduce the chance of an attack by EFT_SPY_RESISTANT percent. */ chance -= chance * get_city_bonus(tile_city(pdefender_tile), EFT_SPY_RESISTANT) /

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

URL: Summary: Segmentation faul in is_action_enabled.constprop Project: Freeciv Submitted by: andreasr Submitted on: Wed 10 Aug 2016 07:44:41 PM UTC Category: freeciv-web

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #4, bug #24956 (project freeciv): Right. But that in turn then seems like a bug in S2_6 where bases should work inside cities too. ___ Reply to this item at:

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Follow-up Comment #6, bug #24956 (project freeciv): > Seems like a bug in S2_6 where bases should work inside cities too. They should? ___ Reply to this item at:

[Freeciv-Dev] [bug #24947] Caravans can't plan over 1-tile long routes

Update of bug #24947 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

Follow-up Comment #2, bug #24957 (project freeciv): Yes, the patch has fixed this, based on 0 crashes in 614 games. ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

Follow-up Comment #1, bug #24961 (project freeciv): Have u checked if it related to internet servers too? Maybe your computer tries to resolve your computer name by doing and cannot do it. Its other bug than Griffon, he specified that he cannot connect even when using localhost as hostname.

[Freeciv-Dev] [bug #24948] Comparisons against negative 'citizens' values

Update of bug #24948 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #11, bug #24942 (project freeciv): > one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without C++11 support. User can still override the std version in CXXFLAGS. I'm more concerned about those users who see their standard version going to older one because of

[Freeciv-Dev] [bug #23988] Feature request: all units on a tile are shown in the bar on the right side

Update of bug #23988 (project freeciv): Category: client-gtk-2.0 => client-gtk-3.0 Status:None => Ready For Test Planned Release: => 2.6.0, 3.0.0

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

Update of patch #7490 (project freeciv): Status: Wont Do => None Open/Closed: Closed => Open ___ Follow-up Comment #4: Pls use

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

Update of patch #7491 (project freeciv): Status: Wont Do => None Open/Closed: Closed => Open ___ Reply to this item at:

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

Follow-up Comment #1, bug #23911 (project freeciv): Disband gives only 50% of the shields, so it's not same as Help Wonder. So it's only correct that restrictions to Help Wonder do not apply to a caravan (and only caravan?) doing disband.

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

Follow-up Comment #2, bug #23911 (project freeciv): > Disband gives only 50% of the shields, Not if you follow the procedure below. It will give you 100% of the shields. (Unless it has changed since I filed this bug) ___ Reply to this item

[Freeciv-Dev] [bug #24094] ai/default/aisettler.c::1251]: Tekun Umam: Failed to build city at (48, 28)

Follow-up Comment #12, bug #24094 (project freeciv): updated of trunk version: * moved sharing of action not enabled reason to patch #7589 (file #28250) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

Update of bug #24956 (project freeciv): Status: Ready For Test => None Assigned to:sveinung => None ___ Follow-up Comment #8: If 2.6 starts

[Freeciv-Dev] [bug #24921] After sinking a Transport, a Riflemen unit is left behind in the sea

Update of bug #24921 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24960] req_edit::select_req() crash when adding new requirement

URL: Summary: req_edit::select_req() crash when adding new requirement Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2016 03:07:55 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [patch #7591] Merge ruledit_qt_setup(), ruledit_qt_run(), and ruledit_qt_close()

URL: Summary: Merge ruledit_qt_setup(), ruledit_qt_run(), and ruledit_qt_close() Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2016 02:38:12 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #9, bug #24942 (project freeciv): > For the C++11 problem, would something as simple as attached patch work? Such a patch would work. On the other hand, one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without C++11 support. This would make it more difficult to

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #10, bug #24942 (project freeciv): (In the code below, #0x050700 should read 0x050700. Habit from CSS: every hex number begins with #... Sorry) ___ Reply to this item at:

[Freeciv-Dev] [patch #7592] Support editing requirement value, as long as kind is "tech"

URL: Summary: Support editing requirement value, as long as kind is "tech" Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Aug 2016 03:12:24 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [patch #7571] universal_value_from_str()

Update of patch #7571 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #7, bug #24942 (project freeciv): I checked Kde Neon Developer Edition, which ships Qt 5.7 on a Ubuntu 14.04-based system. The default compiler there is GCC 5.4, which defaults to C++98. With my patch, freeciv configures fine but build fails (in Qt) as if std::nullptr_t == int.

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

Follow-up Comment #8, bug #24942 (project freeciv): For the C++11 problem, would something as simple as attached patch work? That would be something I would be ready accept even to S2_5. Preferring pkg-config is probably a good idea (we've headed towards it in general, and we probably have many

[Freeciv-Dev] [bug #24945] Dead player's client has Turn Done button enabled

Update of bug #24945 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7588] 'struct timeval' to 'fc_timeval'

URL: Summary: 'struct timeval' to 'fc_timeval' Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2016 03:10:21 PM EEST Category: general Priority: 5 - Normal