Re: [Freeciv-Dev] (PR#39359) [patch] Don't overwrite CFLAGS
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39359 On Fri, 27 Apr 2007, Per I. Mathisen wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39359 On Thu, 26 Apr 2007, Bastiaan Jacques wrote: The old CFLAGS is readded a bit later in the same file. What problem does this patch solve? The problem is that the old CFLAGS are added 300 lines after they are removed. So they are not used for many package tests. So if use CFLAGS=-I/usr/local/include ./configure ... then the /usr/local/include path will not be used for detecting packages like SDL. That is what --with-sdl-prefix and friends are for. I believe the reason why CFLAGS are omitted for the tests is because some CFLAGS can make some tests fail mysteriously. Although I am not sure why it is structured exactly the way it is. Well, --with-sdl-prefix works, unless you are using the sdl client. Because in the SDL client, SDL includes are included like #include SDL/larlar.h while in the SDL audio code they're included like #include larlar.h. So if you're using --with-sdl-prefix you won't be able to build the sdl client. So I tried to mend the situation by using the CFLAGS environment variable, which obviously doesn't work for freeciv as it does in most other projects which use configure. In my opinion, we should remove the code which temporarily disables everything passed in CFLAGS. If there are any CFLAGS of which we *know* they break freeciv, then we can filter for them specifically. Also, we should standardise SDL includes (be consistent there). What do you think? Bastiaan ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39356) RFE: Ability to save/load startup options for client
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39356 Kevin Benton wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39356 It would really help to be able to save the server options from the client when starting a game, especially for those of us who like to play similar styles of games to master play types. The /read and /write server commands do this. What's needed is a GUI dialog interface for them (as /save and /load have). -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39360) 2.1.0b4 civclient usability changed for worse
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39360 Kevin Benton wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39360 Usability dramatically decreased with 2.1.0b4. After creating a new game, I changed the worklist immediately to settlers, settlers, settlers, settlers, warriors, settlers, warriors, coinage. Also, I created a new worklist, added items to it, then changed the name of the worklist. Once the name changed, my items disappeared from the worklist. :-( When I click save options in the UI, it does not save work lists, and it seems it also doesn't want to save CMA's. Users are not able to turn off production views in ISOTrident or amplio. I haven't tried the other tile sets. I could go on, but this is enough for a start. I would rather go back to b3 than continue with this UI. You are talking about changes from beta3 to beta4? If so, you must surely be mistaken...only a few bug fixes were added in between those two releases. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
