[Freeciv-Dev] (PR#39510) [Bug] Rootstrap issue with generate_packets.py generated files

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39510 > Now we no longer have files generated by generate_packets.py in svn, I have encountered one problem. When fresh copy from svn is compiled first time, there is no previous .deps. So Makefile sees no header dependencies for compiling some .c

Re: [Freeciv-Dev] (PR#20721) remove x.213/x.252

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=20721 > On 12/09/06, Jason Dorje Short <[EMAIL PROTECTED]> wrote: > > This patch removes the obsoleted x.213 and moves x.252 over to x.m4. These relics from autoconf2.13 can be confusing. I'm going to commit this to S2_1 too, combined with #39495.

[Freeciv-Dev] (PR#39509) [Patch] Silence autosettler error message about existing city

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39509 > It is not an error that there is already an city when ai_do_build_city() is called, altough it is very rare situation. Instead of adding (costly) extra checks before calling ai_do_build_city(), we do just fine relying in internal checks of a

Re: [Freeciv-Dev] (PR#39490) Deprecated forms of AC_INIT and AM_INIT_AUTOMAKE

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39490 > On 05/08/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > Good news is that version.in is now used only by configure.ac. So > there is no real need to wrap everything in language-independent > macros. This patch converts version.in to no

Re: [Freeciv-Dev] (PR#38245) [Bug] Sun Tzu always marked redundant

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=38245 > On 06/08/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > - Made code more intuitive. Instead of booleans use problem_type enum > values RPT_POSSIBLE and RPT_CERTAIN - Some places were still using TRUE and FALSE. Fixed - ML diff -Nur

Re: [Freeciv-Dev] (PR#39508) [Patch] Fix hash callback function registration.

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39508 > > Fix attached. Includes Here - ML diff -Nurd -X.diff_ignore freeciv/utility/hash.c freeciv/utility/hash.c --- freeciv/utility/hash.c 2007-08-04 18:36:14.0 +0300 +++ freeciv/utility/hash.c 2007-08-08 02:12:40.0 +0300 @@

[Freeciv-Dev] (PR#39508) [Patch] Fix hash callback function registration.

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39508 > hash_new_full() forgot to pass callback functions it gets as parameters to lower levels for registration. Fix attached. Includes also some documentation about these callbacks. - ML ___ Freeci

Re: [Freeciv-Dev] (PR#39507) [Patch] Fix memory leak from section file handling

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39507 > On 07/08/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > Fix attached. section_file_read_dup() never release inf. Who ever > allocates inf, always releases it. S2_0 version. - ML diff -Nurd -X.diff_ignore freeciv/utility/registry.c

[Freeciv-Dev] (PR#39507) [Patch] Fix memory leak from section file handling

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39507 > section_file_read_dup() called inf_close() only in the end - many return points (not even error related) missed it. It seems wrong that caller allocates inf, but section_file_read_dup() would release it. Fix attached. section_file_read_du

[Freeciv-Dev] (PR#39506) [Patch] Fix bug contact in man pages

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39506 > $subject - ML diff -Nurd -X.diff_ignore freeciv/doc/man/civclient.6 freeciv/doc/man/civclient.6 --- freeciv/doc/man/civclient.6 2007-08-04 18:36:17.0 +0300 +++ freeciv/doc/man/civclient.6 2007-08-07 20:23:15.0 +0300 @@ -2

[Freeciv-Dev] (PR#39505) [Patch] Fix xaw base building handling

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39505 > Changes required by #37611 to xaw. Implementation is similar to what gtk has after #38016. - ML diff -Nurd -X.diff_ignore freeciv/client/gui-xaw/actions.c freeciv/client/gui-xaw/actions.c --- freeciv/client/gui-xaw/actions.c 2007-08-04

[Freeciv-Dev] (PR#39504) [Patch] Fix xaw compilation

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39504 > - 'xxx->index' seeks replaced by 'aaa_index(xxx)' - Changes made to gtk client in #38029 (revision 12881) copied almost verbatim Now it compiles. Asserts immediately when starting game. - ML diff -Nurd -X.diff_ignore freeciv/client/g

Re: [Freeciv-Dev] (PR#28301) [patch] add a common client option for theme selection

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=28301 > On 07/08/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > On 04/08/07, Christian Prochaska <[EMAIL PROTECTED]> wrote: > > > > Updated patches for the $client/$theme/$subtheme directory > > structure are attached. > > I updated these against

Re: [Freeciv-Dev] (PR#28301) [patch] add a common client option for theme selection

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=28301 > On 04/08/07, Christian Prochaska <[EMAIL PROTECTED]> wrote: > > Updated patches for the $client/$theme/$subtheme directory > structure are attached. I updated these against latest svn and added dummy popup_theme_suggestion_dialog() for othe

[Freeciv-Dev] (PR#39503) /cut and 'Unassigned' user name

2007-08-07 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39503 > When a user gets cut in a pregame, the next player user name is set to "Unassigned". --- server/stdinhand.c 2007-08-07 14:10:49.0 +0200 +++ server/stdinhand.c.new 2007-08-07 14:16:35.0 +0200 @@ -3750,6 +3750,7 @@ enum m_pr

Re: [Freeciv-Dev] (PR#39485) [Bug] Trunk asserts for barbarian nations from 2.1 or older saves

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39485 > On 04/08/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > S2_1 and earlier assigned same barbarian nation to both barbarian > players. When loading such savegame to trunk, it will assert due to > inconsistent nation assignments. Fix -

Re: [Freeciv-Dev] (PR#39414) tolua, tolua++, toluaxx

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39414 > On 24/06/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > Meanwhile, the existence of the external lua 5.1 prevents the included lua > from compiling, as the external header files are found first for gcc. > (Heavy sigh) Is this caus

[Freeciv-Dev] (PR#39502) Readline memory leaks

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39502 > Valgrind reports several memory blocks allocated by readline not freed. I don't know if we are using readline incorrectly, or if these are readline problems. I already sent email to readline developers. Even if it turns out to be readlin

Re: [Freeciv-Dev] pocket pc

2007-08-07 Thread Christian Prochaska
On 8/6/07, James Denny <[EMAIL PROTECTED]> wrote: > > Hi, I was wondering if there were any plans to bring freeciv to the pocket > pc? If not would it be do-able? I think it'd be fantastic if my addiction > was portable. Please respond. > > Thanks, James See http://freeciv.wikia.com/wiki/Instal

[Freeciv-Dev] (PR#39501) [Patch] SIGABRT handler

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39501 > This adds SIGABRT handler to server. This is useful in my (somewhat) automated testing environment. I have callback attached to freelog(). Now it can log notices about asserts too. Benefit for wider audience is that it know displays BUG_

[Freeciv-Dev] (PR#39500) [Patch] Fix aiferry_find_boat() memory leak

2007-08-07 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39500 > Found by valgrind. Applies to trunk, S2_1 and S2_0. Tested only in trunk (If *path is not initially sane value (such as NULL), this patch may lead to crash) - ML diff -Nurd -X.diff_ignore freeciv/ai/aiferry.c freeciv/ai/aiferry.c --- f