Re: [Freeciv-Dev] (PR#39459) Re: (PR#39713) [Gtk2-client] Client segfault on city build
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 On 18/09/2007, nikita bukhvostov wrote: On 17/09/2007, nikita bukhvostov wrote: OS: Linux Distr: Arch Client: Freeciv-beta 2.1.0-beta6 Client type: Gtk2 - 1. Run client 2. City build 3. Game segfault.. gcc version: 4.2.1 This is known problem with gcc-4.2. Our download page should mention it. You can try to compile with another version of gcc, or try to compile without optimization (I have not tested if compiling without optimization helps in Freeciv case) - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39717) [Bug] Inconsistent target_government special value
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39717 Sometimes when real government is not chosen, pplayer-target_government is government_when_anarchy, sometimes NULL. Most of the checks are against government_when_anarchy, so NULL is handled as real government, leading to segfault later. S2_1, S2_2, trunk. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39707) [Patch] Remove duplicate player-nation zeroing
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39707
On 14/09/2007, Marko Lindqvist wrote:
Seems that trunk already had proper player-nation zeroing before
S2_1 bugfix was ported.
To be committed to S2_2 and trunk.
- Fixed compiler warning
- ML
diff -Nurd -X.diff_ignore freeciv/client/packhand.c freeciv/client/packhand.c
--- freeciv/client/packhand.c 2007-09-14 14:52:09.0 +0300
+++ freeciv/client/packhand.c 2007-09-19 13:55:57.0 +0300
@@ -2190,8 +2190,6 @@
**/
void handle_ruleset_control(struct packet_ruleset_control *packet)
{
- int i;
-
ruleset_data_free();
ruleset_cache_init();
@@ -2226,12 +2224,6 @@
nations_alloc(game.control.nation_count);
city_styles_alloc(game.control.styles_count);
- /* We are in inconsistent state. Players point to nations,
- * which do not point to players. Fix */
- for (i = 0; i MAX_NUM_PLAYERS + MAX_NUM_BARBARIANS; i++) {
-game.players[i].nation = NULL;
- }
-
/* After nation ruleset free/alloc, nation-player pointers are NULL.
* We have to initialize player-nation too, to keep state consistent. */
players_iterate(pplayer) {
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39643) [Bug] Internal server exits silently for ruleset errors
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39643 On 15/09/2007, Marko Lindqvist wrote: On 31/08/2007, Marko Lindqvist wrote: S2_1 solution might be just to send chat message to all clients before final exit(). Here are patches to send that chat message. Not that user is likely to notice it. gtk -client goes back to main menu immediately when server dies closing chat -window. Maybe new kind of event - which has popups enabled by default - should be used for this. I'll leave improvements to future patches (and probably to trunk/S2_2 only). These I consider ready for commit. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fwd: Re: (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 We held some correspondence with Stefan about the crash. Here's what he says: -- Forwarded message -- On Wed, Sep 12, 2007 at 05:12:59PM +0200, Stefan Dirsch wrote: On Wed, Sep 12, 2007 at 06:01:59PM +0300, Elmo Todurov wrote: Whose fault it is, GCC, glib2/gtk2 or FreeCiv? And, most importantly, how to fix it? Honestly. I have no idea. I'm afraid we need a gcc expert here to compare the assembler output of -O1 and -O2. :-( [snip: Stefan asks someone] According to our gcc expert this is a undefinedness of signed overflow in freeciv, since -O2 --fno-tree-vrp fixes it as well. [he means here that compiling ONLY the wldlg.c with --fno-tree-vrp fixes it] ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Fwd: Re: (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 On 19/09/2007, Elmo Todurov wrote: We held some correspondence with Stefan about the crash. Here's what he says: -- Forwarded message -- On Wed, Sep 12, 2007 at 05:12:59PM +0200, Stefan Dirsch wrote: On Wed, Sep 12, 2007 at 06:01:59PM +0300, Elmo Todurov wrote: Whose fault it is, GCC, glib2/gtk2 or FreeCiv? And, most importantly, how to fix it? Honestly. I have no idea. I'm afraid we need a gcc expert here to compare the assembler output of -O1 and -O2. :-( [snip: Stefan asks someone] According to our gcc expert this is a undefinedness of signed overflow in freeciv, since -O2 --fno-tree-vrp fixes it as well. [he means here that compiling ONLY the wldlg.c with --fno-tree-vrp fixes it] I debugged problem down to GINT_TO_POINTER() At the time I believed this to be debian specific problem, so it's reported to debian bug tracker. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=440545 That bugreport contains example program. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#21244) France map for freeciv 2.x
URL: http://bugs.freeciv.org/Ticket/Display.html?id=21244 On 9/16/07, Mathieu Roy [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=21244 Hello, Trying the version of the map available from http://svn.gna.org/viewcvs/freeciv-maps/trunk/france/ Loading it on S2_0, S2_1, S2_2 all gives the same error: 1: The save file contains incomplete map data. This can happen with old saved games, or it may indicate an invalid saved game file. Proceed at your own risk. 1: Reason: line not found 1: secfile_lookup_line='secfile_lookup_str_default(file, NULL, map.f%03d, nat_y)' (...) I tried it on Freeciv version 2.0.9 gui-gtk-2.0 shipped by debian, there was no error message (or maybe I was in a mode without less debugging messages) Found the line where the error occurs: server/savegame.c line 837 (trunk) - LOAD_MAP_DATA(ch, nat_y, ptile, secfile_lookup_str_default(file, NULL, map.f%03d, nat_y), set_savegame_special(ptile-special, ch, default_specials + 12)); Couldn't figure out anything more from this. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
