Re: [Freeciv-Dev] (PR#39798) cheat using goto to explore
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39798 No. I've already explained your error, and there are explicit references. I've proposed a solution. I just haven't had time to write the code to fix the several reports. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39944) Realistic wonder terrain reqs
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39944 This patch gives terrain requirements to a few wonders that reflects their nature. Magellan and Lighthouse requires Ocean. They give modifiers to sea units and are semantically maritime in nature. Hoover requires mountains and river. This corresponds to the hydro plant reqs and is already in place in civ1 ruleset. Partially requested on the forums. Do we want this in 2.1? ~Daniel wonder_reqs.diff Description: Binary data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39941) gravship goto crashes
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39941 Jason Dorje Short wrote: Gravships (air units with 0 - unlimited - fuel) crash when goto is invoked. This has been reported in the past, but since there are no air units with zero fuel in the officially supported rulesets, it has not been a priority. Attached is a quick fix but there are other (seemingly non-fatal) bugs with this. For instance it always shows the turns-to-target as 0 for gravships. Please, no more quick fixes. Find all the issues, describe the range of solutions, and we'll discuss it here ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39941) gravship goto crashes
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39941 On Dec 2, 2007 10:37 PM, William Allen Simpson [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39941 Jason Dorje Short wrote: Gravships (air units with 0 - unlimited - fuel) crash when goto is invoked. This has been reported in the past, but since there are no air units with zero fuel in the officially supported rulesets, it has not been a priority. I'd just like to add that this has been reported by a forum user for his 'galactic ruleset' project, so the crash has been seen 'in the wild': http://forum.freeciv.org/viewtopic.php?t=4196 ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: No need to read the code, just ask anyone who plays multiplayer. The code itself is canonical. The quickselect is intended to pick a quick unit from the current stack to do a quick action. Wrong. The code comments explicitly say Focus unit is excluded. The code matches the comments [client/control.c line 2028]: if (game.player_ptr != unit_owner(punit) || unit_is_in_focus(punit)) { continue; } Perhaps that careless misunderstanding is how the code was so badly done (but doesn't explain how it was egregiously never tested before commit). The / and * keys duplicate the behavior of the RMB and LMB. This should be documented and those key commands added to the menu. And while we're at it we should pick keys that aren't so random. We should eliminate duplicate functions. They are confusing and cause extra work to document and maintain. Since this was broken (by you in PR#14365) circa Dec 2005, and has had only one report (Aug 2007) in two (2) years, it is clearly not a commonly used command. It has never worked. It was never documented. It is not in either xaw or sdl. Going, going, gone ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#30483) 2.1.0b2/Windows Mouse goto with Air units causes client crash
URL: http://bugs.freeciv.org/Ticket/Display.html?id=30483 A fine question. Perhaps you should haul out your win32 box and tell us? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#16811) Issue tracking system for Freeciv
URL: http://bugs.freeciv.org/Ticket/Display.html?id=16811 On Dec 2, 2007 1:11 AM, Jason Dorje Short [EMAIL PROTECTED] wrote: We have to ask to get clarity on this matter. Who was in contact the gna.org folks when we migrated to svn? Vasco? Jason? Vasco or Per. I do not recall doing that. In any case, all you need is to place a support request at https://gna.org/support/?group=admin - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Committed S2_1 revision 14112. Committed S2_2 revision 14113. Committed trunk revision 14114. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39943) 'more veteran' is broken english
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39943 Sadly, there is a lot of broken english throughout, so much that we discussed adding en_US.po (PR#39642). Fixing as folks find them Thanks! The newer branches are somewhat different. Used Promoted to, as soon we should have Promoted to Elite units, too. Committed trunk revision 14115. Committed S2_2 revision 14116. Committed S2_1 revision 14117. Index: po/pt_BR.po === --- po/pt_BR.po (revision 14116) +++ po/pt_BR.po (working copy) @@ -419,7 +419,8 @@ msgstr Unidade: Defensor Sobreviveu #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Unidade: Tornou-se Mais Experiente #: common/events.c:126 Index: po/es.po === --- po/es.po(revision 14116) +++ po/es.po(working copy) @@ -425,7 +425,8 @@ msgstr Unidad: Un defensor sobrevive #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Unidad: Se Volvió Más Veterana #: common/events.c:126 Index: po/ko.po === --- po/ko.po(revision 14116) +++ po/ko.po(working copy) @@ -417,7 +417,7 @@ msgstr #: common/events.c:125 -msgid Unit: Became More Veteran +msgid Unit: Promoted to Veteran msgstr #: common/events.c:126 Index: po/en_GB.po === --- po/en_GB.po (revision 14116) +++ po/en_GB.po (working copy) @@ -420,7 +420,7 @@ msgstr #: common/events.c:125 -msgid Unit: Became More Veteran +msgid Unit: Promoted to Veteran msgstr #: common/events.c:126 Index: po/ro.po === --- po/ro.po(revision 14116) +++ po/ro.po(working copy) @@ -420,7 +420,8 @@ msgstr Unitate: ApÄrÄtorul a supravieÅ£uit #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Unitate: A devenit mai experimentatÄ #: common/events.c:126 Index: po/fr.po === --- po/fr.po(revision 14116) +++ po/fr.po(working copy) @@ -425,7 +425,8 @@ msgstr Unité : survie du défenseur #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Unité : gagne un niveau de vétéran #: common/events.c:126 Index: po/et.po === --- po/et.po(revision 14116) +++ po/et.po(working copy) @@ -421,7 +421,8 @@ msgstr Ãksus: Kaitsja pidas vastu #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Ãksus: Sai kogenumaks #: common/events.c:126 Index: po/ca.po === --- po/ca.po(revision 14116) +++ po/ca.po(working copy) @@ -421,7 +421,8 @@ msgstr Unitat: Defensor sobreviu #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Unitat: Guanya Veterania #: common/events.c:126 Index: po/pt.po === --- po/pt.po(revision 14116) +++ po/pt.po(working copy) @@ -428,7 +428,7 @@ msgstr Unidade: Defensora Sobreviveu #: common/events.c:125 -msgid Unit: Became More Veteran +msgid Unit: Promoted to Veteran msgstr #: common/events.c:126 Index: po/da.po === --- po/da.po(revision 14116) +++ po/da.po(working copy) @@ -429,7 +429,8 @@ msgstr Enhed: Forsvarer overlevede #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Enhed: Fik mere erfaring #: common/events.c:126 Index: po/tr.po === --- po/tr.po(revision 14116) +++ po/tr.po(working copy) @@ -423,7 +423,8 @@ msgstr Birim: Savunma Hayatta Kaldı #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Birim: Kıdemi Arttı #: common/events.c:126 Index: po/fa.po === --- po/fa.po(revision 14116) +++ po/fa.po(working copy) @@ -420,7 +420,8 @@ msgstr Ù ÙرÙ: ٠داÙع زÙد٠٠اÙد #: common/events.c:125 -msgid Unit: Became More Veteran +#, fuzzy +msgid Unit: Promoted to Veteran msgstr Ù ÙرÙ: کارآز٠ÙدÙâتر شد #: common/events.c:126 Index: po/sv.po === --- po/sv.po(revision 14116) +++ po/sv.po(working copy) @@ -452,7 +452,8 @@ msgstr Enhet: Försvarare överlevde #: common/events.c:125 -msgid Unit: Became More Veteran +#,
Re: [Freeciv-Dev] (PR#39941) gravship goto crashes
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39941 William Allen Simpson wrote: Attached is a quick fix but there are other (seemingly non-fatal) bugs with this. For instance it always shows the turns-to-target as 0 for gravships. Please, no more quick fixes. Find all the issues, describe the range of solutions, and we'll discuss it here As I said, the problem is that fuel=0 is special-cased for air units. Similarly non-air-units, which normally have fuel=0 also, get the fuel set to 1 to make this special-casing work. The full fix then would be to leave fuel at 0 for non-air units. The special case, then, would not be on fuel=0 but rather on fuel0. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39942) Settler outline not tileset defined
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39942 Daniel Markstedt wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39942 Tested on 2.1.1 win32-gtk2: The red outline around the settler is not defined in the tileset. Especially notable with the mono monochrome tileset, where it is the only thing in color... Unless I've overlooked something that is. Using this tileset: ftp://ftp.freeciv.org/pub/freeciv/contrib/tilesets/mono/mono-2.1-1.tar.gz It's the worked sprite, the same one it shows you around tiles that have citizens working on them when the whole grid is up. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 [jdorje - Dim. Déc. 02 01:59:36 2007]: Your last patch looks like it does what it says it does. And I agree the current code is broken (modifying a unit list inside the list iterator is a no-no, that's what iterate_safe is for, but even with iterate_safe the behavior is broken as it just selected different units repeatedly). What I question is why you'd want the behavior to be that way when there are multiple units selected. Say I have 5 units on 5 different tiles selected...what use would be a quickselect that gives me 5 different land units, one per tile? I thought the purpose of quickselect was to give just ONE unit for quick action in multiplayer games. In that context I would think the key_quickselect action should just pick one unit on one tile to bring into focus. The question then becomes (when the battlegroup spans multiple tiles), which tile to choose. I'm no expect on multiplayer freeciv but I'd think the tile nearest the center of the screen would be the most likely to be the one the player wants. -jason I thought about it a long time. I think the last issue I found was the more practical/nearer than the current way... ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: Since this was broken (by you in PR#14365) circa Dec 2005, and has had only one report (Aug 2007) in two (2) years, it is clearly not a commonly used command. It has never worked. It was never documented. It is not in either xaw or sdl. Going, going, gone Um, no. First of all, deleting features from the stable branch is not something that should be done lightly. Nor should you, in general, delete things from any branch without the chance for discussion. Secondly, there was discussion, which you ignored. If we were to continue the discussion, it would go something like this: the bug was reported shortly after 2.1 was released and has since been a continual complaint on the forums (I'm told); therefore it clearly IS a command that is used. Also, it makes no technical sense to delete an existing keyboard command that duplicates a mouse command. We still have exactly the same problem we had before but without the keyboard shortcut for it. Instead we should fix the commands so that they don't have two separate backend implementations, and fix them to work properly. Please rethink your unreasonable position. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: Also, it makes no technical sense to delete an existing keyboard command that duplicates a mouse command. We still have exactly the same problem we had before but without the keyboard shortcut for it. Instead we should fix the commands so that they don't have two separate backend implementations, and fix them to work properly. Presumably, the mouse command actually works (at least the code is much longer). I didn't find a bug report for it. So, no, we don't have exactly the same problem. Please re-read the code. And tell us where the mouse command is documented?!?!? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 On 12/3/07, Jason Dorje Short [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: Since this was broken (by you in PR#14365) circa Dec 2005, and has had only one report (Aug 2007) in two (2) years, it is clearly not a commonly used command. It has never worked. It was never documented. It is not in either xaw or sdl. Going, going, gone Um, no. First of all, deleting features from the stable branch is not something that should be done lightly. Nor should you, in general, delete things from any branch without the chance for discussion. [...] I agree that this was done in too hasty a fashion. William, if you wanted this code gone so badly, you could at least have presented some kind of roadmap for reimplementation. To hear the opinion of the gaming commuity, I started a poll at: http://forum.freeciv.org/viewtopic.php?t=4218 ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: Also, it makes no technical sense to delete an existing keyboard command that duplicates a mouse command. We still have exactly the same problem we had before but without the keyboard shortcut for it. Instead we should fix the commands so that they don't have two separate backend implementations, and fix them to work properly. Presumably, the mouse command actually works (at least the code is much longer). I didn't find a bug report for it. So, no, we don't have exactly the same problem. Please re-read the code. The crash problem having been easily solved, the remaining problem becomes what to do when multiple units are selected. And tell us where the mouse command is documented?!?!? Excellent point. I suspect a thorough review of all commands and their documentation would be in order. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev