Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40075 Michael Kaufman wrote: On Mon, Feb 04, 2008 at 07:49:58PM -0800, Jason Dorje Short wrote: ... Why not just use the ptile-index as the city id? ... ... without knowing the tile location that the city sits on (the capital city?)

Re: [Freeciv-Dev] (PR#40082) string coding error in script.lua

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40082 Christian Knoke wrote on Feb 05, 06:00 (-0800): Patch attached. Forget it. It doesn't work. Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum.

[Freeciv-Dev] (PR#40082) string coding error in script.lua

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40082 Christian Knoke wrote on Jan 31, 11:52 (+0100): Jason Dorje Short wrote on Jan 30, 19:36 (-0500): On Jan 29, 2008 9:11 PM, William Allen Simpson [EMAIL PROTECTED] wrote: Christian Knoke wrote: #: data/default/script.lua:30

Re: [Freeciv-Dev] (PR#40080) [tracking] replace city id with tile pointer or index

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40080 William Allen Simpson wrote: There are at least 148 *city-id references in 44 files (and untold others with other pointer names). This is a seriously daunting task! The agents.c code passes city ids around. 284 references to

[Freeciv-Dev] (PR#40080) replace city id with tile pointer or index

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40080 [wsimpson - Tue Feb 05 13:29:46 2008]: I've found a serious overflow bug already. The ids are unsigned short, the range is 65536 numbers, but ai/aidata.c allocates all players arrays with: /* max size of a short */ #define

Re: [Freeciv-Dev] (PR#40082) string coding error in script.lua

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40082 The easy fix is just to shorten this to one line. This doesn't solve the problem that xgettext doesn't properly know how to extract translatable strings from lua code, nor from embedded lua code (as in the tutorial scenario). -jason

[Freeciv-Dev] (PR#40084) identity_number, server.game_identifier, city_tile(), unit_tile()

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40084 Some of the preliminary steps toward the PR#40080 long-term goal. This patch mostly clears the decks for shorter-term crashing bug fixes. It includes some code already in 2.1 (PR#39980), used for initializing the game_identifier.

Re: [Freeciv-Dev] (PR#40084) identity_number, server.game_identifier, city_tile(), unit_tile()

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40084 Forgot to mention that it fixes the bug already reported in PR#40080, increasing the ai-stats.diplomat_reservations bit vector from 32767 (wrong) to 65536. Better not to overflow, even as a better solution may be developed in the