Re: [Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 Madeline Book wrote: I mean a server setting (in server/settings.c) like savepalace or killcitizen, I don't see why this should be for things (?) that change only from ruleset to ruleset Neither should be server

[Freeciv-Dev] (PR#40111) Diplomatic immunity

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40111 Madeline Book wrote: Spies and diplomats do not have the Partial_Invis flag. This is a bug. These units should not show up until adjacent to cities, and should be completely invisible to passing units.

[Freeciv-Dev] (PR#40112) air units and submarines affecting city workers

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40112 Madeline Book wrote: for stealth fighters/bombers, consider that submarines can in fact be detected by their effect on city workers when their controlling player is foolish enough to move them into the field of the enemy city

[Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 [wsimpson - Sun Feb 24 12:51:14 2008]: Madeline Book wrote: I mean a server setting (in server/settings.c) like savepalace or killcitizen, I don't see why this should be for things (?) that change only from

[Freeciv-Dev] (PR#40111) Diplomatic immunity

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40111 [wsimpson - Sun Feb 24 12:55:07 2008]: Madeline Book wrote: Spies and diplomats do not have the Partial_Invis flag. This is a bug. These units should not show up until adjacent to cities, and should be completely invisible to

[Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 [wsimpson - Mon Feb 25 01:11:20 2008]: Since Madeline's testing revealed no bugs in the code execution, I never tested the code (indeed looking back at my posts I never said so implicitly or explicitly), I merely commented on your

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 After updating my working tree with latest S2_2 branch (r14422) I get an assertion failure in the client when trying to start a new game. Steps to reproduce: 1. Start a server in one console (e.g. run ./ser). 2. Start a client in

[Freeciv-Dev] (PR#40114) vestigial city_map removal from client/agents/cma_core.c

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40114 This is the last substantive use on the client side. For unknown reasons, it parallels code in common/aicore/cm.c -- which is called and over-writes the calculations! The only advantage is this code has some debug counting and logging;

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Cannot duplicate, running client with internal server. Tried random nation button (my usual test), random nation button on nation dialog, and picking specific nation. All work. ___

[Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 [wsimpson - Mon Feb 25 03:15:06 2008]: Madeline Book wrote: I never tested the code WTF! The whole purpose of posting patches for comments is that the patches are actively tested! Unfortunately for you, posting a comment

Re: [Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 Madeline Book wrote: Unfortunately for you, posting a comment about a side-effect of your patch does not imply that the person posting the comment tested your patch. But never fear, there is PR#40113. Unfortunately for all of us,

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [book - Mon Feb 25 02:47:42 2008]: I will see if I cannot fix this (kind of hard to work on the editor if I cannot start a game ;)). So here is a quick patch that addresses the underlying cause as I understand it at the moment.

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [wsimpson - Mon Feb 25 03:22:41 2008]: Cannot duplicate, running client with internal server. Tried random nation button (my usual test), random nation button on nation dialog, and picking specific nation. All work. I did say to

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 This appears to be wrong. This might set client.playing for an observer, which would violate quite a bit of existing logic. It should not be possible for an observer to pick a nation. Is that what you tried? (You didn't mention that

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 I have examined all instances of send_conn_info(), and with one exception, they seem to come after send_player_info() -- which is how client.playing is set. Please post the exact commands that you send. And have you tested with any

Re: [Freeciv-Dev] (PR#40111) Diplomatic immunity

2008-02-24 Thread Per I. Mathisen
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40111 On Sun, Feb 24, 2008 at 6:46 PM, Madeline Book [EMAIL PROTECTED] wrote: This is a bug. These units should not show up until adjacent to cities, and should be completely invisible to passing units. It is not a bug. Also, making