[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-07 Thread David Lowe
Follow-up Comment #22, patch #1330 (project freeciv): I'm not sure if i'm using the correct terminology, but in the GTK city dialog there is a line of 'tabs' along the bottom: Overview, Production, Happiness, Governor, and Settings. I guess what i call tabs is more properly called pages? In

[Freeciv-Dev] [bug #15345] Help: document new features illness and migration

2010-04-07 Thread Matthias Pfafferodt
Follow-up Comment #2, bug #15345 (project freeciv): Thank for the patch! I'm not a native speaker but the text looks OK and I did not found any errors in the content. ___ Reply to this item at: http://gna.org/bugs/?15345

[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-07 Thread Matthias Pfafferodt
Follow-up Comment #23, patch #1330 (project freeciv): I'm not sure that the trade tooltip justifies an own page. It would be an nearly empty page. The only thing that would be better is if the main 'Civilization' menu had a new item which could display how many trade routes belong to each

[Freeciv-Dev] [patch #1584] Add video mode option type

2010-04-07 Thread pepeto
Update of patch #1584 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #1: Committed at

[Freeciv-Dev] [patch #1589] struct city cleanup

2010-04-07 Thread pepeto
Follow-up Comment #12, patch #1589 (project freeciv): It compiles fine now. ___ Reply to this item at: http://gna.org/patch/?1589 ___ Message posté via/par Gna! http://gna.org/

[Freeciv-Dev] [bug #15807] assert in player_invention_state() [tech.c::129]

2010-04-07 Thread Matthias Pfafferodt
Follow-up Comment #2, bug #15807 (project freeciv): I did use the current trunk and the experimental ruleset (patch #1236; activates tech upkeep). After I start the server and the client building a city results in the error message ___

[Freeciv-Dev] [patch #1574] add a player to a running game

2010-04-07 Thread Ulrik Sverdrup
Follow-up Comment #3, patch #1574 (project freeciv): Nice, the code looks pretty simple actually. I find the same map inconsistency when reviving a player (creating a new player in a dead player's slot). Looking at the map editor, it seems the server thinks the player can see the whole map,

[Freeciv-Dev] [patch #1598] sanitize city AI control

2010-04-07 Thread Matthias Pfafferodt
of the current player to initialize the city's AI values ___ File Attachments: --- Date: Mittwoch 07.04.2010 um 23:27 Name: 20100407-01-trunk-sanitize-city-AI-control.diff Size: 2kB

[Freeciv-Dev] [bug #15810] Sanity check should use fc_assert()

2010-04-07 Thread pepeto
Update of bug #15810 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.3.0

[Freeciv-Dev] [bug #15816] add a comment about a needed empty line in the nation.ruleset file

2010-04-07 Thread pepeto
Follow-up Comment #1, bug #15816 (project freeciv): I don't agree that this should be solved with adding some comment about an empty line. I don't understand why an empty line is needed. The best way to solve the problem is probably to not need an empty line at the end of this file

[Freeciv-Dev] [patch #1574] add a player to a running game

2010-04-07 Thread Matthias Pfafferodt
Follow-up Comment #4, patch #1574 (project freeciv): updated patch; the players knowledge about the map is cleared; no errors anymore and it is working! about the lua code: * no gold (additional functions needed as you said in patch #1494) * the newcomer() function can be called multiple times

[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2010-04-07 Thread Jacob Nevins
Follow-up Comment #24, patch #1330 (project freeciv): I'm not sure that the trade tooltip justifies an own page. It would be an nearly empty page. Indeed, the S2_0 branch had such a tab, and it was (nearly empty). The only thing that would be better is if the main 'Civilization' menu had a

[Freeciv-Dev] [patch #1599] Scripting: Limit execution time

2010-04-07 Thread Ulrik Sverdrup
URL: http://gna.org/patch/?1599 Summary: Scripting: Limit execution time Project: Freeciv Submitted by: englabenny Submitted on: torsdag 2010-04-08 den 00:53 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1599] Scripting: Limit execution time

2010-04-07 Thread Ulrik Sverdrup
Follow-up Comment #1, patch #1599 (project freeciv): I forgot this remark: This is not a security feature. It is reportedly possible to construct infinite loops using C library calls, and those won't be caugth (the instructions counter does not advance).

[Freeciv-Dev] [bug #15816] add a comment about a needed empty line in the nation.ruleset file

2010-04-07 Thread Jason Dorje Short
Follow-up Comment #3, bug #15816 (project freeciv): If an empty line is required there should be a comment in the file. I see the patch but isn't the empty line above the comment, making the comment actually wrong? And which versions (1.14 and on) does this apply to? Secondly, it does sound