[Freeciv-Dev] [bug #15890] Typo in settings.c
Follow-up Comment #4, bug #15890 (project freeciv): Maybe Jacob could handle this item? ___ Reply to this item at: http://gna.org/bugs/?15890 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15890] Typo in settings.c
Update of bug #15890 (project freeciv): Assigned to:None = jtn ___ Follow-up Comment #5: Happy to. I've not jumped on it as I said on -i18n that we'd keep po-files stable during the string freeze. Assuming I do the same thing I've been doing for other cosmetic changes, of changing the msgids in all the po-files so as to avoid introducing fuzzies, probably the time to do it is a little before the next release. (I'm a native speaker but I don't have a strong intuition about the is/are thing, so I'd probably go with the formally correct version.) ___ Reply to this item at: http://gna.org/bugs/?15890 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15890] Typo in settings.c
Update of bug #15890 (project freeciv): Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15890 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15744] Various minor bugs with pillaging (mostly of bases)
Update of bug #15744 (project freeciv): Summary: Various bugs with pillaging of bases = Various minor bugs with pillaging (mostly of bases) ___ Reply to this item at: http://gna.org/bugs/?15744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15744] Various minor bugs with pillaging (mostly of bases)
Follow-up Comment #3, bug #15744 (project freeciv): Most of the bugs to do with savegames / simultaneous pillaging probably don't show up much in practice because pillaging takes a single turn. An exception is if you order an exhausted unit to pillage; this can demonstrate the fifth point. ___ Reply to this item at: http://gna.org/bugs/?15744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15744] Various minor bugs with pillaging (mostly of bases)
Update of bug #15744 (project freeciv): Category:None = general Status:None = Ready For Test Planned Release: = 2.2.1 ___ Follow-up Comment #4: Patch attached for S2_2 and trunk: * In running server and new savegames, ACTIVITY_PILLAGE/S_LAST/BASE_NONE is now an invalid combination. Units are always pillaging a specific target. * However, on ingress (from client and old savegames), this combination is now a request for the server to assign a specific pillage target. ** The client now makes use of this in rulesets without pillage_select, fixing bug #15742. ** (But the server still copes with clients requesting a specific target -- it'll be rejected if it's not the one the server would have chosen.) * Rationalise and combine lots of pillaging code on this basis. Fix a few already-noted inconsistencies as a result. * Handle bases as first-class entities, the same as specials. (This fixes various other bugs.) * Rationalise loading of activities in general from savegames (shouldn't affect anything other than pillaging). * Actually save the base that's being pillaged when saving games. * Centralise logic of which targets can be pillaged in can_unit_do_activity_targeted_at() (used on client and server). (This does cope with untargeted pillaging.) ** Move prevention of attempts to pillage prerequisites (e.g., road on a tile with railroad) out of individual clients into the above. ** Use can_unit_do_activity_targeted_at() to derive the pillage popup list in the server. * Tenuously related: simplify display of infrastructure text in clients (less code, same effect). * Tenuously related: remove some unused variables from the SDL client. (file #9058, file #9059) ___ Additional Item Attachment: File name: S2_2-pillaging-fixes.diff Size:27 KB File name: trunk-pillaging-fixes.diff Size:27 KB ___ Reply to this item at: http://gna.org/bugs/?15744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15742] Client offers pillage select menu even with pillage_select=0 in ruleset
Update of bug #15742 (project freeciv): Status:None = Ready For Test Planned Release: = 2.2.1 ___ Follow-up Comment #2: Patches which fix this are attached to bug #15744. ___ Reply to this item at: http://gna.org/bugs/?15742 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1637] Implement 'enum' server setting type
Update of patch #1637 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #1: Patch attached. Not including compresstype, killcitizen and airliftstyle that need their own tickets... (file #9062) ___ Additional Item Attachment: File name: trunk_setting_enum.diff.bz2Size:9 KB ___ Reply to this item at: http://gna.org/patch/?1637 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15944] Global observer only see unavailable tiles
URL: http://gna.org/bugs/?15944 Summary: Global observer only see unavailable tiles Project: Freeciv Submitted by: pepeto Submitted on: samedi 24.04.2010 à 20:30 Category: client Severity: 2 - Minor Priority: 3 - Low Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_2 Discussion Lock: Any Operating System: None Planned Release: ___ Details: In the city dialog, it seems that all tiles are marked unavailable when you are global observer. My expectation: see what tiles are usable for the city I clicked on. ___ Reply to this item at: http://gna.org/bugs/?15944 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15944] Global observer only see unavailable tiles
Follow-up Comment #1, bug #15944 (project freeciv): See also bug #15411. ___ Reply to this item at: http://gna.org/bugs/?15944 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15946] in city_map_radius_sq_get() [city.c::128]: assertion 'pcity != ((void *)0)' failed
URL:
http://gna.org/bugs/?15946
Summary: in city_map_radius_sq_get() [city.c::128]:
assertion 'pcity != ((void *)0)' failed
Project: Freeciv
Submitted by: pepeto
Submitted on: samedi 24.04.2010 à 23:08
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: trunk
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
It happens when I was clicking the worked tiles on a investigation city
dialog (on server side).
#0 0x777d405b in raise (sig=value optimized out)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
No locals.
#1 0x0055097f in fc_assert_fail (file=0x5c9d05 city.c,
function=0x5cc580 city_map_radius_sq_get, line=128,
assertion=value optimized out, message=0x0) at log.c:452
level = LOG_FATAL
#2 0x004b3326 in city_map_radius_sq_get (pcity=value optimized
out)
at city.c:128
__FUNCTION__ = city_map_radius_sq_get
#3 0x004b0d95 in handle_city_make_specialist (
pplayer=value optimized out, city_id=128, worker_x=4, worker_y=3)
at cityhand.c:137
ptile = value optimized out
pcenter = value optimized out
pcity = 0x0
city_radius_sq = value optimized out
__FUNCTION__ = handle_city_make_specialist
#4 0x0045f1cd in server_handle_packet (type=value optimized out,
packet=value optimized out, pplayer=0x662f737463656a6f, pconn=0x0)
at hand_gen.c:69
No locals.
#5 0x00409913 in server_packet_input (pconn=0x89ee60, packet=0x192a,
type=37) at srv_main.c:1428
pplayer = 0x9591b0
__FUNCTION__ = server_packet_input
#6 0x004929c2 in incoming_client_packets () at sernet.c:406
command_ok = value optimized out
packet = {data = 0x1207110, type = PACKET_CITY_MAKE_SPECIALIST}
#7 server_sniff_all_input () at sernet.c:758
pconn = 0x89ee60
max_desc = value optimized out
readfs = {fds_bits = {128, 0 repeats 15 times}}
writefs = {fds_bits = {0 repeats 16 times}}
exceptfs = {fds_bits = {0 repeats 16 times}}
tv = {tv_sec = 0, tv_usec = 322195}
__FUNCTION__ = server_sniff_all_input
#8 0x0040aead in srv_running () at srv_main.c:2072
eot_timer = 0xcd4570
save_counter = 1
is_new_turn = true
need_send_pending_events = false
__FUNCTION__ = srv_running
#9 0x0040bbff in srv_main () at srv_main.c:2454
__FUNCTION__ = srv_main
#10 0x00403eb5 in main (argc=value optimized out,
argv=0x7fffe1c8) at civserver.c:376
inx = 3
showhelp = false
showvers = false
option = 0x0
__FUNCTION__ = main
___
Reply to this item at:
http://gna.org/bugs/?15946
___
Message posté via/par Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15946] in city_map_radius_sq_get() [city.c::128]: assertion 'pcity != ((void *)0)' failed
Update of bug #15946 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.3.0 ___ Follow-up Comment #1: Double fix attached: * On client side, don't try to toggle the city workers on non-owned cities. * On server side, move city_map_radius_sq_get() after the check for the NULL city pointer. (file #9064) ___ Additional Item Attachment: File name: trunk_fix_city_make_specialist_assert.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15946 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
