[Freeciv-Dev] [bug #16958] no messages for diplomat combat when in allied city

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #6, bug #16958 (project freeciv): Sorry for late comment, but I think some of the arguments to the new messages may be wrong? You are right; Thanks for catching this! ___ Reply to this item at:

[Freeciv-Dev] [patch #2221] help text for city radius and build slots

2010-11-20 Thread Matthias Pfafferodt
: ___ File Attachments: --- Date: Samstag 20.11.2010 um 10:30 Name: 20101120-trunk-help-text-for-city-radius-and-build-slots.patch Size: 2kB By: syntron http://gna.org/patch

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #17110 (project freeciv): The size for the next city image are hardcoded (see for example ./data/amplio/moderncities.spec): 2, 0, city.electricage_city_0 2, 1, city.electricage_city_4 2, 2, city.electricage_city_8 2, 3, city.electricage_city_12 2, 4,

[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #16639 (project freeciv): I had to modify your setup to run the game. Is this correct? The reason is that I can't start the game if I connect as global observer (error message: no enough human players). 1)Load savegame in stand-alone server 2)Start client and

[Freeciv-Dev] [patch #1893] [metaticket] Help updates for 2.3.0

2010-11-20 Thread pepeto
Update of patch #1893 (project freeciv): Depends on: = patch #2221 ___ Reply to this item at: http://gna.org/patch/?1893 ___ Message

[Freeciv-Dev] [bug #16964] Mfg. Plant + electrical plant bonus does not match Help

2010-11-20 Thread pepeto
Follow-up Comment #2, bug #16964 (project freeciv): I vote for point 2. ___ Reply to this item at: http://gna.org/bugs/?16964 ___ Message posté via/par Gna! http://gna.org/

[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #8, bug #16639 (project freeciv): 2.1) connect to Rudolf (as user1) 2.2) aitoggle Rudolf 2.3) disconnect 2.4) connect as global observer (as user2) Figured it out - simple type '/observe' in the chat and '/aitoggle r' ... Still no error (fourth game to turn 600+)

[Freeciv-Dev] [patch #2167] [ai header] gotohand.c

2010-11-20 Thread Matthias Pfafferodt
Update of patch #2167 (project freeciv): Status: Ready For Test = Invalid Assigned to:None = syntron Open/Closed:Open = Closed

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

2010-11-20 Thread pepeto
Update of bug #17110 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Message posté

[Freeciv-Dev] [patch #2221] help text for city radius and build slots

2010-11-20 Thread pepeto
Update of patch #2221 (project freeciv): Assigned to:None = jtn ___ Reply to this item at: http://gna.org/patch/?2221 ___ Message

[Freeciv-Dev] [patch #2222] Name cleanup for the unit test functions

2010-11-20 Thread pepeto
URL: http://gna.org/patch/? Summary: Name cleanup for the unit test functions Project: Freeciv Submitted by: pepeto Submitted on: samedi 20.11.2010 à 13:26 Category: client-gtk-2.0 Priority: 5 -

[Freeciv-Dev] [patch #2222] Name cleanup for the unit test functions

2010-11-20 Thread pepeto
Update of patch # (project freeciv): Category: client-gtk-2.0 = general ___ Reply to this item at: http://gna.org/patch/? ___ Message

[Freeciv-Dev] [bug #17102] settler units lose red border and cannot build cities

2010-11-20 Thread pepeto
Update of bug #17102 (project freeciv): Category: client = general Status:None = Ready For Test ___ Follow-up Comment #6: Fix attached, but

[Freeciv-Dev] [bug #17102] settler units lose red border and cannot build cities

2010-11-20 Thread pepeto
Update of bug #17102 (project freeciv): Depends on: = patch # ___ Reply to this item at: http://gna.org/bugs/?17102 ___ Message posté

[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map

2010-11-20 Thread pepeto
Follow-up Comment #1, patch #2218 (project freeciv): Note the _struct tile_data_cache_ pointers are never free-d. You should define _SPECHASH_DATA_FREE_ to _tile_data_cache_destroy()_. ___ Reply to this item at:

[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map

2010-11-20 Thread pepeto
Follow-up Comment #2, patch #2218 (project freeciv): Reading again you should also defined _SPECHASH_DATA_COPY_ to _tile_data_cache_copy()_ to auto duplicate the element when needed. ___ Reply to this item at:

[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology

2010-11-20 Thread Jacob Nevins
Update of bug #16971 (project freeciv): Status: Need Info = In Progress Assigned to:None = jtn ___ Follow-up Comment #5: Convert it is,

[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology

2010-11-20 Thread pepeto
Follow-up Comment #6, bug #16971 (project freeciv): I don't. ___ Reply to this item at: http://gna.org/bugs/?16971 ___ Message posté via/par Gna! http://gna.org/

[Freeciv-Dev] [bug #17109] Map grid color should be white only when option City Outlines is on.

2010-11-20 Thread pepeto
Update of bug #17109 (project freeciv): Category: client-gtk-2.0 = client ___ Follow-up Comment #1: Actually, it also print in red the worked tiles. I doubt this should be related to City

[Freeciv-Dev] [bug #17109] Map grid color should be white only when option City Outlines is on.

2010-11-20 Thread pepeto
Update of bug #17109 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?17109 ___ Message posté

[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology

2010-11-20 Thread Jacob Nevins
Follow-up Comment #7, bug #16971 (project freeciv): Here is the almost-minimal patch that fixes the strings only, but doesn't rename the concept internally. Also fixed a couple of bugs: * One string was not marked as translatable. * In GTK client, the menu item was never greyed out for units

[Freeciv-Dev] [bug #17105] Global warming ineffective?

2010-11-20 Thread pepeto
Update of bug #17105 (project freeciv): Category:None = rulesets ___ Follow-up Comment #4: Attached a patch which make more terrain transformations. (file #11291)

[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client

2010-11-20 Thread Jacob Nevins
URL: http://gna.org/bugs/?17112 Summary: Add unit convert order to SDL client Project: Freeciv Submitted by: jtn Submitted on: Saturday 11/20/10 at 15:34 Category: client-sdl Severity: 3 - Normal

[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client

2010-11-20 Thread Jacob Nevins
Additional Item Attachment, bug #17112 (project freeciv): File name: trunk-sdl-unit-convert.diffSize:2 KB ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by

[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client

2010-11-20 Thread Jacob Nevins
Update of bug #17112 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent

[Freeciv-Dev] [task #7231] S2_3 translatable string freeze

2010-11-20 Thread Jacob Nevins
Update of task #7231 (project freeciv): Depends on: = bugs #17112 ___ Reply to this item at: http://gna.org/task/?7231 ___ Message sent

[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client

2010-11-20 Thread Jacob Nevins
URL: http://gna.org/bugs/?17113 Summary: Add unit convert order to Xaw client Project: Freeciv Submitted by: jtn Submitted on: Saturday 11/20/10 at 15:55 Category: client-xaw Severity: 1 - Wish

[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client

2010-11-20 Thread Jacob Nevins
Additional Item Attachment, bug #17113 (project freeciv): File name: trunk-xaw-unit-convert.diffSize:3 KB ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent via/by

[Freeciv-Dev] [task #7231] S2_3 translatable string freeze

2010-11-20 Thread Jacob Nevins
Update of task #7231 (project freeciv): Depends on: = bugs #17113 ___ Reply to this item at: http://gna.org/task/?7231 ___ Message sent

[Freeciv-Dev] [bug #17091] cleanup saving old savegame format

2010-11-20 Thread Matthias Pfafferodt
Update of bug #17091 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #9, bug #16639 (project freeciv): sorry; I can't reproduce the assert. Could you run freeciv with the option -F and send a backtrace? ___ Reply to this item at: http://gna.org/bugs/?16639

[Freeciv-Dev] [bug #16971] Rename 'transform' to 'convert' for units, and add help

2010-11-20 Thread Jacob Nevins
Update of bug #16971 (project freeciv): Status: In Progress = Ready For Test Summary: Resolve 'transform' (terrain) vs 'transform' (units) terminology = Rename 'transform' to 'convert' for units, and add help

[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client

2010-11-20 Thread Jacob Nevins
Additional Item Attachment, bug #17112 (project freeciv): File name: trunk-sdl-unit-convert-bis.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent

[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client

2010-11-20 Thread Jacob Nevins
Additional Item Attachment, bug #17113 (project freeciv): File name: trunk-xaw-unit-convert-bis.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent

[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client

2010-11-20 Thread Jacob Nevins
Update of bug #17113 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent

[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client

2010-11-20 Thread Jacob Nevins
Update of bug #17112 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent

[Freeciv-Dev] [patch #2217] [autosettler] dynamically allocate citymap in struct cityresult

2010-11-20 Thread Matthias Pfafferodt
into the tile data cache (file #11297) ___ Additional Item Attachment: File name: 20101120-07-trunk-autosettler-dynamically-allocate-citymap-in-struct-c.patch Size:13 KB ___ Reply

[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #2218 (project freeciv): I did rewrote the entire patch. Now also the tile data in the city result is saved using a hash. tile_data_hash_copy() and tile_data_hash_destroy() are defined and used. changes 20101120: * use spechash.h for settler map and cityresult

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

2010-11-20 Thread Matthias Pfafferodt
) ___ Additional Item Attachment: File name: 20101120-trunk-configure-the-city-images-via-the-effects-system.patch Size:42 KB ___ Reply to this item at: http://gna.org/bugs/?17110

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

2010-11-20 Thread Goswin von Brederlow
Follow-up Comment #3, bug #17110 (project freeciv): You could simply change the number at the end of the description tag (city.electricage_city_4 = city.electricage_city_3). The city radius, except for the first step, is changed by other things than just size so this won't work. But I see you

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

2010-11-20 Thread Matthias Pfafferodt
Follow-up Comment #4, bug #17110 (project freeciv): With images being an rffect it makes no sense to limit the number of image by the size of a city. They are really independent. That's right - but a limit is needed. And I don't think that there will be much more images than the current 4

[Freeciv-Dev] [bug #17105] Global warming ineffective?

2010-11-20 Thread Daniel Markstedt
Update of bug #17105 (project freeciv): Status:None = Ready For Test Assigned to:None = dmarks Planned Release: = 2.3.0

[Freeciv-Dev] [patch #2180] Polish ruleset update

2010-11-20 Thread Daniel Markstedt
Update of patch #2180 (project freeciv): Status: Need Info = Ready For Test Assigned to:None = dmarks Planned Release: = 2.3.0, 2.4.0

[Freeciv-Dev] [patch #2221] help text for city radius and build slots

2010-11-20 Thread Jacob Nevins
Follow-up Comment #1, patch #2221 (project freeciv): Thanks for the explanation. I've mucked around with this a fair bit: * Moved inline to the relevant sections of the existing help; * Added description of interaction of build slots with worklists (since this was fairly carefully designed in

[Freeciv-Dev] [patch #2221] help text for city radius and build slots

2010-11-20 Thread Jacob Nevins
Follow-up Comment #2, patch #2221 (project freeciv): (that should be Warriors (134/[5*10]) or Settlers (134/{1*40}) , hopefully. And I meant braces, not angle brackets. But apart from that...) ___ Reply to this item at:

[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate

2010-11-20 Thread Jacob Nevins
URL: http://gna.org/patch/?2223 Summary: Display destination type of unit upgrade in menu, and grey out menu entry as appropriate Project: Freeciv Submitted by: jtn Submitted on: Sunday 11/21/10 at 01:09 Category:

[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate

2010-11-20 Thread Jacob Nevins
Update of patch #2223 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/patch/?2223 ___ Message sent

[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate

2010-11-20 Thread Jacob Nevins
Additional Item Attachment, patch #2223 (project freeciv): File name: trunk-gtk-upgrade-menu.diffSize:4 KB ___ Reply to this item at: http://gna.org/patch/?2223 ___ Message sent

[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map

2010-11-20 Thread pepeto
Follow-up Comment #4, patch #2218 (project freeciv): There are still losses of memory. When calling _tile_data_cache_hash_replace(key, data)_, then data will be duplicated inside (because _SPECHASH_DATA_COPY_ has been defined). So you need to free the pointer after that. So, there are 2

[Freeciv-Dev] [bug #17116] Citizens roles become unrecognisable in large cities

2010-11-20 Thread Goswin von Brederlow
URL: http://gna.org/bugs/?17116 Summary: Citizens roles become unrecognisable in large cities Project: Freeciv Submitted by: mrvn Submitted on: Sunday 11/21/2010 at 01:49 Category: client-gtk-2.0

[Freeciv-Dev] [patch #2224] Help system entry for nation legends

2010-11-20 Thread Daniel Markstedt
URL: http://gna.org/patch/?2224 Summary: Help system entry for nation legends Project: Freeciv Submitted by: dmarks Submitted on: Sunday 11/21/2010 at 11:50 Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #2224] Help system entry for nation legends

2010-11-20 Thread Daniel Markstedt
Update of patch #2224 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: First try to getting patch up to date. It seems that the interface to look up a nation has