[Freeciv-Dev] [bug #18843] The setting 'trading_city' can't be modified after the game has started.
URL: http://gna.org/bugs/?18843 Summary: The setting 'trading_city' can't be modified after the game has started. Project: Freeciv Submitted by: akfaew Submitted on: Mon Oct 24 12:21:08 2011 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2.3 Discussion Lock: Any Operating System: None Planned Release: ___ Details: set trading_city disabled The setting 'trading_city' can't be modified after the game has started. Why not? I think only settings that are difficult/impossible to change after /start should have this limitation. ___ Reply to this item at: http://gna.org/bugs/?18843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18776] /remove perhaps faulty
Follow-up Comment #5, bug #18776 (project freeciv): Did anyone have a chance to look at this bug? ___ Reply to this item at: http://gna.org/bugs/?18776 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client
Follow-up Comment #16, patch #2715 (project freeciv): Is there any real bugs remaining in current version? I would fix only those in this ticket, and to leave any improvements to future tickets. It would be nice to get cairo based drawing to gtk3-client in 2.4 already, and S2_4 branching 2-Nov is just a bit over week away. I tried to apply latest version of the patch to TRUNK gtk3-client but there was a lot of conflicts. Can you fix that? I see you have submitted your versions as Anonymous. Do you want to be credited that way, or by some other name? ___ Reply to this item at: http://gna.org/patch/?2715 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] compile issues
For the first time in some time, I have time for freeciv work. But on compiling, --enable-debug=checks (--enable-debug=yes in older branches) doesn't compile in trunk or in most branches anymore. One issue does seem to be in the GTK header files, both not under our control and commented in the headers as being deprecated in C99 but needed for backwards compatibility. That particular check (-W flag given to gcc) will have to be removed for it to compile. Another common issue is a seemingly new catch by the compiler of unused variables that are set but never used. Many of these are accidental but some happen in iterate loops where a variable is provided but not used within the loop. For this I propose a macro to mark the variable as unused, which will tell both the compiler and the reader what's going on. My first task will be making up a patch for this, which IMO should be taken care of before the branching. If there's anything else I should look at though let me know. I'm on irc (#freeciv-dev on irc.freenode.org) if anyone wants to discuss in realtime. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] compile issues
On 24 October 2011 22:20, Jason Dorje Short jdo...@gmail.com wrote: For the first time in some time, I have time for freeciv work. But on compiling, --enable-debug=checks (--enable-debug=yes in older branches) doesn't compile in trunk or in most branches anymore. One issue does seem to be in the GTK header files, both not under our control and commented in the headers as being deprecated in C99 but needed for backwards compatibility. That particular check (-W flag given to gcc) will have to be removed for it to compile. What distribution are you using? Are you using distribution's versions of both gcc and gtk+ (one would assume that those are compatible with each other)? I have no such problems with Debian Wheezy; gcc 4.6.1, gtk2 2.24.6 Another common issue is a seemingly new catch by the compiler of unused variables that are set but never used. Many of these are accidental but some happen in iterate loops where a variable is provided but not used within the loop. For this I propose a macro to mark the variable as unused, which will tell both the compiler and the reader what's going on. These are new with gcc 4.6. I have fixed most of them, and have patches for many of the remaining ones. Your macro is probably required for the remaining ones. See bug #18217 - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2883] [lua116] lua function to save a game (as 'manual' save)
Update of patch #2883 (project freeciv):
Status:Done = In Progress
Open/Closed: Closed = Open
___
Follow-up Comment #5:
Checked - the lua script calls the default save function. Thus, it would be
possible to add a directory to the path. The attached patch does limit the
possible chars for the filename if using the lua server.save function. Is
there a simpler way or even a function in the freeciv code which could be
reused?
lua cmd if (server.save('test')) then log.normal('OK') else log.normal('not
saved') end
Game saved as test.sav.bz2
OK
lua cmd if (server.save('/tmp/test')) then log.normal('OK') else
log.normal('not saved') end
not saved
(file #14243)
___
Additional Item Attachment:
File name: 0034-restrict-possible-file-name-for-lua-server.save-func.patch
Size:2 KB
___
Reply to this item at:
http://gna.org/patch/?2883
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18844] fix crash if closing the client without starting a game
URL: http://gna.org/bugs/?18844 Summary: fix crash if closing the client without starting a game Project: Freeciv Submitted by: syntron Submitted on: Mo 24 Okt 2011 22:58:49 CEST Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: None Originator Email: Open/Closed: Open Release: svn20306 Discussion Lock: Any Operating System: None Planned Release: 2.4.0 ___ Details: the luaconsole was never created - thus pdialog-shell is NULL and trying to destroy it will crash the client. A similar patch will be needed for gtk3. ___ File Attachments: --- Date: Mo 24 Okt 2011 22:58:49 CEST Name: 0036-fix-crash-if-closing-the-client-without-starting-a-g.patch Size: 1kB By: syntron http://gna.org/bugs/download.php?file_id=14244 ___ Reply to this item at: http://gna.org/bugs/?18844 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18776] /remove perhaps faulty
Follow-up Comment #6, bug #18776 (project freeciv): untested possible patch (not even compile tested) ... could you test it with your savegame? (first check if it still crashs - then test with a patched version of the server) (file #14245) ___ Additional Item Attachment: File name: 0001-fix-bug-in-player_map_free.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18776 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18842] gtk3-client does not compile if not building also gtk2-client
Follow-up Comment #2, bug #18842 (project freeciv): This was due to a mistake in patch #2873. Coincidentally I posted a patch there fixing this and other issues; had I realised it would cause a Gtk3 build failure, I'd have committed it. ___ Reply to this item at: http://gna.org/bugs/?18842 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2873] [lua108] client lua script console (gtk3)
Follow-up Comment #5, patch #2873 (project freeciv): See also bug #18842. ___ Reply to this item at: http://gna.org/patch/?2873 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] compile issues
On 24 Oct, 2011, at 1:33 PM, Marko Lindqvist wrote:
On 24 October 2011 22:20, Jason Dorje Short jdo...@gmail.com wrote:
For the first time in some time, I have time for freeciv work. But on
compiling, --enable-debug=checks (--enable-debug=yes in older
branches) doesn't compile in trunk or in most branches anymore.
One issue does seem to be in the GTK header files, both not under our
control and commented in the headers as being deprecated in C99 but
needed for backwards compatibility. That particular check (-W flag
given to gcc) will have to be removed for it to compile.
What distribution are you using? Are you using distribution's
versions of both gcc and gtk+ (one would assume that those are
compatible with each other)? I have no such problems with Debian
Wheezy; gcc 4.6.1, gtk2 2.24.6
Another common issue is a seemingly new catch by the compiler of
unused variables that are set but never used. Many of these are
accidental but some happen in iterate loops where a variable is
provided but not used within the loop. For this I propose a macro to
mark the variable as unused, which will tell both the compiler and the
reader what's going on.
These are new with gcc 4.6. I have fixed most of them, and have
patches for many of the remaining ones. Your macro is probably
required for the remaining ones.
See bug #18217
Yeah, i need to file some bugs in this area too. Compilation fails
when using clang [which is now default on OSX 10.7/XCode 4.2]:
/bin/sh ../libtool --preserve-dup-deps --silent --tag=CC --mode=compile
gcc -DHAVE_CONFIG_H -I. -I.. -I/sw/include
-DLOCALEDIR=\/sw/share/locale\ -DBINDIR=\/sw/bin\
-DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/sw/share/freeciv\
-DDEFAULT_SAVES_PATH=\\
-DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/2.3/scenarios:~/.freeciv/scenarios:/sw/share/freeciv/scenario\
-Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes
-Wmissing-declarations -Wno-unused-but-set-variable -Werror -g -O2
-fsigned-char -c -o shared.lo shared.c
shared.c:370:36: error: comparison of unsigned expression = 0 is always
true [-Werror,-Wtautological-compare]
while (mantissa != 0 exponent = 0) {
^ ~
/bin/sh ../libtool --preserve-dup-deps --silent --tag=CC --mode=compile
gcc -DHAVE_CONFIG_H -I. -I.. -I/sw/include
-DLOCALEDIR=\/sw/share/locale\ -DBINDIR=\/sw/bin\
-DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/sw/share/freeciv\
-DDEFAULT_SAVES_PATH=\\
-DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/2.3/scenarios:~/.freeciv/scenarios:/sw/share/freeciv/scenario\
-Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes
-Wmissing-declarations -Wno-unused-but-set-variable -Werror -g -O2
-fsigned-char -c -o md5.lo md5.c
md5.c:148:5: error: cast from 'const unsigned char *' to 'MD5_u32plus *'
(aka 'unsigned int *') increases required alignment from 1 to 4
[-Werror,-Wcast-align]
STEP(F, a, b, c, d, SET(0), 0xd76aa478, 7)
^~
In the meantime i've set my package to use llvm, but enable-debug is
problematic. A user reported that it fails later with warnings registry.c.
I don't have a specific error message, but will see what i can dig up.
Sent from my MacBookPro
Drink your coffee! There are poor people in India sleeping.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
