[Freeciv-Dev] [bug #19009] gtk3-client does not show what city is building
Follow-up Comment #1, bug #19009 (project freeciv): I suspect it has something to do with theming - I've been toying with gtk3 brand of theming and while I did get decent results on some of the widgets, for some reason I couldn't get i.e. entries and buttons working. On a semi-related note: I should really seriously think about creating an account here, if I keep commenting on stuff. ___ Reply to this item at: http://gna.org/bugs/?19009 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #18776] /remove perhaps faulty
On 15 November 2011 16:39, Michal Mazurek no-reply.invalid-addr...@gna.org wrote: This part is really perplexing: +verbose+ 2782 known[l * MAP_INDEX_SIZE + tile_index(ptile)] 2783 |= (1u (p - l * 8)); -verbose- Suppose there is a player with index 60. p = 60, l = 1. (p - l * 8) = (60 - 8) = 52. 1 52 bits is more than an int can handle. Comment above says that this is HACK so it's even known not to be very clean implementation... I think someone has mixed number of bits and hex values at some point. While we read 8 hex values to known[], here we handle it as bits already, so that 8 should be 32 (p is always 0 to 31 bigger than l*32) - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Moving Longturn patches to Lua
On Wed, Nov 16, 2011 at 10:38:15PM +0100, Matthias Pfafferodt wrote: Am Mittwoch, 16. November 2011, 19:47:45 schrieb Michal Mazurek: On Tue, Nov 15, 2011 at 09:48:07PM +0100, Matthias Pfafferodt wrote: The hardest part is the transmission of the veteran ruleset definitions (IMHO). Speaking of veterans, while looking at freecivs png files i noticed there are four more veteran levels graphics. Did freeciv use to have 8 veteran levels? Freeciv 2.3 supports up to 10 veteran levels but only 4 are used; in 2.4 this will be increased to 20 levels which can be different for different units. See the experimental ruleset for an example (settlers). This is great! Here are the values I think I'll use for LTeX: veteran_names = _(green), _(veteran 1), _(veteran 2), _(veteran 3), _(hardened 1), _(hardened 2), _(hardened 3), _(elite 1 ), _(elite 2), _(elite 3) veteran_raise_chance = 50, 45, 40, 35, 30, 25, 20, 15, 10, 0 veteran_power_fact = 100, 150, 175, 200, 225, 250, 275, 300, 325, 350 veteran_work_raise_chance = 12, 9, 9, 9, 7, 7, 7, 5, 5, 5 veteran_move_bonus = 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 -- Michal Mazurek ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19012] bumb event cache size
URL: http://gna.org/bugs/?19012 Summary: bumb event cache size Project: Freeciv Submitted by: akfaew Submitted on: Thu Nov 17 15:54:25 2011 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Bump GAME_MAX_EVENT_CACHE_TURNS to 20, and set default to 5. Also bump GAME_MAX_EVENT_CACHE_MAX_SIZE to 5000. From discussion in bug #18742. ___ File Attachments: --- Date: Thu Nov 17 15:54:25 2011 Name: ecache.diff Size: 835B By: akfaew http://gna.org/bugs/download.php?file_id=14567 ___ Reply to this item at: http://gna.org/bugs/?19012 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3050] Do not ditribute unusable gtk3-client theme
Update of patch #3050 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3050 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3044] Get nation specific trait value directly from nation
Update of patch #3044 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3044 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19001] Client crash when planning goto for immobile unit
Update of bug #19001 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19001 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3054] Tile road functions
Update of patch #3054 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3054 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3048] tai: Request queue from player thread to main thread
Update of patch #3048 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3048 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)
Update of bug #18835 (project freeciv): Severity:1 - Wish = 3 - Normal Planned Release: 2.4.0, 2.3.2? = 2.4.0, 2.3.2 ___ Follow-up Comment #41: updated patch files: - part 1: file #14294 - part 2: file #14295 - part 3: new file (from this comment; includes file #14548 and file #14549; additional some code cleanup) Can these patches be applied to gtk3 or do they use some function which is not defined in gtk3 or depreciated? I will try to get gtk3 but do not know if I will be succesfull (file #14569) ___ Additional Item Attachment: File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch Size:21 KB ___ Reply to this item at: http://gna.org/bugs/?18835 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2978] AI diplomats stack next to an enemy city
Update of patch #2978 (project freeciv): Planned Release: = 2.3.2,2.4.0,2.5.0 Summary: AI diplomats doesn't dodge enemy units and stack next to an enemy city = AI diplomats stack next to an enemy city ___ Follow-up Comment #4: updated patch; doging of enemy units can be found in bug #19014 (file #14572) ___ Additional Item Attachment: File name: 0013-AI-diplomats-stack-next-to-an-enemy-city.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?2978 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19014] AI diplomats doesn't dodge enemy units
Follow-up Comment #1, bug #19014 (project freeciv): patch by Jordi Negrevernis i Font jorneg (see patch #2978) ___ Reply to this item at: http://gna.org/bugs/?19014 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)
Follow-up Comment #42, bug #18835 (project freeciv): Can these patches be applied to gtk3 I would have tested if it compiles, but patch doesn't even apply to (S2_4) gtk3-client. ___ Reply to this item at: http://gna.org/bugs/?18835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19015] tile_init() doesn't initialize bases vector
URL: http://gna.org/bugs/?19015 Summary: tile_init() doesn't initialize bases vector Project: Freeciv Submitted by: cazfi Submitted on: Fri 18 Nov 2011 12:31:13 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.8, 2.3.2, 2.4.0, 2.5.0 ___ Details: Fix attached ___ File Attachments: --- Date: Fri 18 Nov 2011 12:31:13 AM EET Name: InitTileBases.diff Size: 437B By: cazfi http://gna.org/bugs/download.php?file_id=14573 ___ Reply to this item at: http://gna.org/bugs/?19015 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19008] Compiler flag legality checking ignores existing flags
Update of bug #19008 (project freeciv): Planned Release: 2.2.8, 2.3.1, 2.4.0, 2.5.0 = 2.2.8, 2.3.2, 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?19008 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18776] /remove perhaps faulty
Follow-up Comment #26, bug #18776 (project freeciv): by Marko Lindqvist: I think someone has mixed number of bits and hex values at some point. While we read 8 hex values to known[], here we handle it as bits already, so that 8 should be 32 (p is always 0 to 31 bigger than l*32) I think that was me ... updated patch with fixed numbers attached. I do hope this one fixes all bugs due to removed players and also saves the known information correctly. It changes the information in a savegame file. Please test! (file #14574) ___ Additional Item Attachment: File name: 0011-fix-known-map-in-savegame2.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?18776 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)
Follow-up Comment #43, bug #18835 (project freeciv): version for gtk3 (it does apply; not compile tested) - only patch 1 had to be changed (gtk2 = gtk3 in strings) (file #14575, file #14576, file #14577) ___ Additional Item Attachment: File name: 0001-gtk2-add-option-to-gui_dialog_new-to-skip-check-of-p.patch Size:9 KB File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch Size:21 KB File name: 0002-gtk2-diplomacy-in-a-horizontal-notebook.patch Size:10 KB ___ Reply to this item at: http://gna.org/bugs/?18835 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19004] Messages generated at LOG_NORMAL when using optional network capabilities
Update of bug #19004 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19004 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19009] gtk3-client does not show what city is building
Follow-up Comment #2, bug #19009 (project freeciv): I think I won't have much time for this topic, but I'm attaching what I've already done. This is under the assumption, that old theme is still installed for gtk-3.0 client (that is, with r20580 reverted). gtk.css goes into the same place gtkrc is. As I mentioned, only parts of it work - mostly bg.png related part. I didn't work on scrollbars yet (I'd like to remind you about bug #18607 again) and while I've tried to make buttons/entries work, I couldn't make it for the moment. (file #14578) ___ Additional Item Attachment: File name: css-theme.tar.xz Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?19009 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19016] unit dialog spits out assertions with cimpletoon tilespec
URL: http://gna.org/bugs/?19016 Summary: unit dialog spits out assertions with cimpletoon tilespec Project: Freeciv Submitted by: None Submitted on: Fri 18 Nov 2011 02:01:59 AM UTC Category: rulesets Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: galtge...@o2.pl Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: 1: in fill_unit_type_sprite_array() [tilespec.c::3347]: assertion 't-sprites.units.icon[uidx] != NULL' failed. It's because of lack of unoriented units in this tileset - the effect is the lack of unit icons for groups of units; individual unit icons are obviously unaffected. ___ Reply to this item at: http://gna.org/bugs/?19016 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18776] /remove perhaps faulty
Follow-up Comment #27, bug #18776 (project freeciv): p = player_index(pplayer); l = player_index(pplayer) / 32; (p - l * 32) Can't we just use modulo here? Won't this break existing save games? If i saved using the '8' code, I cannot load using the '32' code. Well, at least if i have a player index 31. Then again, the save game is botched anyway, player 32 overwrites player 24. ___ Reply to this item at: http://gna.org/bugs/?18776 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18776] /remove perhaps faulty
Follow-up Comment #28, bug #18776 (project freeciv): What does this code save anyway? Map tiles without fog of war? Can't this be recreated after /load? ___ Reply to this item at: http://gna.org/bugs/?18776 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
