[Freeciv-Dev] [bug #18767] cma: always 1 tax collector

2012-02-02 Thread Pekka Pessi
Follow-up Comment #11, bug #18767 (project freeciv):

...the second patch in file #14947 is correct one. I have a feeling that
Savane does not like me. *;-)

___

Reply to this item at:

  http://gna.org/bugs/?18767

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19397] Hardcoded lua include path in tolua-5.1/src/lib

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19397

 Summary: Hardcoded lua include path in tolua-5.1/src/lib
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 02 Feb 2012 08:03:22 PM EET
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.8, 2.3.2, 2.4.0, 2.5.0

___

Details:

Lua include path in dependencies/tolua-5.1/src/lib/Makefile.am is hardcoded to
included lua-5.1. Headers from included lua are used even when one is supposed
to build against external lua.

This is real bug in freeciv S2_4 and TRUNK (as building against external lua
is possible), and in modified version of Debian from earlier branches.

Fix attached



___

File Attachments:


---
Date: Thu 02 Feb 2012 08:03:22 PM EET  Name: ToluaLuaCFLAGS.diff  Size: 499B  
By: cazfi

http://gna.org/bugs/download.php?file_id=14969

___

Reply to this item at:

  http://gna.org/bugs/?19397

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3101] Add missing lua-5.2 source files to Makefile.am

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3101

 Summary: Add missing lua-5.2 source files to Makefile.am
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 02 Feb 2012 08:20:31 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch adds lua-5.2 source files missing from Makefile.am to it.



___

File Attachments:


---
Date: Thu 02 Feb 2012 08:20:31 PM EET  Name: MissingLuaFiles.diff  Size: 424B 
 By: cazfi

http://gna.org/patch/download.php?file_id=14970

___

Reply to this item at:

  http://gna.org/patch/?3101

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3103] Registry module init

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3103

 Summary: Registry module init
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 02 Feb 2012 08:32:15 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch adds for-now-empty functions registry_module_init() and
registry_module_close() and calls to them in appropriate places.



___

File Attachments:


---
Date: Thu 02 Feb 2012 08:32:15 PM EET  Name: RegModInit.diff  Size: 5kB   By:
cazfi

http://gna.org/patch/download.php?file_id=14972

___

Reply to this item at:

  http://gna.org/patch/?3103

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19356] Tutorial code fails to check city tile

2012-02-02 Thread Marko Lindqvist
Update of bug #19356 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19356

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1339] Unit type requirements

2012-02-02 Thread J. M. Gorbach
Follow-up Comment #10, patch #1339 (project freeciv):

Update new file diff.

I'm at a standstill.

(file #14973)
___

Additional Item Attachment:

File name: trunk_requirement_vector-02-2012.zip Size:27 KB


___

Reply to this item at:

  http://gna.org/patch/?1339

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3094] Remove gui-ftwl from version control

2012-02-02 Thread Marko Lindqvist
Update of patch #3094 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3094

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3104] Expansionist AI trait

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3104

 Summary: Expansionist AI trait
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 02 Feb 2012 11:13:12 PM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch adds expansionist trait. Thanks to patch #2310 for idea what
parts of code this should touch (on a related note I've tried to implement
most of the traits from that patch, but all others are appeared to have
negligible (=not worth added complexity) effect when testing with autogames)



___

File Attachments:


---
Date: Thu 02 Feb 2012 11:13:12 PM EET  Name: TraitExpansionist.diff  Size: 4kB
  By: cazfi

http://gna.org/patch/download.php?file_id=14974

___

Reply to this item at:

  http://gna.org/patch/?3104

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3105

 Summary: Road type as pillage target
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 03 Feb 2012 02:49:22 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch adds most of the support for having ATT_ROAD as target type for
pillage. Since savegame format does not yet allow saving such pillage actions,
this is not yet used. Roads are still pillaged as specials. Magic to switch
between pillaging roads as specials and road types is in
get_preferred_pillage(). Now it returns roads as specials.



___

File Attachments:


---
Date: Fri 03 Feb 2012 02:49:22 AM EET  Name: PillageRoad.diff.bz2  Size: 7kB  
By: cazfi

http://gna.org/patch/download.php?file_id=14975

___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Freeciv forum?

2012-02-02 Thread Piotr
Hello!
I cannot find any forum about Freeciv. It seems that there is only
this site @ wikia that I find counter-intuitive to navigate. Can you
help me out by providing some links?
Thanks!

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken

2012-02-02 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19398

 Summary: Packet creation overflow checks broken
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Feb  3 02:33:21 2012
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.2.7,2.3.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.2,2.4.0,2.5.0

___

Details:

As pointed out in bug #19241, enough_space() in dataio.c has a bogus check for
packet overflow when creating a packet which will never fire.

The attached patch fixes this and also adds an assertion to most packet
transmissions that too_short isn't set, to help diagnose bugs like bug #19241
in future.




___

Reply to this item at:

  http://gna.org/bugs/?19398

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19399] Assertion failure when game ends

2012-02-02 Thread Jacob Nevins
Update of bug #19399 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-S2_3-xaw-endgame-assertion.diff Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?19399

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken

2012-02-02 Thread Jacob Nevins
Update of bug #19398 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?19398

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19241] Server crash when game ends with 100 players

2012-02-02 Thread Jacob Nevins
Follow-up Comment #5, bug #19241 (project freeciv):

The Xaw client is not working brilliantly well for me at the moment, but this
patch seems to work OK.

In S2_3 version of patch, gui-stub does not compile. Fixed version attached.

(Trunk/S2_4 patch doesn't apply cleanly to S2_4, but I imagine it's easy
enough to reconcile.)

 The dataio.c has buffer length checks that should prevent the 
 crash and simply result in truncated packet. However, there is 
 another bug [...]
Raised separately as bug #19398.

(file #14978)
___

Additional Item Attachment:

File name: SplitEndgameReport_19241-S2_3-stubfix.diff Size:19 KB


___

Reply to this item at:

  http://gna.org/bugs/?19241

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev