[Freeciv-Dev] [patch #3449] Nation sets: initial cut-down implementation for 2.4.x

2012-07-27 Thread Jacob Nevins
Update of patch #3449 (project freeciv):

  Status:None = In Progress


___

Reply to this item at:

  http://gna.org/patch/?3449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3450] Base flag (bit) to draw owner flag (gfx)

2012-07-27 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3450

 Summary: Base flag (bit) to draw owner flag (gfx)
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 27 Jul 2012 03:28:51 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add base flag ShowFlag that controls whether base owner's flag is drawn on
screen or not.



___

File Attachments:


---
Date: Fri 27 Jul 2012 03:28:51 PM EEST  Name: BaseOwnerFlag.patch  Size: 8kB  
By: cazfi

http://gna.org/patch/download.php?file_id=16208

___

Reply to this item at:

  http://gna.org/patch/?3450

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-27 Thread mir3x
Follow-up Comment #2, patch #3434 (project freeciv):

Ok, updated.

( meanwhile I found some bugs in qt science report, I'll patch it soon)

(file #16209)
___

Additional Item Attachment:

File name: QtRevol.patch  Size:9 KB


___

Reply to this item at:

  http://gna.org/patch/?3434

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-27 Thread Marko Lindqvist
Update of patch #3434 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = cazfi  
 Planned Release: = 2.5.0  


___

Reply to this item at:

  http://gna.org/patch/?3434

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3316] Celtic nation

2012-07-27 Thread Andrzej M. Gorzym
Follow-up Comment #3, patch #3316 (project freeciv):

Probably it my final fixes, so can add.

(file #16210)
___

Additional Item Attachment:

File name: celtic.ruleset Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?3316

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed

2012-07-27 Thread mir3x
URL:
  http://gna.org/bugs/?19989

 Summary: client assertion unit_list_size(ptile-units) failed
 Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 27 Jul 2012 06:51:11 PM CEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

( It's related to all clients, not Qt, I checked with gtk2 )

it repeatable. Save game attached.

failed assertion:
in handle_tile_info() [../../client/packhand.c::2670]: assertion '0 ==
unit_list_size(ptile-units)' failed.

2: 0: ./client/freeciv-gtk2() [0x5d02a8]
2: 1: ./client/freeciv-gtk2(vdo_log+0x88) [0x5d5018]
2: 2: ./client/freeciv-gtk2(do_log+0x7d) [0x5d50cd]
2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x9f) [0x5d52ff]
2: 4: ./client/freeciv-gtk2(handle_tile_info+0x8fd) [0x4a25bd]
2: 5: ./client/freeciv-gtk2(client_handle_packet+0x611) [0x4a6c21]

debug=4 shows before -

4: client_remove_city() 172, Trondheim
4: game_remove_city() at (24,27) city 172, Holy Roman Trondheim
4: (24,27) creating city 172, Burgundian Trondheim
4: A: agents_city_changed(city 172=Trondheim) owner=Burgundian
3: got packet type=(PACKET_TILE_INFO)15 len=11 from server
4: incoming packet={type=15, size=11}
3: packet_tile_info_100: got info about (2051)
3:   got field 'known'
4: remove_packet_from_buffer: remove 11; remaining 756
0x9597980 220 Warriors at (23,26) Henri le Grand

in handle_tile_info() [../../client/packhand.c::2670]: assertion '0 ==
unit_list_size(ptile-units)' failed.

after that everything goes ok:
4: A: agents_tile_remove(tile=(23, 26))
3: got packet type=(PACKET_UNIT_SHORT_INFO)64 len=20 from server
4: incoming packet={type=64, size=20}





___

Reply to this item at:

  http://gna.org/bugs/?19989

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed

2012-07-27 Thread mir3x
Follow-up Comment #1, bug #19989 (project freeciv):

forgot to attach sav

(file #16213)
___

Additional Item Attachment:

File name: unit_list_size_assert_failed.sav.bz2 Size:24 KB


___

Reply to this item at:

  http://gna.org/bugs/?19989

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3440] Correct gfx tag for Alien World Burrow Tube

2012-07-27 Thread Marko Lindqvist
Update of patch #3440 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3440

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3451] New Civilization - Faroese

2012-07-27 Thread anonymous
URL:
  http://gna.org/patch/?3451

 Summary: New Civilization - Faroese
 Project: Freeciv
Submitted by: None
Submitted on: Fri 27 Jul 2012 07:02:40 PM UTC
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: wi...@vandals.uidaho.edu
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Enclosed please find a ruleset for the Faroese civilization, based in the
Faroe Islands. The .svg is drawn by Anonymous for openclipart.org.



___

File Attachments:


---
Date: Fri 27 Jul 2012 07:02:41 PM UTC  Name: faroese.ruleset  Size: 2kB   By:
None

http://gna.org/patch/download.php?file_id=16215
---
Date: Fri 27 Jul 2012 07:02:40 PM UTC  Name: faroe.svg  Size: 3kB   By: None

http://gna.org/patch/download.php?file_id=16214

___

Reply to this item at:

  http://gna.org/patch/?3451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3451] New Civilization - Faroese

2012-07-27 Thread Jacob Nevins
Follow-up Comment #1, patch #3451 (project freeciv):

There's already a faroese.ruleset, added in patch #2621, but not yet released
-- it's scheduled for 2.4.0.
Is this intended as a replacement, or had you just not spotted that version?

See it here:
* faroese.ruleset
http://svn.gna.org/viewcvs/freeciv/trunk/data/nation/faroese.ruleset?view=markup
* faroes.svg
http://svn.gna.org/viewcvs/*checkout*/freeciv/trunk/data/flags/faroes.svg

___

Reply to this item at:

  http://gna.org/patch/?3451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3452] Qt science report small fix

2012-07-27 Thread mir3x
URL:
  http://gna.org/patch/?3452

 Summary: Qt science report small fix
 Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 27 Jul 2012 10:20:24 PM CEST
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Added handling A_UNSET tech and sorting techs by name in comboboxes.



___

File Attachments:


---
Date: Fri 27 Jul 2012 10:20:24 PM CEST  Name: QtSciUpdate.patch  Size: 3kB  
By: mir3x

http://gna.org/patch/download.php?file_id=16216

___

Reply to this item at:

  http://gna.org/patch/?3452

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17864] Map generation retry leads to map created with rivers (and huts) over ocean

2012-07-27 Thread Marko Lindqvist
Update of bug #17864 (project freeciv):

  Status:   Confirmed = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17864

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19979] Map generation retried with new random seed even when seed set

2012-07-27 Thread Marko Lindqvist
Update of bug #19979 (project freeciv):

  Status:  Ready For Test = Duplicate  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19979

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3193] Make tech loss more fair

2012-07-27 Thread Marko Lindqvist
Update of patch #3193 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3193

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19990] Civil war should try to avoid conflicts_with nations

2012-07-27 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19990

 Summary: Civil war should try to avoid conflicts_with nations
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Jul 27 22:46:38 2012
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:

Currently, when picking a civil war nation, no attempt is made to avoid
nations which conflict with a nation in the game -- ignore_conflicts is set in
pick_a_nation().

This means that the game can end up with nations with gratuitously clashing
flags (e.g. Scottish and Scottish Gaelic).

It would be better if it at least tried to avoid conflicting nations first,
and only used them if unavoidable.

This patch unsets ignore_conflicts in this case (split_player()), and in
addition, changes pick_a_nation so that if it falls back to conflicting
nations, it revisits any supplied choice list. So in descending order of
preference we pick:
* a non-conflicting nation from the civilwar list
* a random non-conflicting nation
* a conflicting nation from the civilwar list
* a random conflicting nation

(This change in behaviour of pick_a_nation() can't affect anything else, as it
only makes a difference when a choice list is supplied, which only happens in
civil war, which can't ever reach this bit of code before this patch.)



___

File Attachments:


---
Date: Fri Jul 27 22:46:38 2012  Name:
trunk-S2_4-S2_3-civilwar-avoid-conflicts.patch  Size: 3kB   By: jtn

http://gna.org/bugs/download.php?file_id=16217

___

Reply to this item at:

  http://gna.org/bugs/?19990

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3451] New Civilization - Faroese

2012-07-27 Thread anonymous
Follow-up Comment #2, patch #3451 (project freeciv):

Just didn't see that version, sorry.

___

Reply to this item at:

  http://gna.org/patch/?3451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19990] Civil war should try to avoid conflicts_with nations

2012-07-27 Thread Jacob Nevins
Follow-up Comment #1, bug #19990 (project freeciv):

Hm, perhaps this goes against nation designers' wishes. From arab.ruleset:


; Should not appear with other Arabic nations from the beginning but...
conflicts_with=Iraqi, Libyan, Sudanese, Syrian, Egyptian Arab,
 Moroccan, Tunisian, Algerian, Andalusi, Saudi, Palestinian,
 Yemeni, South Yemeni, Lebanese, Emirati, Jordanian, Omani,
 Sahrawi, Mauritanian, Kuwaiti, Qatari, Bahraini, Mamluk,
 Cyrenaican
; ...civil war to them.
civilwar_nations=Iraqi, Libyan, Sudanese, Syrian, Egyptian Arab,
 Moroccan, Tunisian, Algerian, Andalusi, Saudi, Palestinian,
 Yemeni, Lebanese, Emirati, Jordanian, Omani, Sahrawi,
 Mauritanian, Kuwaiti, Qatari, Bahraini


___

Reply to this item at:

  http://gna.org/bugs/?19990

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19946] Déjà vu unit movement animation in client

2012-07-27 Thread David Fernandez
Follow-up Comment #1, bug #19946 (project freeciv):

I have also seen it for long time, I hope someone can fix it.

___

Reply to this item at:

  http://gna.org/bugs/?19946

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19991] mali.ruleset conflicts_with itself

2012-07-27 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19991

 Summary: mali.ruleset conflicts_with itself
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jul 28 03:02:08 2012
Category: rulesets
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:


conflicts_with=Mali ;similar shield


I'm not sure which nation it was intended to conflict with. The most similar
shield I see is the Spanish one, but it's still distinct due to the device.

No clues when this came in in bug #16787.

I think this is harmless.

Not found any other similar instances.




___

Reply to this item at:

  http://gna.org/bugs/?19991

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19992] When loading rulesets, warn about nations whose conflicts_with/civilwar lists contain themselves

2012-07-27 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19992

 Summary: When loading rulesets, warn about nations whose
conflicts_with/civilwar lists contain themselves
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jul 28 03:03:47 2012
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

Following on from bug #19991, it would be useful to ruleset authors to warn if
a nation's civilwar or conflicts lists contains itself, because that never
makes sense.




___

Reply to this item at:

  http://gna.org/bugs/?19992

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19992] When loading rulesets, warn about nations whose conflicts_with/civilwar lists contain themselves

2012-07-27 Thread Jacob Nevins
Update of bug #19992 (project freeciv):

  Status: In Progress = Ready For Test 
  Depends on: = bugs #19991

___

Additional Item Attachment:

File name: trunk-S2_4-nations-warn-self-conflict.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19992

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3449] Nation sets: initial cut-down implementation for 2.4.x

2012-07-27 Thread Jacob Nevins
Update of patch #3449 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Proposed patch attached.
Example of use attached to patch #3432.

 (For expediency, this might just add internal conflicts_with 
 relationships, which doesn't give an absolute guarantee that the 
 nation will never be used, but is probably good enough.) 
In the end, I didn't do this; the out-of-set prohibition is a harder
prohibition than conflicts_with.

(file #16219)
___

Additional Item Attachment:

File name: trunk-S2_4-nation-sets-interim.patch Size:10 KB


___

Reply to this item at:

  http://gna.org/patch/?3449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3432] Core nation group

2012-07-27 Thread Jacob Nevins
Follow-up Comment #6, patch #3432 (project freeciv):

Updated patches attached which rely on the mechanism defined in patch #3449.

(file #16220, file #16221)
___

Additional Item Attachment:

File name: trunk-core-nations-p3449.patch Size:24 KB
File name: S2_4-core-nations-p3449.patch  Size:24 KB


___

Reply to this item at:

  http://gna.org/patch/?3432

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev