[Freeciv-Dev] [bug #17925] Restrict paradrop to only be possible from cities with airport

2013-01-12 Thread Marko Lindqvist 
Follow-up Comment #1, bug #17925 (project freeciv):

> The reason is that an airport is needed in order to let aircraft
> take off.

Then again, in freeciv it generally is not. Fighters fly before Airport even
becomes available.

Still, the idea of making paradrop requirements ruleset defined has some
merit.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19033] Add a LUA 'tick' event

2013-01-12 Thread Marko Lindqvist 
Follow-up Comment #1, bug #19033 (project freeciv):

We already have ai type refresh functionality ( call_ai_refresh() ) so
implementing this should be quite trivial addition.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19313] New players created in editor always have European city style

2013-01-12 Thread Marko Lindqvist 
Update of bug #19313 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #2:

Fix for setting default city style and leader sex for players added via
editor. Leaving editor UI improvements (possibility to edit those values) to
future tickets.

(file #16926, file #16927, file #16928)
___

Additional Item Attachment:

File name: EditorPlrCityStyle.patch   Size:2 KB
File name: EditorPlrCityStyle-S2_4.patch  Size:2 KB
File name: EditorPlrCityStyle-S2_3.patch  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19385] unit_is_in_focus() returns pointer value as bool

2013-01-12 Thread Marko Lindqvist 
Update of bug #19385 (project freeciv):

Category:None => client 
  Status:None => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #3:

It's kind of funny this comes up when compiling as C++, and not as C. Strictly
speaking we have a bug here in C. In both languages it's ok to assign 0 as
FALSE/false, but in C one should use (theoretically distinct) pointer value
NULL instead of 0.

Fix attached

(file #16925)
___

Additional Item Attachment:

File name: FocusUnitBool.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19386] fallback_resources not a const (1)

2013-01-12 Thread Marko Lindqvist 
Update of bug #19386 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0
 Summary: not a const (1) => fallback_resources not a
const (1)

___

Follow-up Comment #3:

Patch

(file #16924)
___

Additional Item Attachment:

File name: FallbackResourcesConst.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19720] Client fails to fork server in next free port when 5556 in use

2013-01-12 Thread Marko Lindqvist 
Update of bug #19720 (project freeciv):

 Summary: Server started by TRUNK client aborts immediately =>
Client fails to fork server in next free port when 5556 in use


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19815] ai won't utilize transports for settling with only 1 space.

2013-01-12 Thread Marko Lindqvist 
Update of bug #19815 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.4.0, 2.5.0   

___

Follow-up Comment #6:

Untested patch

- Military units need only 1 cap ferries
- Settlers require space for bodyguard in their ferries only if it needs
bodyguard (either has one or is requesting one)


(file #16922, file #16923)
___

Additional Item Attachment:

File name: FerryBGCap-S2_4.patch  Size:5 KB
File name: FerryBGCap.patch   Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19886] Mapgen assert fails if ruleset has no unit with role requested first in startunits

2013-01-12 Thread Marko Lindqvist 
Update of bug #19886 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #1:

- Fix

(file #16919, file #16920)
___

Additional Item Attachment:

File name: SearchPossibleStartUnit-S2_3.patch Size:0 KB
File name: SearchPossibleStartUnit.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20007] script_fcdb_init() calls luascript_destroy(NULL)

2013-01-12 Thread Marko Lindqvist 
Follow-up Comment #2, bug #20007 (project freeciv):

Variable shadowing now handled in patch #3590

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3590] Do not shadow variable in script_fcdb.c

2013-01-12 Thread Marko Lindqvist 
URL:
  

 Summary: Do not shadow variable in script_fcdb.c
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 13 Jan 2013 07:09:59 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0, 2.5.0

___

Details:

Rename local variable fcl as lfcl in script_fcdb_cmd_reply() so it doesn't
shadow module wide variable of the same name.

>From bug #20007



___

File Attachments:


---
Date: Sun 13 Jan 2013 07:09:59 AM EET  Name: FclShadow.patch  Size: 1kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3589] Scripting function to adjust player traits

2013-01-12 Thread Marko Lindqvist 
Follow-up Comment #1, patch #3589 (project freeciv):

- Removed comment claiming that trait mod is never adjusted that is no longer
true.

(file #16917)
___

Additional Item Attachment:

File name: TraitModLua-2.patchSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3588] Save trait modification value

2013-01-12 Thread Marko Lindqvist 
Update of patch #3588 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev