[Freeciv-Dev] [patch #3598] Tech Gained -packet

2013-01-20 Thread Marko Lindqvist
Update of patch #3598 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3598

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3480] Tech helptext popup when tech researched

2013-01-20 Thread Marko Lindqvist
Update of patch #3480 (project freeciv):

Category:None = client 
  Status:None = Ready For Test 
 Planned Release: = 2.5.0  

___

Follow-up Comment #2:

Attached patch makes gtk2- and gtk3-clints to popup tech help when it's
gained. This is controlled by the ruleset so that alien ruleset is the only
one of the supplied ones with which this happens.

Future tickets should add client-side option to override ruleset suggestion
(three-state: on/off/ruleset)

(file #16979)
___

Additional Item Attachment:

File name: PopupTechHelp.patchSize:3 KB


___

Reply to this item at:

  http://gna.org/patch/?3480

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3599] Autoaccept tileset -option

2013-01-20 Thread Marko Lindqvist
Update of patch #3599 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3599

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3605] Autoaccept soundset -option

2013-01-20 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3605

 Summary: Autoaccept soundset -option
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Jan 2013 11:08:58 AM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add option to automatically accept soundset suggestions made by ruleset.

In gtk3-client this avoids dialog asking if suggested soundset should be used,
and with other clients where such a dialog is not yet implemented this is the
only way to get soundsets loaded when they are suggested.



___

File Attachments:


---
Date: Sun 20 Jan 2013 11:08:58 AM EET  Name: AutoacceptSoundset.patch  Size:
4kB   By: cazfi

http://gna.org/patch/download.php?file_id=16980

___

Reply to this item at:

  http://gna.org/patch/?3605

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Error in running from custom build dir

2013-01-20 Thread Πρεκατές Αλέξανδρος
 On 19 January 2013 00:43, Πρεκατές Αλέξανδρος apreka...@gmail.com wrote:
  Compiling and installing TRUNK in my build dir i cant run the freeciv:
 
  Just to clarify: Install and builddirs are two different things. Have
 you installed ('make install') this version of freeciv, or are you
 simply running from builddir?
 

Thanks for the clarification. I did think that build dirs contain ALL the 
related files of the installation. Although i still have some trouble 
understanding the build process.


 
  IF you are running from builddir, you should be using wrapper scripts
 ./fcgui  ./fcser that set environment suitable for running from
 builddir, and not freeciv-xxx directly.
 

./fcgui run my freeciv from build dir  worked ok.



  This indicates that you have *not* configured with custom install
 location (--prefix -configure option) but default one (/usr/local) is
 in use.

In svn trunk case i always use autogen.sh?  never configure?
 
 
  incompatible:
  0: datafile options: +Freeciv-2.3-ruleset
 
  Further, you have freeciv-2.3 installed to default location, and
 freeciv (when not run via ./fcser  ./fcgui) finds its data files,
 incompatible with current version.
 
 
 
  To install custom location, there's 3 distinct directory hierarchies:
 srcdir, builddir, and installdir.
 
   cd $HOME
   mkdir freecivbuild
   cd freecivbuild
   ../freecivsrc/autogen.sh --prefix=$HOME/freecivinstall
   make install
   cd ..
   freecivinstall/bin/freeciv-gtk2
 
 
  - ML
 

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3606] Configure check for intptr_t

2013-01-20 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3606

 Summary: Configure check for intptr_t
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Jan 2013 03:29:55 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add configure check for intptr_t.

This is another part of configure.ac that would be cleaner if we bumped
minimum autoconf version to just 2.60 (from current 2.59). I didn't do it yet
in this patch, as this later needs to go to S2_4 too (probably merged to S2_4
version of bug #20392).



___

File Attachments:


---
Date: Sun 20 Jan 2013 03:29:55 PM EET  Name: IntPtrConfigure.patch  Size: 507B
  By: cazfi

http://gna.org/patch/download.php?file_id=16981

___

Reply to this item at:

  http://gna.org/patch/?3606

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20392] cast from pointer to integer of different size

2013-01-20 Thread Marko Lindqvist
Follow-up Comment #4, bug #20392 (project freeciv):

Addition patch for trunk is patch #3606. These should be backported to S2_4
simultaneously.

___

Reply to this item at:

  http://gna.org/bugs/?20392

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2013-01-20 Thread Marko Lindqvist
Follow-up Comment #6, bug #19846 (project freeciv):

Now works perfectly with my crosser build that uses gtk+-3.6.4. Maybe this is
fixed in gtk+ 3.6?

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3601] Remove unused SDL_CVS macro

2013-01-20 Thread Marko Lindqvist
Update of patch #3601 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3601

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20445] server crash

2013-01-20 Thread Jacob Nevins
Update of bug #20445 (project freeciv):

 Planned Release: = 2.5.0  

___

Follow-up Comment #1:

Reproduced with trunk r22164.


#0  dbv_isset (pdbv=0xaf0, bit=1623) at bitvector.c:115
__FUNCTION__ = dbv_isset
#1  0x00495348 in map_claim_border (ptile=value optimised out, 
owner=value optimised out) at maphand.c:1851
dclaimer = 0x3963ab0
dr = 0
dx = 0
dtiledx = 18
_startdx = 18
dtile_index = 0
dy = value optimised out
dtiledy = 66
_startdy = 66
dtile = 0x3963ab0
dtile_cr_radius = value optimised out
radius_sq = 5
__FUNCTION__ = map_claim_border
#2  0x00495a65 in map_claim_base (ptile=0x3963ab0, pbase=0x94fe00, 
powner=0x0, ploser=0x3351680) at maphand.c:1968
No locals.
#3  0x00495ad8 in map_claim_ownership (ptile=0x3963ab0, powner=0x0, 
psource=value optimised out) at maphand.c:1808
pbase = value optimised out
base_loser = 0x3351680
#4  0x00495e09 in map_clear_border (ptile=value optimised out)
at maphand.c:1823
dr = 1623
dx = 0
dtiledx = 18
_startdx = 18
dtile_index = 0
dy = 0
dtiledy = 66
_startdy = 66
dtile = 0xaf0
dtile_cr_radius = value optimised out
radius_sq = 5
__FUNCTION__ = map_clear_border
#5  0x00495ea8 in destroy_base (ptile=0x3963ab0, pbase=0x94fe00)
at maphand.c:2043
No locals.
#6  0x00455154 in update_unit_activity (pplayer=value optimised
out)
at unittools.c:800
id = 640
activity = value optimised out
ptile = 0x3963ab0
check_adjacent_units = value optimised out
#7  update_unit_activities (pplayer=value optimised out) at unittools.c:550
punit = 0x3402b40
punit_index = 41
punit_size = value optimised out
__FUNCTION__ = update_unit_activities
#8  0x0043e589 in begin_phase () at srv_main.c:909
MY_i = 110
pplayer = 0x3351680
#9  srv_running () at srv_main.c:2260
eot_timer = 0x360ea90
save_counter = 1
i = value optimised out
is_new_turn = true
need_send_pending_events = false
__FUNCTION__ = srv_running
#10 0x0043f0b0 in srv_main () at srv_main.c:2775
__FUNCTION__ = srv_main
#11 0x00435a2f in main (argc=value optimised out, 
argv=0x7fff32995fc8) at civserver.c:453
inx = 3
showhelp = false
showvers = false
option = 0x2a7e980 300351247 02
__FUNCTION__ = main


___

Reply to this item at:

  http://gna.org/bugs/?20445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3602] Add warning that INSTALL.Cygwin is very much outdated

2013-01-20 Thread Marko Lindqvist
Update of patch #3602 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3602

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3606] Configure check for intptr_t

2013-01-20 Thread Marko Lindqvist
Update of patch #3606 (project freeciv):

 Planned Release:   2.5.0 = 2.4.0, 2.5.0   

___

Follow-up Comment #1:

Actually, this one is (relatively) safe to commit to S2_4 already. It just
provides some support for bug #20392 to come later.

___

Reply to this item at:

  http://gna.org/patch/?3606

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20445] server crash

2013-01-20 Thread Marko Lindqvist
Update of bug #20445 (project freeciv):

  Status:None = Ready For Test 

___

Follow-up Comment #2:

Attached fix makes map_claim_base() to work when base ownership is transfered
from player to nobody.

(file #16982)
___

Additional Item Attachment:

File name: ReclaimWithNullNot.patch   Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?20445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20445] Server crash when base loses owner

2013-01-20 Thread Marko Lindqvist
Update of bug #20445 (project freeciv):

 Summary:server crash = Server crash when base
loses owner


___

Reply to this item at:

  http://gna.org/bugs/?20445

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20446] fixes for debian build system [PATCH]

2013-01-20 Thread Marko Lindqvist
Update of bug #20446 (project freeciv):

Category:  client = general
  Status:None = Ready For Test 
 Assigned to:None = cazfi  
 Planned Release: = 2.4.0, 2.5.0   


___

Reply to this item at:

  http://gna.org/bugs/?20446

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20413] cityrepdata.c: split_string(): 'd.string_value' may be used uninitialized in this function

2013-01-20 Thread Marko Lindqvist
Update of bug #20413 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #6:

What compiler was complaining was that datum with numeric value, and string
value uninitialized, was copied to vector. What it didn't see was that users
of the vector always respect is_numeric boolean and never access string
value of such a datum. (If it had seen real problem, it would have pointed the
actual use of the uninitialized value, not where it got copied).

Still, it doesn't make sense to have separate numerical value and string value
for a datum when there's ever only one of them used. Attached patch makes them
an union (minimal optimization to both memory and CPU usage (as structure is
copied around)). As union always gets initialized with either numerical or
string value, this fixes also the original uninitialized value warning.

(file #16983)
___

Additional Item Attachment:

File name: DatumUnion.patch   Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?20413

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20447] 'trade_routes_color' may be used uninitialized

2013-01-20 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20447

 Summary: 'trade_routes_color' may be used uninitialized
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 21 Jan 2013 12:25:17 AM EET
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.4, 2.4.0, 2.5.0

___

Details:

With optimization level 3, gcc gives:

client/mapview_common.c: In function 'show_city_descriptions':
client/mapview_common.c:1655:22: error: 'trade_routes_color' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
client/mapview_common.c:1440:32: note: 'trade_routes_color' was declared here
client/mapview_common.c:1767:22: error: 'trade_routes_color' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
client/mapview_common.c:1701:32: note: 'trade_routes_color' was declared here


These seem like gcc is migdiagnosing the situation. In fact, it depends on
exact value assigned to trade_routes_color if warning is emitted or not, to
the extend that reassigning such an unacceptable value when there already is
prior assignment with acceptable value will cause the warning to be emitted.

Luckily, initializing variable when declared makes the warning to go away.
That's what attached patch does.


This is last compiler warning I had with optimization level 3 in S2_4.



___

File Attachments:


---
Date: Mon 21 Jan 2013 12:25:17 AM EET  Name: TradeRoutesColorInit.patch  Size:
2kB   By: cazfi

http://gna.org/bugs/download.php?file_id=16984

___

Reply to this item at:

  http://gna.org/bugs/?20447

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20442] Recursive transports not wiped properly

2013-01-20 Thread Marko Lindqvist
Update of bug #20442 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20442

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20109] Compilation fails with stdinhand on OSX (‘rl_completion_suppress_append’ undeclared)

2013-01-20 Thread Marko Lindqvist
Follow-up Comment #6, bug #20109 (project freeciv):

 this feature was added in readline 4.3, released in 2002.

Probably something we should clean out rather than to extend, but I noticed
that we have not one but two macros defined depending on readline version:
HAVE_LIBREADLINE is set when ever there's readline available, and additional
HAVE_NEWLIBREADLINE is set when readline version is at least 4.2.

___

Reply to this item at:

  http://gna.org/bugs/?20109

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev