Follow-up Comment #10, patch #3804 (project freeciv):
I've encountered a strangeness during the implementation: a difference in
behaviour of unit.c:can_unit_unload() when called from the client and the
server. I am using BV_ISSET(unit_type(pcargo)-disembarks,
uclass_index(unit_class(ptrans))) to
Follow-up Comment #11, patch #3804 (project freeciv):
Risking stating the obvious: start by checking (reading code, adding logging)
that disembarks bitvector is not all-FALSE in client side, i.e., that you send
them from server to client ( ruleset.c:send_ruleset_units() ) and client fills
them in
Follow-up Comment #12, patch #3804 (project freeciv):
The obvious is what needed stating. Thanks for the pointers: even worse, I
had not even defined these bitvectors in packets.def, so that regardless of
the fact that I wasn't sending them, they could not be sent.
URL:
http://gna.org/bugs/?20678
Summary: Unit pointer used after it might died in
unit_move_consequences()
Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 29 Mar 2013 11:42:14 AM EET
Category: general
Update of bug #20679 (project freeciv):
Depends on: = bugs #20678
___
Reply to this item at:
http://gna.org/bugs/?20679
___
Message sent
Update of bug #20679 (project freeciv):
Depends on: = bugs #20663
___
Reply to this item at:
http://gna.org/bugs/?20679
___
Message sent
Update of bug #20679 (project freeciv):
Depends on: = bugs #19989
___
Reply to this item at:
http://gna.org/bugs/?20679
___
Message sent
Follow-up Comment #1, bug #20663 (project freeciv):
As long as I've been hacking freeciv, I've been unhappy with how transported
units are assinged to a tile, and not just to their transport. This bug seems
like a argument for doing it so. Having transported units really in the
transporter,
URL:
http://gna.org/bugs/?20680
Summary: Client crash on contacting metaserver, dependent on
latest version advertised by metaserver
Project: Freeciv
Submitted by: jtn
Submitted on: Fri Mar 29 12:04:04 2013
Category:
Follow-up Comment #1, bug #20680 (project freeciv):
(For the avoidance of doubt: I am about to submit a patch.)
___
Reply to this item at:
http://gna.org/bugs/?20680
___
Message sent via/by
Update of bug #20680 (project freeciv):
Status: In Progress = Ready For Test
___
Additional Item Attachment:
File name: trunk-S2_4-cvercmp-subtokenize-crash.patch Size:1 KB
URL:
http://gna.org/bugs/?20681
Summary: Select menu disabled when no units selected, but
Unit selection dialog could be used
Project: Freeciv
Submitted by: jtn
Submitted on: Fri Mar 29 12:55:50 2013
Category:
URL:
http://gna.org/bugs/?20682
Summary: unit_virtual_destroy() assertion
'!unit_transported(punit)' failed (launching missile from sub to adjacent
tile)
Project: Freeciv
Submitted by: jtn
Submitted on: Fri Mar 29 14:56:43 2013
Follow-up Comment #1, bug #20682 (project freeciv):
(Unit ID 127 is the missile.)
___
Reply to this item at:
http://gna.org/bugs/?20682
___
Message sent via/by Gna!
http://gna.org/
Follow-up Comment #2, bug #20542 (project freeciv):
Still happening with file #17386 on latest S2_4 (r22619), FWIW.
___
Reply to this item at:
http://gna.org/bugs/?20542
___
Message sent
Follow-up Comment #2, bug #20682 (project freeciv):
Don't see this with 2.4.0-beta1, I think because bug #20085 was fixed since
then.
___
Reply to this item at:
http://gna.org/bugs/?20682
___
Follow-up Comment #3, bug #20542 (project freeciv):
...but I don't see it in 2.4.0-beta1 (I'm guessing the fix for bug #20085 is
implicated).
___
Reply to this item at:
http://gna.org/bugs/?20542
Follow-up Comment #4, bug #20542 (project freeciv):
To expand on this:
I think in this case that this assertion is wrong. When
exiting the game, it shouldn't check this.
So, post bug #20085, we have a policy that (unit)-client.transported_by
always reflects what we last saw from the server;
URL:
http://gna.org/patch/?3810
Summary: freeciv-web configure checks to separate m4-file
Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 29 Mar 2013 06:58:52 PM EET
Category: bootstrap
Priority: 5
Follow-up Comment #2, bug #20680 (project freeciv):
Your description and patch seem to make sense, but like you said
Not sure why it hasn't bitten me before now, to be honest.
I really don't understand how my test cases have been passing, including
ordering of beta1 and beta2.
Follow-up Comment #16, bug #20045 (project freeciv):
in unit_transport_unload() [unit.c::2072]: assertion
'same_pos(unit_tile(pcargo), unit_tile(ptrans))' failed.
I've seen this assertion failing in 2.4.0-beta1 on the client a couple of
times when testing with loading/unloading submarines and
Update of bug #20668 (project freeciv):
Status:None = Need Info
___
Follow-up Comment #1:
I can't reproduce in 2.4.0-beta1; in my quick testing, Cruise Missiles on
board a Submarine were
Follow-up Comment #2, bug #20663 (project freeciv):
I think it's possible to fix this in respect to supplied rulesets by moving
block of code that moves trasnported units to new tile to be before handling
of autoattack and huts.
After that the only possibility of already moved transporter to die
Follow-up Comment #3, bug #20680 (project freeciv):
I really don't understand how my test cases have been passing,
including ordering of beta1 and beta2.
Bad luck could do it -- depending on the contents of memory and not triggering
a segfault -- but it seems like it would have to be quite bad
Follow-up Comment #4, bug #20680 (project freeciv):
Here is what I committed to upstream in case we want to keep files completely
identical (there's C++-style comment that would be forbidden by freeciv
CodingStyle)
(file #17602)
___
Follow-up Comment #5, bug #20680 (project freeciv):
BTW, build/cvercmp 2.4.0 greater 2.4.0-beta1 says No. This
is after my changes, but I suspect I can't have affected that.
That seems like it will be a problem for us?
Problem is in documentation. I had hard time deciding which order cvercmp
Follow-up Comment #6, bug #20680 (project freeciv):
One thing that probably helped testcases to pass was that ' ' was ignored only
when collecting subtokens - garbage was added to the end of subtoken. But the
garbage begun with ' ' which terminated subtoken when it was actually used.
I'm
Update of bug #20664 (project freeciv):
Status: Ready For Test = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
Update of bug #20660 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #3798 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
URL:
http://gna.org/patch/?3812
Summary: Leader to civil war player
Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 30 Mar 2013 01:29:24 AM EET
Category: general
Priority: 5 - Normal
Update of bug #20577 (project freeciv):
Depends on: = patch #3812
___
Follow-up Comment #21:
patch #3812 provides new function to use for giving leader units midgame.
32 matches
Mail list logo
