[Freeciv-Dev] [bug #20940] freeciv-gtk2.exe causes a Stack Overflow
Follow-up Comment #2, bug #20940 (project freeciv): A couple of further hints about this bug. It was made less likely by reducing the movement animation time. I suspect this was because showing the gotos hadn't been finished at TC. Also it is not just a client goto issue. The same bug occurred during bombard combat. With a dozen bombers attacking a city containing 100 spies you get to see the bombard combat animation 1200 times. Unless you lower the combat animation the client will crash at TC. ___ Reply to this item at: http://gna.org/bugs/?20940 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #1, bug #20939 (project freeciv): An update to this bug. After building recycling centres and solar power plants in all cities this bug stopped occurring. Suggesting there is some connection to the pollution or pollution clean up. ___ Reply to this item at: http://gna.org/bugs/?20939 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20955] Extra owner information expected in old savegames
URL: http://gna.org/bugs/?20955 Summary: Extra owner information expected in old savegames Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Jul 2013 10:48:19 AM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Loading pre-2.6 savegames fail due to missing eowner information. Fix attached. ___ File Attachments: --- Date: Wed 10 Jul 2013 10:48:19 AM EEST Name: OldSaveEowner.patch Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=18228 ___ Reply to this item at: http://gna.org/bugs/?20955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20956] Bombarding an empty city allows veterancy gains.
URL: http://gna.org/bugs/?20956 Summary: Bombarding an empty city allows veterancy gains. Project: Freeciv Submitted by: None Submitted on: Wed Jul 10 07:48:21 2013 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.4 Discussion Lock: Any Operating System: None Planned Release: ___ Details: If you bombard an empty city the combat animation is shown and the bombarding unit may gain veterancy. ___ Reply to this item at: http://gna.org/bugs/?20956 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3982] Portucalense nation
URL: http://gna.org/patch/?3982 Summary: Portucalense nation Project: Freeciv Submitted by: None Submitted on: mié 10 jul 2013 08:14:45 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@hotmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Hi: I present you the immediate precedent of the kingdom of Portugal, wherefrom this one was born. Hope you like it. ___ File Attachments: --- Date: mié 10 jul 2013 08:14:45 UTC Name: portucalense.ruleset Size: 2kB By: None http://gna.org/patch/download.php?file_id=18229 --- Date: mié 10 jul 2013 08:14:45 UTC Name: portucalense.svg Size: 14kB By: None http://gna.org/patch/download.php?file_id=18230 ___ Reply to this item at: http://gna.org/patch/?3982 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20946] Missing #include stdint.h
Follow-up Comment #2, bug #20946 (project freeciv): I built the release tarball of 2.4.0-beta2 on Ubuntu 12.04, which is 2.68 Could original submitter comment if (s)he just did ./configure make, or if local autoconf was somehow involved (such as running ./autogen.sh), and if latter, which version of autoconf that is? #ifdef HAVE_STDINT_H #include stdint.h #endif We have no (explicit) configure check for setting HAVE_STDINT_H, so that too would be needed. Neither have we explicit check for HAVE_INTTYPES_H, but that one seems to be set in my fc_config.h - maybe AC_TYPE_INTPTR_T sets macro related to correct header as side-effect, or maybe the macro is set by some completely unrelated configure test. Maybe support.h should have something like the following to always get the more correct header: #ifdef HAVE_INTTYPES_H #include inttypes.h #else #ifdef HAVE_STDINT_H #include stdint.h #endif #endif ___ Reply to this item at: http://gna.org/bugs/?20946 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3983] Irmandade nation
URL: http://gna.org/patch/?3983 Summary: Irmandade nation Project: Freeciv Submitted by: None Submitted on: mié 10 jul 2013 08:38:42 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@hotmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Hi: I prepared another interesting nation, based on the history of Galicia, and a small but intense part of his history.In fact, during this time, Galicia obtain a government different from the one that had, and a mentality also different. Hope you like it. ___ File Attachments: --- Date: mié 10 jul 2013 08:38:42 UTC Name: irmandade.ruleset Size: 2kB By: None http://gna.org/patch/download.php?file_id=18231 --- Date: mié 10 jul 2013 08:38:42 UTC Name: Irmandade.svg Size: 118kB By: None http://gna.org/patch/download.php?file_id=18232 ___ Reply to this item at: http://gna.org/patch/?3983 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3984] Wallachia nation
URL: http://gna.org/patch/?3984 Summary: Wallachia nation Project: Freeciv Submitted by: None Submitted on: mié 10 jul 2013 09:21:26 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@hotmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Hi again: I suggest another nation to the game.Hope you like it. ___ File Attachments: --- Date: mié 10 jul 2013 09:21:26 UTC Name: wallachia.ruleset Size: 1kB By: None http://gna.org/patch/download.php?file_id=18233 --- Date: mié 10 jul 2013 09:21:26 UTC Name: wallachia.svg Size: 44kB By: None http://gna.org/patch/download.php?file_id=18234 ___ Reply to this item at: http://gna.org/patch/?3984 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3958] Keep one defender in unthreatened cities
Update of patch #3958 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20957] Compilation fails with Ferry Stats Logging enabled
URL: http://gna.org/bugs/?20957 Summary: Compilation fails with Ferry Stats Logging enabled Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Jul 2013 02:13:56 PM EEST Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: There's some compiler errors when one defines LOGLEVEL_FERRY_STATS. Fix attached. ___ File Attachments: --- Date: Wed 10 Jul 2013 02:13:56 PM EEST Name: FerryStatsCompile.patch Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=18235 ___ Reply to this item at: http://gna.org/bugs/?20957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3974] Replace terrain.ruleset's (pollution|fallout)_(food|shield|trade)_penalty with yet another output effect
Follow-up Comment #3, patch #3974 (project freeciv): Looking the effects definitions I wonder why there's no nreqs for anything. If tile has both Pollution and Fallout, all three effects are active, resulting in 50% + 50% + 25% = 125% penalty? If effect that has only Pollution as req would have nreq Fallout (or vice versa), this would be 50% + 25% = 75% instead. ___ Reply to this item at: http://gna.org/patch/?3974 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3985] Ues requirements of type extra in supplied rulesets
URL: http://gna.org/patch/?3985 Summary: Ues requirements of type extra in supplied rulesets Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Jul 2013 05:56:51 PM EEST Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Replace all Special, Base, and Road requirements in all rulesets with Extra requirements. ___ File Attachments: --- Date: Wed 10 Jul 2013 05:56:51 PM EEST Name: RulesetExtraReq.patch Size: 14kB By: cazfi http://gna.org/patch/download.php?file_id=18237 ___ Reply to this item at: http://gna.org/patch/?3985 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3975] Replace act_tgt with extra_type pointer.
Update of patch #3975 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3975 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3986] Select pillage target by extra id
URL: http://gna.org/patch/?3986 Summary: Select pillage target by extra id Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Jul 2013 08:09:50 PM EEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Remove conversion from extra to serialized value of extra subclasses and back in guis. Pillage targets are known by their extra id instead. ___ File Attachments: --- Date: Wed 10 Jul 2013 08:09:50 PM EEST Name: PillageCleanup.patch Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=18238 ___ Reply to this item at: http://gna.org/patch/?3986 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3976] Extra requirements
Follow-up Comment #1, patch #3976 (project freeciv): - Updated against svn (file #18239) ___ Additional Item Attachment: File name: ExtraReqs-2.patch.bz2 Size:8 KB ___ Reply to this item at: http://gna.org/patch/?3976 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3979] lusitanian civilization, please
Follow-up Comment #2, patch #3979 (project freeciv): OK, I see it now. Sorry then for the reiterative suggestion. ___ Reply to this item at: http://gna.org/patch/?3979 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20960] Server crash - while processing spy sabotage info from client
URL: http://gna.org/bugs/?20960 Summary: Server crash - while processing spy sabotage info from client Project: Freeciv Submitted by: mir3x Submitted on: Wed 10 Jul 2013 09:28:55 PM CEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Server crash when sabotaging improvement with modified client (in gtk2 client change in diplomat_dialog.c in line 356: from diplomat_target_id, sabotage_improvement + 1); to diplomat_target_id, sabotage_improvement); Load attached save_game, choose acive spy, sabotage -At spy disrection- nearest city client will send B_LAST as improvement number and server will crash. Last log from server: 3: got packet type=(PACKET_UNIT_DIPLOMAT_ACTION)84 len=12 from xontastic 3: packet_unit_diplomat_action_100: got info about () 3: no old info 3: got field 'diplomat_id' 3: got field 'target_id' 3: got field 'value' 3: got field 'action_type' 3: packet_processing_started_100: sending info about () 3: sending packet type=PACKET_PROCESSING_STARTED(0) len=4 to xontastic ___ File Attachments: --- Date: Wed 10 Jul 2013 09:28:56 PM CEST Name: serv_crash.sav.bz2 Size: 53kB By: mir3x http://gna.org/bugs/download.php?file_id=18240 ___ Reply to this item at: http://gna.org/bugs/?20960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3987] Pointer to extra type to road/base types
URL: http://gna.org/patch/?3987 Summary: Pointer to extra type to road/base types Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Jul 2013 11:09:25 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Currently it's somewhat costly to get extra_type from base_type or road_type with extra_type_get(). Attached patch adds direct pointer from base_type and road_type structures to their extra_type. No callers are touched to avoid conflicts with other patches currently being processed. New patches should use these new base_extra_get() and road_base_get() functions instead of extra_type_get() when appropriate. ___ File Attachments: --- Date: Wed 10 Jul 2013 11:09:25 PM EEST Name: BaseroadExtraGet.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=18241 ___ Reply to this item at: http://gna.org/patch/?3987 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20950] Pthread linking problems
Update of bug #20950 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20950 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3988] Extra causes Base and Road
URL: http://gna.org/patch/?3988 Summary: Extra causes Base and Road Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Jul 2013 12:39:59 AM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add extra_cause types Base and Road, and set those for bases and roads. As a side effect one minor bug disappears - cause list for EC_NONE contained extras up to index MAX_EXTRA_TYPES and not just to number of extras in current ruleset. ___ File Attachments: --- Date: Thu 11 Jul 2013 12:39:59 AM EEST Name: CauseBaseroad.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=18242 ___ Reply to this item at: http://gna.org/patch/?3988 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3989] Build defenders for martial law needs
URL: http://gna.org/patch/?3989 Summary: Build defenders for martial law needs Project: Freeciv Submitted by: cazfi Submitted on: Thu 11 Jul 2013 12:49:26 AM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: patch #3959 makes AI to assign defenders for martial law benefits. This patch makes it to also build them for that purpose. Logic between the two martial unit need checks is a bit different. One important thing to test here is that AI won't end building martial law units but then using them for something else (moving out of city), leading to it building nothing but them. ___ File Attachments: --- Date: Thu 11 Jul 2013 12:49:26 AM EEST Name: BuildMartial.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=18243 ___ Reply to this item at: http://gna.org/patch/?3989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3959] Assign defenders for their martial law value
Follow-up Comment #2, patch #3959 (project freeciv): I'll submit separate patch to make AI also build units for martial law effect. That's now in patch #3989 ___ Reply to this item at: http://gna.org/patch/?3959 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
