[Freeciv-Dev] [patch #4160] Gfx for Inaccessible terrain

2013-09-10 Thread Marko Lindqvist
Follow-up Comment #2, patch #4160 (project freeciv):

Patch for specfile changes for gm1530's amplio2 version. (Consider inspection
period for his gfx + this patch started now)

(file #18953)
___

Additional Item Attachment:

File name: Amplio2InaccessibleSpec.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?4160

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4159] Add Inaccessible terrain to supplied rulesets

2013-09-10 Thread Marko Lindqvist
Follow-up Comment #5, patch #4159 (project freeciv):

- Fixed typo in gfx tag name

(file #18954)
___

Additional Item Attachment:

File name: InaccessibleTerrain-2.patchSize:9 KB


___

Reply to this item at:

  http://gna.org/patch/?4159

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21123] [tile_xxx] section name is significant

2013-09-10 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?21123

 Summary: [tile_xxx] section name is significant
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 10 Sep 2013 10:55:53 AM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

As section names do not matter anywhere else, I find it highly unexpected that
they do it .tilespec [tile_xxx] names. Also the other way around: when
searching after where gfx tags for terrains are used in tileset, one does not
realize that it's in section names.
I would find it much more clear if there was separate field in the
tile-section defining which gfx tag it corresponds to.




___

Reply to this item at:

  http://gna.org/bugs/?21123

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4169 (project freeciv):

New version. Changes:
 * change qt, gtk2 and sdl as well. SDL had already merged spy vs city and
diplomat vs city. Change SDL2 even if it won't compile (no matter if this
patch is applied or not).
 * gtk2, gtk3, sdl: blank out the potential targets before starting like the
qt client does.
 * use an array for the different potential targets. Limit it to one unit and
one city.

(file #18957)
___

Additional Item Attachment:

File name: merge_spy_gui_menues.patch Size:68 KB


___

Reply to this item at:

  http://gna.org/patch/?4169

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21125] ./configure ignores sdl2 requirements when the sdl1 client is built as well

2013-09-10 Thread Marko Lindqvist
Update of bug #21125 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #2:

Fix. Configure used save variable to store result of sdl and sdl2 checks so
success in either was considered success in the another too.

(file #18960)
___

Additional Item Attachment:

File name: GuiSpecificFoundVar.patch  Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?21125

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [task #7729] Windows packages for 2.4.0-RC2

2013-09-10 Thread Christian Prochaska
Update of task #7729 (project freeciv):

  Status:None = Done   
 Open/Closed:Open = Closed 

___

Follow-up Comment #5:

 I've announced the Windows packages despite this not being 
 closed, as they seemed to be up and I'm unlikely to have time 
 tomorrow. Hope that wasn't premature in some way. 
Thanks, all fine.

___

Reply to this item at:

  http://gna.org/task/?7729

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4164] Clean up the actions module

2013-09-10 Thread Sveinung Kvilhaugsvik
Update of patch #4164 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4164

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4171] Threaded AI and timeout -1

2013-09-10 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?4171

 Summary: Threaded AI and timeout -1
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 11 Sep 2013 02:32:24 AM EEST
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Timeout -1 that's supposed to progress game as fast as all players can, does
not work with threaded ai. That's because it assumes that all ai actions are
in main thread, and proceeds to next turn as soon as call to ai code
finishes.
Attached patch makes also ais to acknowledge server when they are ready. This
uses separate variable from human player turn done, so that for example
/taking ai player will give human player control of ending current turn
instead it being already pressed by the ai.




___

File Attachments:


---
Date: Wed 11 Sep 2013 02:32:24 AM EEST  Name: ThreadedAutogameProgress.patch 
Size: 5kB   By: cazfi

http://gna.org/patch/download.php?file_id=18963

___

Reply to this item at:

  http://gna.org/patch/?4171

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21011] Xaw won't start if suitable font not installed

2013-09-10 Thread Sveinung Kvilhaugsvik
Update of bug #21011 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?21011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, patch #4169 (project freeciv):

 Anyway, your patch does not break sdl2-client compilation here.
Thank you for testing it for me, Marko.

  You mean there's a compilation bug, or that you don't have SDL2 libraries
to build it against?
Yes. See bug #21125.

___

Reply to this item at:

  http://gna.org/patch/?4169

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4170] Spy actions vs units in cities

2013-09-10 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?4170

 Summary: Spy actions vs units in cities
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 10 Sep 2013 04:01:25 PM GMT
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

It is not possible to do actions against units in cities. Document this fact
for bribe unit. Move it to the rule set for sabotage unit.

This probably shouldn't go in before meta knowledge about if the client can
see the units in a city is added.



___

File Attachments:


---
Date: Tue 10 Sep 2013 04:01:25 PM GMT  Name: action_vs_unit_in_city.patch 
Size: 5kB   By: sveinung

http://gna.org/patch/download.php?file_id=18959

___

Reply to this item at:

  http://gna.org/patch/?4170

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4112] Update earth-80x50 scenario to 2.5 savegame format

2013-09-10 Thread Marko Lindqvist
Update of patch #4112 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Patch

(file #18961)
___

Additional Item Attachment:

File name: EarthSmall25.patch.bz2 Size:4 KB


___

Reply to this item at:

  http://gna.org/patch/?4112

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4162] README.achievements non-unique achievements

2013-09-10 Thread Marko Lindqvist
Update of patch #4162 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4162

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4119] Update north_america_116x100 scenario to 2.5 savegame format

2013-09-10 Thread Marko Lindqvist
Update of patch #4119 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4119

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4142] Remove any EC_MINE or EC_IRRIGATION extras when terrain changes to non-suitable

2013-09-10 Thread Marko Lindqvist
Update of patch #4142 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4142

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Marko Lindqvist
Follow-up Comment #3, patch #4169 (project freeciv):

Anyway, your patch does not break sdl2-client compilation here. And
functionality cannot be tested as sdl2-client still misses even proper
initialization code.

___

Reply to this item at:

  http://gna.org/patch/?4169

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Marko Lindqvist
Follow-up Comment #2, patch #4169 (project freeciv):

 Change SDL2 even if it won't compile (no matter if this patch
 is applied or not).

You mean there's a compilation bug, or that you don't have SDL2 libraries to
build it against?

___

Reply to this item at:

  http://gna.org/patch/?4169

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4158] NotGenerated terrain flag

2013-09-10 Thread Marko Lindqvist
Update of patch #4158 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4158

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21105] Action enablers: Client may not be aware that an action is allowed

2013-09-10 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, bug #21105 (project freeciv):

A proof of concept. Not complete. Not well tested. Code style etc not checked.
Code not cleaned up.

Uncertain actions are marked by the color red in the gtk3 client. I'm not sure
if this is the best way to mark them or if coloring them the way my code does
is correct. Support for gtk2, qt and sdl should hopefully be there in the
final version.

No meta knowledge at all is included. As a result all actions using action
enablers are uncertain. The hard coded support for the old default
requirements now moved to action enablers may or may not be added in the final
version of this patch. For the moment it isn't added to keep the size small.

Applies of top of patch #4164, patch #4167 and patch #4169

(file #18962)
___

Additional Item Attachment:

File name: allow_uncertain.patch  Size:12 KB


___

Reply to this item at:

  http://gna.org/bugs/?21105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21125] ./configure ignores sdl2 requirements when the sdl1 client is built as well

2013-09-10 Thread Marko Lindqvist
Update of bug #21125 (project freeciv):

  Status:None = In Progress
 Assigned to:None = cazfi  

___

Follow-up Comment #1:

Fix on the way.

___

Reply to this item at:

  http://gna.org/bugs/?21125

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21125] ./configure ignores sdl2 requirements when the sdl1 client is built as well

2013-09-10 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?21125

 Summary: ./configure ignores sdl2 requirements when the sdl1
client is built as well
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 10 Sep 2013 04:42:49 PM GMT
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

./configure permits many clients to be built at once. When asked to only build
the sdl2 client it will complain about missing sdl2 libraries. When asked to
build it with the sdl client it won't. It will complain when built with the qt
client. Other combinations that include sdl and sdl2 that I have tested have
the problem as well.

SDL2 alone:

./configure --enable-debug --enable-client=sdl2

(...)

checking for threads implementation... pthreads
checking for SDL2... no
checking for sdl2-config... no
checking for SDL2 - version = 2.0.0... yes
*** The sdl2-config script installed by SDL2 could not be found
*** If SDL2 was installed in PREFIX, make sure PREFIX/bin is in
*** your path, or set the SDL2_CONFIG environment variable to the
*** full path to sdl2-config.
configure: error: specified client 'sdl2' not configurable (SDL2 = 2.0.0 is
needed (www.libsdl.org))

configure failed

SDL and SDL2:

./configure --enable-debug --enable-client=sdl,sdl2  make

(...)

  CC   widget_scrollbar.lo
  CC   widget_window.lo
  CC   wldlg.lo
  CCLD libgui-sdl.la
make[3]: Leaving directory
`/home/sveinung/Master/freeciv/trunk/client/gui-sdl'
Making all in gui-sdl2
make[3]: Entering directory
`/home/sveinung/Master/freeciv/trunk/client/gui-sdl2'
  CC   SDL2_gfxPrimitives.lo
In file included from SDL2_gfxPrimitives.c:40:0:
SDL2_gfxPrimitives.h:76:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:77:41: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:81:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:82:41: error: unknown type name 'SDL_Renderer'
In file included from SDL2_gfxPrimitives.c:40:0:
SDL2_gfxPrimitives.h:86:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:87:41: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:91:46: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:92:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:97:53: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:98:52: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:103:40: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:104:39: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:109:47: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:110:46: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:115:41: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:116:40: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:121:43: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:122:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:126:46: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:128:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:133:43: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:134:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:138:40: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:139:39: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:144:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:145:44: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:150:49: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:151:48: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:156:44: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:157:43: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:162:46: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:163:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:168:50: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:169:49: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:174:40: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:176:39: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:181:46: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:183:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:188:43: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:189:42: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:194:45: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:195:44: error: unknown type name 'SDL_Renderer'
SDL2_gfxPrimitives.h:200:49: 

[Freeciv-Dev] [bug #21126] assertion 'prgbcolor != ((void *)0)' failed.

2013-09-10 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?21126

 Summary: assertion 'prgbcolor != ((void *)0)' failed.
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 10 Sep 2013 08:42:01 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

In S2_5:
 ./fcser -f ../src/data/scenarios/tileset-demo.sav
...
 scensave tileset-demo

results in a number of failed asserts

in rgbcolor_save() [../src/common/rgbcolor.c::128]: assertion 'prgbcolor !=
((void *)0)' failed.
2: Backtrace:
2: 0: ./server/freeciv-server() [0x6081ed]
2: 1: ./server/freeciv-server(vdo_log+0x89) [0x60ba59]
2: 2: ./server/freeciv-server(do_log+0x7d) [0x60bb0d]
2: 3: ./server/freeciv-server(fc_assert_fail+0x9f) [0x60bd3f]
2: 4: ./server/freeciv-server(rgbcolor_save+0x145) [0x5f3fa5]
2: 5: ./server/freeciv-server() [0x4bb029]
2: 6: ./server/freeciv-server() [0x4c97c6]
2: 7: ./server/freeciv-server(savegame2_save+0x65) [0x4cc375]
2: 8: ./server/freeciv-server(save_game+0xe0) [0x435920]
2: 9: ./server/freeciv-server() [0x447cd1]
2:10: ./server/freeciv-server() [0x4cda00]
2:11: /lib/x86_64-linux-gnu/libreadline.so.6(rl_callback_read_char+0x11b)
[0x7f0f4d0d97fb]
2:12: ./server/freeciv-server(server_sniff_all_input+0x111b) [0x4cf36b]
2:13: ./server/freeciv-server(srv_main+0x16d) [0x439d6d]
2:14: ./server/freeciv-server(main+0x21e) [0x43117e]
2:15: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f0f4c5fa995]
2:16: ./server/freeciv-server() [0x431b8f]





___

Reply to this item at:

  http://gna.org/bugs/?21126

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik
Update of patch #4169 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?4169

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev