[Freeciv-Dev] [patch #4502] Pass the diplomat to the spesific client code when asking follow up questions
URL: http://gna.org/patch/?4502 Summary: Pass the diplomat to the spesific client code when asking follow up questions Project: Freeciv Submitted by: sveinung Submitted on: Fri 14 Feb 2014 10:42:39 AM UTC Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0, 2.5.0 ___ Details: All packets asking follow up questions about about diplomat action contain the ID of the acting diplomat. It is used in the generic client code. Forward it to the client specific code. All this does is to change the interface and make the generic client code pass on the diplomat. The clients keep makes no use of this information. A solution to bug #21636 can be based on this. I assume that bug #21636 also exists in 2.4. Would back porting this patch to the 2.4 branch as a dependency for solving bug #21636 be acceptable or is the interface between the generic client code and the specific client code frozen? ___ Reply to this item at: http://gna.org/patch/?4502 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4502] Pass the diplomat to the spesific client code when asking follow up questions
Follow-up Comment #1, patch #4502 (project freeciv): The 2.5 version. (file #20047) ___ Additional Item Attachment: File name: 2.5_pass_the_actor_when_asking_for_details.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?4502 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4502] Pass the diplomat to the spesific client code when asking follow up questions
Additional Item Attachment, patch #4502 (project freeciv): File name: pass_the_actor_when_asking_for_details.patch Size:14 KB ___ Reply to this item at: http://gna.org/patch/?4502 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21636] Wrong diplomat for two stage actions when in a diplomat queue
Update of bug #21636 (project freeciv): Release: 2.6.0 = 2.6.0, 2.5.0, 2.4.2 Planned Release: = 2.6.0, 2.5.0, 2.4.3 ___ Reply to this item at: http://gna.org/bugs/?21636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4502] Pass the diplomat to the spesific client code when asking follow up questions
Follow-up Comment #2, patch #4502 (project freeciv): [on 2.4] is the interface between the generic client code and the specific client code frozen? No, that's not frozen. --jtn ___ Reply to this item at: http://gna.org/patch/?4502 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4495] Let action enablers for bribing or sabotaging a unit know it must be alone at its tile
Update of patch #4495 (project freeciv): Category:None = general Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4495 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21644] Qt 5.2's moc not detected because of version string format changes
Update of bug #21644 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21644 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21645] Writing isn't capitalized in doc/README.actions
Additional Item Attachment, bug #21645 (project freeciv): File name: doc_action_enabler_example_capitalization.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?21645 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21636] Wrong diplomat for two stage actions when in a diplomat queue
Follow-up Comment #1, bug #21636 (project freeciv): Is the behavior that the popup asking the player to select actions for the next unit in the diplomat queue before questions are answered intended? If it is intended (and still wanted) a fix can be based on patch #4502. If it isn't intended making it wait for the follow up questions would fix this but introduce bug #21646. ___ Reply to this item at: http://gna.org/bugs/?21636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21651] The diplomat queue stops on invalid server question
URL: http://gna.org/bugs/?21651 Summary: The diplomat queue stops on invalid server question Project: Freeciv Submitted by: sveinung Submitted on: Fri 14 Feb 2014 04:21:24 PM UTC Category: client Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: sveinung Originator Email: Open/Closed: Open Release: 2.6.0 Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: The generic client code validates follow up questions the server sends regarding diplomatic actions. If the information is seen as invalid the packet is discarded. The specific client code isn't noticed. This is one (but not the only) thing that can cause bug #21646. The attached patch makes the generic client code move the queue forward when the server sends an invalid follow up question. ___ File Attachments: --- Date: Fri 14 Feb 2014 04:21:24 PM UTC Name: diplomat_queue_generic_client_forward.patch Size: 3kB By: sveinung http://gna.org/bugs/download.php?file_id=20050 ___ Reply to this item at: http://gna.org/bugs/?21651 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21646] The client may temporarily stop progressing in the diplomat queue
Update of bug #21646 (project freeciv): Depends on: = bugs #21651 ___ Reply to this item at: http://gna.org/bugs/?21646 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21636] Wrong diplomat for two stage actions when in a diplomat queue
Follow-up Comment #2, bug #21636 (project freeciv): Is there any connection to another unit type with action popups, caravans. In any case I'd like to see diplomat caravan actions brought together, so that long standing limitation that same unit cannot sensibly have both diplomat and caravan flag would be lifted (problem currently being that for such a unit only one action popup would be presented, so there's no way to make actions of the other kind) Do you have any plans of this? I also assume that it would mean enabling caravan actions via action enablers. ___ Reply to this item at: http://gna.org/bugs/?21636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21410] Gen-road unit orders not loaded correctly from savefile?
Follow-up Comment #3, bug #21410 (project freeciv): after some checking that they always have been, of course I think we can live with the fact that someone could have created an scenario by manually editing savegame relying on case insensitivity. I'd say it was never supposed to work, so in such a case bug would be in the scenario. ___ Reply to this item at: http://gna.org/bugs/?21410 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21654] Tutorial popup open behind the city dialog
URL: http://gna.org/bugs/?21654 Summary: Tutorial popup open behind the city dialog Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 01:05:10 AM EET Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Let's make a ticket about something that has always bothered me in the tutorial scenario: When you found your first city, and you have the default setting that city dialog will open automatically, tutorial popup message explaining what to do opens first, usually ending hidden behind the city dialog. Maybe this could be fixed by delaying opening of the popup a bit once we have signal like tick() where to do the actual popup. ___ Reply to this item at: http://gna.org/bugs/?21654 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21410] Gen-road unit orders not loaded correctly from savefile?
Update of bug #21410 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21410 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4482] Convert experimental ruleset effects to use present = FALSE instead of nreqs
Update of patch #4482 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4482 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4503] Effect name - type
URL: http://gna.org/patch/?4503 Summary: Effect name - type Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 01:41:21 AM EET Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: It seems we had still missed those name effect fields where it was followed by tab and not space(s). Attached patch corrects those to type too. ___ File Attachments: --- Date: Sat 15 Feb 2014 01:41:21 AM EET Name: EffectTypeNoName.patch.bz2 Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=20051 --- Date: Sat 15 Feb 2014 01:41:21 AM EET Name: EffectTypeNoName-S2_5.patch.bz2 Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=20052 ___ Reply to this item at: http://gna.org/patch/?4503 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4492] Alignment keeping ASSEMBLE_RGB DISEMBLE_RGB
Update of patch #4492 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4492 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4504] No artihmetics on uninitialized ww
URL: http://gna.org/patch/?4504 Summary: No artihmetics on uninitialized ww Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 02:37:35 AM EET Category: client-sdl Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: Clang complains about artihmetics done to possibly uninitialized variable 'ww'. Checking this in more detail turns out that the result is never used anyway, so just remove the code line. ___ File Attachments: --- Date: Sat 15 Feb 2014 02:37:35 AM EET Name: UnusedWW.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=20053 --- Date: Sat 15 Feb 2014 02:37:35 AM EET Name: UnusedWW-S2_5.patch Size: 1021B By: cazfi http://gna.org/patch/download.php?file_id=20054 ___ Reply to this item at: http://gna.org/patch/?4504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4505] Update md5.c to upstream revision 1.13
URL: http://gna.org/patch/?4505 Summary: Update md5.c to upstream revision 1.13 Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 03:03:23 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: In the hope that it would help with bug #18872 I updated md5.c to latest version from upstream. It didn't help with our problem, but now that we have the update it makes sense to apply it. ___ File Attachments: --- Date: Sat 15 Feb 2014 03:03:23 AM EET Name: Md51.13.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=20055 ___ Reply to this item at: http://gna.org/patch/?4505 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4493] Options to enable sfx and/or music
Follow-up Comment #1, patch #4493 (project freeciv): - Updated against svn (file #20056) ___ Additional Item Attachment: File name: AudioOptions-2.patch Size:7 KB ___ Reply to this item at: http://gna.org/patch/?4493 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4506] Specialists3
URL: http://gna.org/patch/?4506 Summary: Specialists3 Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 03:38:37 AM EET Category: art Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: GriffonSpade has made third version of the specialist icons, now with both females and males: http://forum.freeciv.org/f/viewtopic.php?f=12t=7start=40#p1453 ___ File Attachments: --- Date: Sat 15 Feb 2014 03:38:37 AM EET Name: Specialists3.patch Size: 960B By: cazfi http://gna.org/patch/download.php?file_id=20057 --- Date: Sat 15 Feb 2014 03:38:37 AM EET Name: specialists3.png Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=20058 ___ Reply to this item at: http://gna.org/patch/?4506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21656] Tile labels not handled in copy+paste
URL: http://gna.org/bugs/?21656 Summary: Tile labels not handled in copy+paste Project: Freeciv Submitted by: cazfi Submitted on: Sat 15 Feb 2014 09:53:46 AM EET Category: editor Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: From bug #21655: And strange characters appear in the tile I pasted. That's most likely tile label which ends up uninitialized in copy+paste. Fix attached. ___ File Attachments: --- Date: Sat 15 Feb 2014 09:53:46 AM EET Name: CopyLabel.patch Size: 573B By: cazfi http://gna.org/bugs/download.php?file_id=20060 ___ Reply to this item at: http://gna.org/bugs/?21656 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21655] Copy and Paste of tile in edit mode does not work properly
Follow-up Comment #1, bug #21655 (project freeciv): I think these are two separate issues. I'm reserving this ticket for the tile pasted to wrong coordinates issue, for which I have no explanation yet. The strange character is bug #21656 ___ Reply to this item at: http://gna.org/bugs/?21655 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
