[Freeciv-Dev] [patch #3871] Support airlifting units with complex nativity
Update of patch #3871 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3871 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4651] Barbarian Leaders should accept amphibious bodyguards
Update of patch #4651 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4651 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21913] find_beachhead() doesn't work properly
Update of bug #21913 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21913 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16383] Option to forbid RiverNative units moving diagonally / cross-continent
Update of bug #16383 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16383 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity
Follow-up Comment #6, patch #3901 (project freeciv): Rebased against r24826 (file #20614) ___ Additional Item Attachment: File name: native-get_MC-callbacks+rebase2.patch Size:20 KB ___ Reply to this item at: http://gna.org/patch/?3901 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries
Follow-up Comment #13, bug #21897 (project freeciv): all builds (S2_4, S2_5 and S2_6) are fine - I did not test the functionality ___ Reply to this item at: http://gna.org/bugs/?21897 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries
Update of bug #21897 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21897 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21982] present=FALSE improvement requirements can cause incorrect server messages
Update of bug #21982 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21982 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21991] aicity::affected_unit_class() assumes reqs can only match one or all unit classes
URL: http://gna.org/bugs/?21991 Summary: aicity::affected_unit_class() assumes reqs can only match one or all unit classes Project: Freeciv Submitted by: persia Submitted on: Wed 30 Apr 2014 11:31:47 AM JST Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: In practice, it is easy to construct a set of requirements such that multiple classes match, with any of present==FALSE, UnitClassFlag restrictions, lack of specification of any aspect of unit class, etc. As a result of this limited understanding, the AI may misestimate the value of any city improvement that provides EFT_MOVE_BONUS, EFT_HP_REGEN, EFT_VETERAN_COMBAT, EFT_VETERAN_BUILD, EFT_BRIBE_COST_PERCENT, or EFT_DEFEND_BONUS if the requirements for those effects are constructed to match more than one but less than all unit classes. ___ Reply to this item at: http://gna.org/bugs/?21991 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4679] Remove nreqs support entirely
URL: http://gna.org/patch/?4679 Summary: Remove nreqs support entirely Project: Freeciv Submitted by: persia Submitted on: Wed 30 Apr 2014 01:01:42 PM JST Category: general Priority: 5 - Normal Status: Need Info Privacy: Public Assigned to: persia Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: As nreqs are no longer used in the default rulesets, there is no reason to continue having engine support. The attached patch removes it all, leaving a ruleset error on ruleset load if a ruleset uses nreqs (the network capstring is known wrong, but I didn't want to forget adding it later). I'm not entirely happy with the construction I used to test for the presence of nreqs in the ruleset: suggestions for a better implementation (not using reqs-size, which ought be private) welcomed. This patch has not been extensively tested: it is posted more for review for completeness and verification of the intent than as a direct commit candidate. I'm confident there will need to be changes before application (for example, I doubt I removed enough code from ruledit). ___ File Attachments: --- Date: Wed 30 Apr 2014 01:01:42 PM JST Name: remove-nreqs-support.patch Size: 17kB By: persia http://gna.org/patch/download.php?file_id=20616 ___ Reply to this item at: http://gna.org/patch/?4679 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements
URL: http://gna.org/bugs/?21992 Summary: Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements Project: Freeciv Submitted by: persia Submitted on: Wed 30 Apr 2014 01:11:19 PM JST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: In the absence of nreqs(), is_improvement_redundant fails to determine if a given improvement is not providing any useful effect (or cannot provide any useful effect in the future). This is most obviously visible as a lack of strikethrough in worklist management, but may also cause the AI to desire useless buildings. ___ Reply to this item at: http://gna.org/bugs/?21992 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably
Update of bug #21115 (project freeciv): Depends on: = bugs #21992 ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably
Follow-up Comment #18, bug #21115 (project freeciv): And I've completed the review of my rebase, with the following results: (1) was mitigated with patch #4451, but has other issues. Bug #21991 raised for that, but not a dependency of this bug, as the issue is more general than just present==FALSE. (2) is ideally a no-op given empty nreqs. Included in the wider patch #4679 (which is mostly irrelevant to present==FALSE, except for one comment change, and the underlying motivation) During preparation of patch #4679, found another case of dependency on nreqs, rather than wider requirement processing, raised as bug #21992 (which this depends upon). (3) patch #4451 addressed this in a better way (although not textually near my earlier changes) (4) root issue raised as bug #21982 (dependency of this bug) I did not find anything else in my prior notes that appears to remain unaddressed by the current codebase. ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev