[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format
Follow-up Comment #2, bug #21444 (project freeciv):
I have also noticed in file #22111 things like:
diplstate={type,max_state,first_contact_turn,turns_left,has_reason_to_cancel,contact_turns_left,embassy,gives_shared_vision
5,5,0,0,0,0,FALSE,FALSE
1,5,2,0,0,20,FALSE,FALSE
1,5,5,0,0,16,FALSE,FALSE
1,5,12,0,0,0,FALSE,FALSE
1,5,3,0,0,13,FALSE,FALSE
}
diplstate6.type=5
diplstate6.max_state=5
diplstate6.first_contact_turn=0
diplstate6.turns_left=0
diplstate6.has_reason_to_cancel=0
diplstate6.contact_turns_left=0
diplstate6.embassy=FALSE
diplstate6.gives_shared_vision=FALSE
___
Reply to this item at:
http://gna.org/bugs/?21444
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4694] Remove game_unit_by_number() usage in unit_transport_get()
Update of patch #4694 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #4: About unit_transport_check(), see bug #22050. ___ Reply to this item at: http://gna.org/patch/?4694 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4729] genhash: calculate hash values without the number of buckets
Update of patch #4729 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4729 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4731] genhash/genlist: remove default functions
Update of patch #4731 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4731 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4728] research_players_iterate macro
Update of patch #4728 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4728 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22122] trunk autogames not reproducible
Update of bug #22122 (project freeciv): Assigned to:None = jtn ___ Follow-up Comment #7: gameseed is too high Sigh. It's right there in my log, too, if only I'd thought to look. I'll confirm that autogames with legal settings are fine, then close this. Sorry for the noise. ___ Reply to this item at: http://gna.org/bugs/?22122 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22050] Recursive transport problems
Follow-up Comment #6, bug #22050 (project freeciv): The tests didn't pass. My patch doesn't fix all problems. Attaching new version: * unit_transport_check() also check cargo of the cargo unit (because some transported units also could be incompatible with one of the transport) ; * Check GAME_TRANSPORT_MAX_RECURSIVE taking in account the cargo depth of the cargo unit. (file #20907) ___ Additional Item Attachment: File name: recursive_transport3.patch Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?22050 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22126] AI traits valgrind errors
URL: http://gna.org/bugs/?22126 Summary: AI traits valgrind errors Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 11:32:03 AM CEST Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r25014 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Observed for trunk server, I didn't check other branches: ==21633== Invalid write of size 4 ==21633==at 0x4BBC27: ruleset_load_traits (ruleset.c:1072) ==21633==by 0x4C5E32: load_ruleset_nations (ruleset.c:4132) ==21633==by 0x4CB8D4: load_rulesetdir (ruleset.c:6523) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== Address 0xe6bd05c is 0 bytes after a block of size 12 alloc'd ==21633==at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21633==by 0x645E61: fc_real_malloc (mem.c:84) ==21633==by 0x645F74: fc_real_calloc (mem.c:129) ==21633==by 0x5783CC: nations_alloc (nation.c:604) ==21633==by 0x431382: load_nation_names (ruleset.c:3580) ==21633==by 0x4C8922: load_rulesetdir (ruleset.c:6498) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== ==21633== Invalid write of size 4 ==21633==at 0x4BBC09: ruleset_load_traits (ruleset.c:1068) ==21633==by 0x4C5E32: load_ruleset_nations (ruleset.c:4132) ==21633==by 0x4CB8D4: load_rulesetdir (ruleset.c:6523) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== Address 0xe6bd060 is 4 bytes after a block of size 12 alloc'd ==21633==at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21633==by 0x645E61: fc_real_malloc (mem.c:84) ==21633==by 0x645F74: fc_real_calloc (mem.c:129) ==21633==by 0x5783CC: nations_alloc (nation.c:604) ==21633==by 0x431382: load_nation_names (ruleset.c:3580) ==21633==by 0x4C8922: load_rulesetdir (ruleset.c:6498) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== ==21633== Invalid read of size 4 ==21633==at 0x4C6134: load_ruleset_nations (ruleset.c:4137) ==21633==by 0x4CB8D4: load_rulesetdir (ruleset.c:6523) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== Address 0xe6bd05c is 0 bytes after a block of size 12 alloc'd ==21633==at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21633==by 0x645E61: fc_real_malloc (mem.c:84) ==21633==by 0x645F74: fc_real_calloc (mem.c:129) ==21633==by 0x5783CC: nations_alloc (nation.c:604) ==21633==by 0x431382: load_nation_names (ruleset.c:3580) ==21633==by 0x4C8922: load_rulesetdir (ruleset.c:6498) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== ==21633== Invalid write of size 4 ==21633==at 0x4C6146: load_ruleset_nations (ruleset.c:4138) ==21633==by 0x4CB8D4: load_rulesetdir (ruleset.c:6523) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== Address 0xe6bd05c is 0 bytes after a block of size 12 alloc'd ==21633==at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21633==by 0x645E61: fc_real_malloc (mem.c:84) ==21633==by 0x645F74: fc_real_calloc (mem.c:129) ==21633==by 0x5783CC: nations_alloc (nation.c:604) ==21633==by 0x431382: load_nation_names (ruleset.c:3580) ==21633==by 0x4C8922: load_rulesetdir (ruleset.c:6498) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== ==21633== Invalid read of size 4 ==21633==at 0x4C6154: load_ruleset_nations (ruleset.c:4138) ==21633==by 0x4CB8D4: load_rulesetdir (ruleset.c:6523) ==21633==by 0x4CCA5C: load_rulesets (ruleset.c:6394) ==21633==by 0x43A6FA: srv_main (srv_main.c:2536) ==21633==by 0x432C41: main (civserver.c:454) ==21633== Address 0xe6bd05c is 0 bytes after a block of size 12 alloc'd ==21633==at 0x4C2B6CD: malloc (in
[Freeciv-Dev] [patch #4768] Pathfinding: node behavior optimization
URL: http://gna.org/patch/?4768 Summary: Pathfinding: node behavior optimization Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 11:48:15 AM CEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: * TB_NORMAL is set to zero ; * can_invade is suppressed. If the can_invade_tile callback returns FALSE, then the behavior is overwritten with TB_IGNORE ; * in pf_XXX_node_init(), returns immediately if we cannot enter the node at all. ___ File Attachments: --- Date: Mon 02 Jun 2014 11:48:15 AM CEST Name: pf_node_init.patch Size: 12kB By: pepeto http://gna.org/patch/download.php?file_id=20908 ___ Reply to this item at: http://gna.org/patch/?4768 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22122] trunk autogames not reproducible
Update of bug #22122 (project freeciv): Status:None = Invalid Open/Closed:Open = Closed ___ Follow-up Comment #8: Haven't thoroughly tested yet, but the two games of the test I originally intended to run have started out the same, so I'm going to close this as user error. ___ Reply to this item at: http://gna.org/bugs/?22122 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.5 Release Goals
On 6 April 2014 23:26, Marko Lindqvist cazf...@gmail.com wrote: On 6 April 2014 17:43, Jacob Nevins 0jacobnk.fc...@chiark.greenend.org.uk wrote: Months ago (on 3 Jan), Marko Lindqvist wrote: patch #4190: Split translations to multiple po-files If we are going to add information about what translation domain translations about the nation should be fetched to the rulesets, it must be done before datafile format freeze. This has been implemented to the extend I dreamed about, but the ticket has been given to jtn to further evaluate what more is needed. ? I don't now expect to implement anything like the full madness of http://gna.org/patch/download.php?file_id=19163, but there's still a minimal level of work required in defining a suitable workflow for importing translations, updating freeciv.pot, updating po-files, etc in a world with multiple translation domains. (This is quite high-priority, because it's indirectly retarding translator work on S2_5 and later.) To be honest I see only two problems regarding 2.5 implementation. Of those, the only technical one, is that some titles might appear as strings in both domains, requiring translation twice. However, number of those strings is very low in the big picture, and that mainly affects only new translations in 2.5 - Migration of existing translations from S2_4 places the translation to both domains. The other problem is lack of documentation about migrating translations from S2_4 to S2_5, and about translating S2_5. But given that currently almost no translator commits translations themselves, this is not a big issue, and in any case would not need code changes, but just instructions sent to i18n list and probably some wiki updates (about translation work in S2_5 and later). Qt-client Qt-client is coming along so well that it would be a shame not to get it to supported client status in 2.5. Mir3x probably keeps on working on Qt4 based version. Qt5 now. I haven't been keeping on top of the Qt client. Is there a description of the major missing features at the moment? Perhaps we need a metaticket? We have metaticket patch #4417, but it doesn't have much content - I have had only a couple short sessions with Qt-client so not explored what it absolutely still needs. It will most likely keep its experimental status in 2.5. New Qt-client related item is that I'd want freeciv-mp-qt to be in good enough shape to be used in those installations that use Qt-client, so one does not need to mix gtk-based freeciv-mp-gtk[23] to Qt system. I'm working on this. Mostly done Done? I'm not completely satisfied with the quality. Still not completely satisfactory, but not needed if Qt-client does not make it. patch #3448: Nation sets: allow set of nations that will ever appear in-game to be chosen Affects both network protocol and ruleset format, I think. There has been some progress. If I have understood correctly all that is missing is support from some of the clients. That shouldn't stop us from going toward beta (no network protocol issues, I assume) That's about right. With the Gtk clients, I consider the feature complete. However, I'm keen that every supported client should have a UI for this feature, even if a minimal one. Otherwise, all the nations maintainers' hard work on the extended nation set becomes completely invisible to casual users of that client, which was something I explicitly wanted to avoid when creating two tiers of nations. Help in this area would be appreciated. In particular, I've not done any Qt hacking, so if someone else could add support to the Qt client, that would be great. http://gna.org/patch/?4350 Qt client support for nation sets The SDL client should also have support. I'd be content with minimal support to start with (add a drop-down, but if you change it the nations dialog pops down -- this would save some fiddly widget-wrangling). http://gna.org/patch/?4351 SDL client support for nation sets Again, if Qt-client is not going to make it as a whole, missing this one particular feature is not an issue. I have this in my personal TODO notes in the roadmap of sdl2-client development (I expect to learn more of the sdl(2)-client widget code by doing other tasks before trying to tackle this) I think I can get to actual implementation soon. I already committed one patch improving things a bit gtk3-client as default Gtk3-client is default client in 2.5. Its remaining issues should be resolved that it would be worthy of that status. There's windows version available now, but it has performance issues. It would be nice to get it tested in betas, but not going to put beta1 to who-knows-how-long wait for this. Blocking final 2.5.0, though. http://gna.org/task/?7760 lists possible blockers to Gtk3 as default client. Many are still open. Not on the list is improvement of the Gtk3 custom theme, but that's actually what's been
[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets
Update of patch #4734 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4734 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22110] Border claiming base activity based on tile, not base, ownership
Update of bug #22110 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22110 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4748] TRUNK windows followtag to win32-S2_6
Update of patch #4748 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4748 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development
Additional Item Attachment, patch #4759 (project freeciv): File name: 3.0Trunk.patch Size:9 KB ___ Reply to this item at: http://gna.org/patch/?4759 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22127] BUGS claim that 2.4 is still in alpha
URL: http://gna.org/bugs/?22127 Summary: BUGS claim that 2.4 is still in alpha Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Jun 2014 09:44:11 PM EEST Category: docs Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.3, 2.5.0-beta1 ___ Details: doc/BUGS for S2_4: Freeciv 2.3.99 is an alpha release Also S2_5 should be changed too, maybe as part of beta1 release process? (or immediately as it's beta build mode already) ___ Reply to this item at: http://gna.org/bugs/?22127 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4760] First commit to S2_6
Additional Item Attachment, patch #4760 (project freeciv): File name: S2_6Alpha.patchSize:0 KB ___ Reply to this item at: http://gna.org/patch/?4760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4769] PACKET_RESEARCH_INFO
URL: http://gna.org/patch/?4769 Summary: PACKET_RESEARCH_INFO Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 10:09:53 PM CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add a packet named research_info, and remove duplicates in player_info packet. Need network capability string refresh when applying. ___ File Attachments: --- Date: Mon 02 Jun 2014 10:09:53 PM CEST Name: packet_research_info.patch.gz Size: 6kB By: pepeto http://gna.org/patch/download.php?file_id=20911 ___ Reply to this item at: http://gna.org/patch/?4769 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up
Update of patch #4726 (project freeciv): Depends on: = patch #4769 ___ Reply to this item at: http://gna.org/patch/?4726 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
URL: http://gna.org/bugs/?22129 Summary: sdl-client compile fails Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Jun 2014 11:48:00 PM EEST Category: client-sdl Severity: 3 - Normal Priority: 9 - Immediate Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: TRUNK build with all clients says: client/gui-sdl/repodlgs.c: In function 'real_science_report_dialog_update': client/gui-sdl/repodlgs.c:2638:25: error: expected ')' before ';' token / cost); ... Who ever can fix this may commit the fix immediately as build fix (I'm currently tied to other things, but will check it later if still not fixed then) ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
Follow-up Comment #1, bug #22129 (project freeciv): Also Qt-client fails to build: client/gui-qt/plrdlg.cpp: In member function 'void plr_widget::nation_selected(const QItemSelection, const QItemSelection)': client/gui-qt/plrdlg.cpp:359:41: error: 'player_research_get' was not declared in this scope research = player_research_get(pplayer); ... ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
Update of bug #22129 (project freeciv): Status:None = In Progress Assigned to:None = jtn ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
Follow-up Comment #2, bug #22129 (project freeciv): SDL/SDL2 fixes attached, will commit immediately. (Can't try compiling SDL2 myself but it looks like it needs an identical fix.) (file #20913) ___ Additional Item Attachment: File name: trunk-sdl-research-compile-fix.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
Follow-up Comment #3, bug #22129 (project freeciv): (introduced in patch #4727) ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22129] sdl-client compile fails
Follow-up Comment #5, bug #22129 (project freeciv): Qt fix. (I'm guessing a grep that failed to search *.cpp.) (file #20914) ___ Additional Item Attachment: File name: trunk-qt-research-compile-fix.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?22129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22085] civ2: reduce max trade routes from 4 to 3
Update of bug #22085 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22085 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22080] Non-cumulative Barracks effects not right wrt building redundancy
Update of bug #22080 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22080 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22083] apply_disaster() can reference city after it's freed
Update of bug #22083 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22083 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements
Follow-up Comment #3, bug #21992 (project freeciv): (I suspect this isn't amenable to autogame testing, since the AI is expected to improve. Probably the correct test is against unmodified code and nreqs-based ruleset.) Tested unmodified code with patch #4411 reverted (i.e. with nreqs) against patched code with current classic ruleset (with present=FALSE). Diverged at turn 36 when AI decided to build Great Library instead of Great Wall :( Don't think this should happen, so holding patch back for now. Fixed code with nreqs ruleset behaved the same as unfixed code with nreqs, interestingly. Might run a couple of repeat autogames to rule out unrelated nondeterminism. (I double-checked patch #4411 itself, and didn't spot any semantic changes.) ___ Reply to this item at: http://gna.org/bugs/?21992 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22076] Breakage with --as-needed linker flag
Update of bug #22076 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22076 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19859] Server fails to find rl_attempted_completion_function
Update of bug #19859 (project freeciv): Status:None = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #12: Bug #22076 was about linking readline to binary instead of libfreeciv-srv. That would fit the --enable-shared comment here, as without it binary contains libfreeciv-srv (as static library). Thus assuming now fixed. Feel free to reopen. ___ Reply to this item at: http://gna.org/bugs/?19859 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements
Follow-up Comment #4, bug #21992 (project freeciv): AI *is* handling nreqs and present=FALSE differently when evaluating effects provided by building to build. Evaluation of present=FALSE should be improvement over nreqs. nreqs are not evaluated at all, as they are never included to the cache. present=FALSE effects are evaluated, and can provide either positive or negative value for the building. Your case sounds like it used to ignore the fact that normal City Walls make Great Wall redundant, but with present=FALSE it notices that Great Wall would not provide extra value. ___ Reply to this item at: http://gna.org/bugs/?21992 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4752] Remove unused imlib.m4
Update of patch #4752 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4752 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements
Follow-up Comment #5, bug #21992 (project freeciv): Oh! Of course, I forgot to think about the effects of moving to reqs outside my change. Thanks. My other test indicates that I've caused no obvious regressions, and review time's up, so in it goes. What about making present tri-state value, with one value being equivalent to current TRUE, and the other two being like current FALSE but one indicating replacement and the other prevention? Ah, yes, that's a better idea than keeping nreqs, if we need it. Any more thoughts in that direction should go to a new ticket. ___ Reply to this item at: http://gna.org/bugs/?21992 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements
Update of bug #21992 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21992 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4746] Lua function to get terrain class of terrain
Update of patch #4746 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4746 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22076] Breakage with --as-needed linker flag
Follow-up Comment #6, bug #22076 (project freeciv): (For the record, I found I had to make clean after updating my checkout with this change. Built fine after that.) ___ Reply to this item at: http://gna.org/bugs/?22076 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22106] Netfile dummy_write() return value assumes size unit to be single byte
Update of bug #22106 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22106 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0
Follow-up Comment #3, patch #3793 (project freeciv): Help on Combat needs an overhaul in light of the combat bonuses framework (patch #3548). Various references in helpdata.txt to 'default ruleset'. Should probably now refer to 'classic ruleset'. ___ Reply to this item at: http://gna.org/patch/?3793 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4743] Don't allow removal of advances in use
Update of patch #4743 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4770] Consider effect requiremens to be universals in use
URL: http://gna.org/patch/?4770 Summary: Consider effect requiremens to be universals in use Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Jun 2014 03:49:08 AM EEST Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Check effect reqs and nreqs when determining if universal is being used by the ruleset. Currently this affects only whether editor allows removal of an tech from the ruleset. ___ File Attachments: --- Date: Tue 03 Jun 2014 03:49:08 AM EEST Name: RemovalEffectValidity.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=20915 ___ Reply to this item at: http://gna.org/patch/?4770 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4771] Projectinfo -file
URL: http://gna.org/patch/?4771 Summary: Projectinfo -file Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Jun 2014 04:15:50 AM EEST Category: bootstrap Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: jtn's comment on patch #4735: I think it's a good idea. It makes it easier for someone to fork Freeciv to a specialised variant without dependencies on our project infrastructure. That got me thinking that we should have a single file defining project info, or just infra references at first phase, and configure option --with-projectinfo. Then building freeciv that uses another infra would be matter of just defining suitable projectinfo -file and configuring freeciv build to use that file. ___ Reply to this item at: http://gna.org/patch/?4771 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3926] Make it easier for users to locally add a custom nation to the default set
Update of patch #3926 (project freeciv): Status: Need Info = Ready For Test Planned Release: 2.5.0,2.6.0 = 2.6.0 ___ Follow-up Comment #5: I remember being strongly against this for it being fundamentally flawed, but after thinking it through myself and coming to same conclusion semantically different way made me supporter of the idea. The main difference is that I now don't expect user to find the files to be overridden and start hacking them (actions that require almost equal skill to adding nation without this change) but just to drop the replacements in place. Attached patch adds data/override -directory containing empty nation.ruleset (included from default/nationlist.ruleset), flags.spec, flags-large.spec, shields.spec, and shields-large.spec (all included from respective .spec files). (file #20916) ___ Additional Item Attachment: File name: NationOverride.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?3926 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
