[Freeciv-Dev] [bug #22236] Flag swapping for Barbarians Pirates ?

2014-06-24 Thread anonymous
URL:
  http://gna.org/bugs/?22236

 Summary: Flag swapping for Barbarians  Pirates ?
 Project: Freeciv
Submitted by: None
Submitted on: mar. 24 juin 2014 06:06:48 UTC
Category: art
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: ig...@hotmail.com
 Open/Closed: Open
 Release: 2.x at least
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

When you Google for pirate flag, you will see the Jolly Roger, that we use
for the Barbarian flag (data/flags/barbarian.svg).
On the other hand, the current pirate flag (data/flags/pirate.svg) would suit
a barbarian nation IMHO...

= Shouldn't we swap those flags ? (data/flags/pirate* -
data/flags/barbarian*)





___

Reply to this item at:

  http://gna.org/bugs/?22236

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4851] Worker task protocol

2014-06-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?4851

 Summary: Worker task protocol
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 24 Jun 2014 09:25:22 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This patch adds protocol changes to send worker tasks from client to server
and back (as an confirmation, later also when loading them from saved game).

Worker task is concept first introduced for threaded AI. There can be one
(maybe list in the future) task for autosettlers associated for each city.
When it's time for autosettlers to act, these tasks take highest priority.

This patch is tested using minimal proof-of-concept gtk3-client gui to set
worker task, but that's not going to be part of this ticket.



___

File Attachments:


---
Date: Tue 24 Jun 2014 09:25:22 AM EEST  Name: WorkerTaskProtocol.patch  Size:
6kB   By: cazfi

http://gna.org/patch/download.php?file_id=21142

___

Reply to this item at:

  http://gna.org/patch/?4851

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [Freeciv-commits] r25261 - /trunk/ai/default/aiunit.c

2014-06-24 Thread Marko Lindqvist
On 24 June 2014 22:33,  per...@shipstone.jp wrote:
 Author: persia
 Date: Tue Jun 24 21:33:48 2014
 New Revision: 25261

 URL: http://svn.gna.org/viewcvs/freeciv?rev=25261view=rev
 Log:
 Cleanups in dai_is_unit_tired_waiting_boat()

 * Fix home continent test to check continent rather than tile

 Isn't that a bug in S2_5 also?


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22232] Rulesave fails to save pythagorean_diagnonal==FALSE for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources

2014-06-24 Thread Emmet Hikory
Update of bug #22232 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22232

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4837] Use pathfinding to identify missile carrier risk

2014-06-24 Thread Emmet Hikory
Update of patch #4837 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4837

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4838] Use UTYF_BADCITYDEFENDER in process_defender_want()

2014-06-24 Thread Emmet Hikory
Update of patch #4838 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4838

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4839] Cleanups in dai_is_unit_tired_waiting_boat()

2014-06-24 Thread Emmet Hikory
Follow-up Comment #2, patch #4839 (project freeciv):

Unfortunately, as I was doing my post-commit cleanup, I noticed that I
reversed the logical test with this patch.  Attached is another patch that
fixes that.

(file #21144)
___

Additional Item Attachment:

File name: fix-reversed-logic-in-dai_is_unit_tired_waiting_boat.patch Size:1
KB


___

Reply to this item at:

  http://gna.org/patch/?4839

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4841] Consider defense effects for any defender

2014-06-24 Thread Emmet Hikory
Update of patch #4841 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4841

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4836] Ignore nativity-providing extras for simple types

2014-06-24 Thread Emmet Hikory
Update of patch #4836 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4836

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3279] Rusyn nation

2014-06-24 Thread Jacob Nevins
Follow-up Comment #3, patch #3279 (project freeciv):

r23250 http://svn.gna.org/viewcvs/freeciv?revision=23250view=revision,
which added the Rusyn nation, also renamed the Ruthenians to the Kievan Rus'.

See bug #22235 for some fixup we'll have to do for that, for backward
compatibility.

Is there likely to be a forthcoming real Ruthenian ruleset, or is the term
Ruthenian too imprecise?
(Patch #1496 is where ruthenian.ruleset was originally added, and has some
more discussion.)

___

Reply to this item at:

  http://gna.org/patch/?3279

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22237] dai_is_unit_tired_waiting_boat() checks tile identity rather than continent identity

2014-06-24 Thread Emmet Hikory
URL:
  http://gna.org/bugs/?22237

 Summary: dai_is_unit_tired_waiting_boat() checks tile
identity rather than continent identity
 Project: Freeciv
Submitted by: persia
Submitted on: Wed 25 Jun 2014 05:08:36 AM JST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: persia
Originator Email: 
 Open/Closed: Open
 Release: r25255 (S2_5)
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

Discovered while working on patch #4839 (and fixed in trunk there),
dai_is_unit_tired_waiting_boat() has a commented conditional that is intended
to check if the unit is on it's home continent, which instead checks to see if
the unit is in it's home city.

The attached patch extracts only the bugfix from the trunk patch, for
application to S2_5.



___

File Attachments:


---
Date: Wed 25 Jun 2014 05:08:36 AM JST  Name:
fix-home-continent-test-to-check-continent-rather-than-tile.patch  Size: 742B 
 By: persia

http://gna.org/bugs/download.php?file_id=21146

___

Reply to this item at:

  http://gna.org/bugs/?22237

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [Freeciv-commits] r25261 - /trunk/ai/default/aiunit.c

2014-06-24 Thread Emmet Hikory
Marko Lindqvist wrote:
 On 24 June 2014 22:33,  per...@shipstone.jp wrote:
  Author: persia
  Date: Tue Jun 24 21:33:48 2014
  New Revision: 25261
 
  URL: http://svn.gna.org/viewcvs/freeciv?rev=25261view=rev
  Log:
  Cleanups in dai_is_unit_tired_waiting_boat()
 
  * Fix home continent test to check continent rather than tile
 
  Isn't that a bug in S2_5 also?

Indeed it is: bugfix only patch attached to bug #22237

-- 
Emmet HIKORY

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4799] Unhardcode IgWall

2014-06-24 Thread Marko Lindqvist
Follow-up Comment #4, patch #4799 (project freeciv):

- Changes needed to stub ruleset

(file #21147)
___

Additional Item Attachment:

File name: IgWallRm-4.patch.bz2   Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?4799

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22238] civ2civ3: buildings with old obsolete_by syntax

2014-06-24 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22238

 Summary: civ2civ3: buildings with old obsolete_by syntax
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed 25 Jun 2014 00:17:54 BST
Category: rulesets
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: trunk r25262
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0

___

Details:

Running server with -d 3 showed that Women's Suffrage and Coinage still have
old pre-requirements 'obsolete_by = None' syntax.

Perhaps this should be a harder error? It showed up as follows. Another ticket
if so.


3: Unused entries in file data/civ2civ3/buildings.ruleset:
3:   unused entry: building_womens_suffrage.obsolete_by
3:   unused entry: building_capitalization.obsolete_by





___

Reply to this item at:

  http://gna.org/bugs/?22238

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22235] Add rule_name for ruthenian.ruleset (now Kievan Rus')

2014-06-24 Thread Jacob Nevins
Update of bug #22235 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-kievan-rus-rule-name-bis.patch Size:5 KB


___

Reply to this item at:

  http://gna.org/bugs/?22235

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4292] Formosan nation

2014-06-24 Thread Jacob Nevins
Follow-up Comment #2, patch #4292 (project freeciv):

The legend for this nation has missing spaces at line wraps, so comes out
wrong. Patch attached.

(file #21149)
___

Additional Item Attachment:

File name: trunk-formosan-legend.patchSize:1 KB


___

Reply to this item at:

  http://gna.org/patch/?4292

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3318] Lycian nation

2014-06-24 Thread Jacob Nevins
Follow-up Comment #3, patch #3318 (project freeciv):

Attached patch comments out Lydian civilwar_nation (not yet added: patch
#3423) to avoid a warning at -d 3 level.

(file #21150)
___

Additional Item Attachment:

File name: trunk-lycian-civilwar.patchSize:0 KB


___

Reply to this item at:

  http://gna.org/patch/?3318

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22238] civ2civ3: buildings with old obsolete_by syntax

2014-06-24 Thread Jacob Nevins
Update of bug #22238 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-civ2civ3-obsoleteby.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?22238

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev