[Freeciv-Dev] [patch #4853] Gen-move support for autoexplorers

2014-06-28 Thread Emmet Hikory
Update of patch #4853 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4852] Clean up flag restriction documentation

2014-06-28 Thread Emmet Hikory
Update of patch #4852 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4854] Un-hardcode safe house discovery

2014-06-28 Thread Emmet Hikory
Update of patch #4854 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4855] Allow amphibious unit for kill_something_with()

2014-06-28 Thread Emmet Hikory
Update of patch #4855 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4856] Remove unused AI channel cache

2014-06-28 Thread Emmet Hikory
Update of patch #4856 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4858] Use terrain_class rather than move_type in AI

2014-06-28 Thread Emmet Hikory
Update of patch #4858 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4857] Move tech_want data to default AI

2014-06-28 Thread Emmet Hikory
Follow-up Comment #1, patch #4857 (project freeciv): The civil war chunks seem out of place here, but useful anyway: no reason for a new patch, but if they belong somewhere else, maybe adjust? ___ Reply to this item at:

[Freeciv-Dev] [patch #4861] Allow Ferryboat as a starting unit

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4861 Summary: Allow Ferryboat as a starting unit Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 06:45:33 PM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4862] Use common ferry function for settler ferry check

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4862 Summary: Use common ferry function for settler ferry check Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 06:47:58 PM JST Category: ai Priority: 5 -

[Freeciv-Dev] [patch #4863] Validate boats are sea capable by terrain iteration

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4863 Summary: Validate boats are sea capable by terrain iteration Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 06:52:27 PM JST Category: general Priority:

[Freeciv-Dev] [patch #4864] Distance-based calculation for meeting charges

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4864 Summary: Distance-based calculation for meeting charges Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 07:01:38 PM JST Category: ai Priority: 5 - Normal

[Freeciv-Dev] [patch #4865] Consolidate move_type usage and move more usage to client

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4865 Summary: Consolidate move_type usage and move more usage to client Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 07:09:53 PM JST Category: general

[Freeciv-Dev] [patch #4866] Provide alternate semantics to the client to replace move_type

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4866 Summary: Provide alternate semantics to the client to replace move_type Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 07:18:56 PM JST Category: client

[Freeciv-Dev] [patch #3721] Getting rid of move_type dependency on unitselect dialog

2014-06-28 Thread Emmet Hikory
Follow-up Comment #6, patch #3721 (project freeciv): One of the patches in patch #4866 provides a new ruleset field (unit class group) that could be used for this purpose, if there is interest in that sort of solution (as hinted at the end of the original submission).

[Freeciv-Dev] [patch #4866] Provide alternate semantics to the client to replace move_type

2014-06-28 Thread Emmet Hikory
Update of patch #4866 (project freeciv): Depends on: = patch #4865 ___ Reply to this item at: http://gna.org/patch/?4866 ___ Message sent

[Freeciv-Dev] [patch #4865] Consolidate move_type usage and move more usage to client

2014-06-28 Thread Emmet Hikory
Update of patch #4865 (project freeciv): Depends on: = patch #4861 ___ Reply to this item at: http://gna.org/patch/?4865 ___ Message sent

[Freeciv-Dev] [patch #4865] Consolidate move_type usage and move more usage to client

2014-06-28 Thread Emmet Hikory
Update of patch #4865 (project freeciv): Depends on: = patch #4863 ___ Reply to this item at: http://gna.org/patch/?4865 ___ Message sent

[Freeciv-Dev] [patch #4865] Consolidate move_type usage and move more usage to client

2014-06-28 Thread Emmet Hikory
Update of patch #4865 (project freeciv): Depends on: = patch #4864 ___ Reply to this item at: http://gna.org/patch/?4865 ___ Message sent

[Freeciv-Dev] [patch #4867] Quickselect should not depend on move_type

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4867 Summary: Quickselect should not depend on move_type Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 07:59:59 PM JST Category: client Priority: 5 - Normal

[Freeciv-Dev] [patch #4868] Don't use move_type to set colors in Qt client city production painting

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4868 Summary: Don't use move_type to set colors in Qt client city production painting Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 08:04:01 PM JST Category: client-qt

[Freeciv-Dev] [patch #4869] Remove move_type from the client

2014-06-28 Thread Emmet Hikory
URL: http://gna.org/patch/?4869 Summary: Remove move_type from the client Project: Freeciv Submitted by: persia Submitted on: Sat 28 Jun 2014 08:16:38 PM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4869] Remove move_type from the client

2014-06-28 Thread Emmet Hikory
Update of patch #4869 (project freeciv): Depends on: = patch #3721 ___ Reply to this item at: http://gna.org/patch/?4869 ___ Message sent

[Freeciv-Dev] [patch #4869] Remove move_type from the client

2014-06-28 Thread Emmet Hikory
Update of patch #4869 (project freeciv): Depends on: = patch #4866 ___ Reply to this item at: http://gna.org/patch/?4869 ___ Message sent

[Freeciv-Dev] [bug #22241] Nation help uses rule name, not translated name

2014-06-28 Thread Jacob Nevins
URL: http://gna.org/bugs/?22241 Summary: Nation help uses rule name, not translated name Project: Freeciv Submitted by: jtn Submitted on: Sat 28 Jun 2014 12:41:27 BST Category: client Severity: 3 - Normal

[Freeciv-Dev] [task #7808] Backport nations from trunk to S2_5

2014-06-28 Thread Jacob Nevins
Update of task #7808 (project freeciv): Should be Finished on: Mon 30 Jun 2014 00:00:00 BST = Sat 28 Jun 2014 00:00:00 BST Status: Ready For Test = Done Percent Complete: 80% = 100%

[Freeciv-Dev] [bug #22241] Nation help uses rule name, not translated name

2014-06-28 Thread Jacob Nevins
Update of bug #22241 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-help-nation-translation.patch Size:4 KB File name:

[Freeciv-Dev] [patch #4822] Use requirements_vector for effects

2014-06-28 Thread Emmet Hikory
Update of patch #4822 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4821] Do not consider harmless units in assess_danger()

2014-06-28 Thread Emmet Hikory
Update of patch #4821 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4852] Clean up flag restriction documentation

2014-06-28 Thread Jacob Nevins
Follow-up Comment #3, patch #4852 (project freeciv): In S2_5, Airbase became a userflag. (Actually this was in 2009; patch #1205.) ___ Reply to this item at: http://gna.org/patch/?4852 ___

[Freeciv-Dev] [patch #4852] Clean up flag restriction documentation

2014-06-28 Thread Emmet Hikory
Follow-up Comment #4, patch #4852 (project freeciv): Do you think it's worth pushing this to S2_4 as well? ___ Reply to this item at: http://gna.org/patch/?4852 ___ Message sent via/by Gna!

[Freeciv-Dev] [patch #4830] Multipliers to effects

2014-06-28 Thread SÅ‚awomir Lach
Follow-up Comment #11, patch #4830 (project freeciv): Patch version, which adds multipliers to help dialog. Setting two variables in ruleset_free(game.c) to zero is needed for cleanup purposes. If we don't do that, then in special cases (for example ruleset was loaded many times) we can't load

[Freeciv-Dev] [patch #1341] Replace Improvement replaced_by with a requirements vector

2014-06-28 Thread Emmet Hikory
Update of patch #1341 (project freeciv): Status:None = Ready For Test Assigned to:None = persia Planned Release: = 2.6.0 Summary:

[Freeciv-Dev] [patch #4830] Multipliers to effects

2014-06-28 Thread Emmet Hikory
Follow-up Comment #12, patch #4830 (project freeciv): On the global variables: I agree they are needed for cleanup purposes, but I still think they should be scoped to multipliers.c. Consider adding helper functions to game_ruleset_init() and game_ruleset_free() that operate on static variables

[Freeciv-Dev] [patch #4789] allow_holes settings for tech loss

2014-06-28 Thread Jacob Nevins
Update of patch #4789 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.6.0

[Freeciv-Dev] [patch #4857] Move tech_want data to default AI

2014-06-28 Thread Marko Lindqvist
Follow-up Comment #2, patch #4857 (project freeciv): The AI callback API change was already in separate patch. Do you want also the tech_want copying from player to player to be moved from server/plrhand.c to new callback in separate patch before this (and then just adjusted with this patch)?

[Freeciv-Dev] [bug #22243] City with more than max trade routes can't change them

2014-06-28 Thread Jacob Nevins
URL: http://gna.org/bugs/?22243 Summary: City with more than max trade routes can't change them Project: Freeciv Submitted by: jtn Submitted on: Sat 28 Jun 2014 22:16:11 BST Category: None Severity: 2 -

[Freeciv-Dev] [bug #22244] Illegal trade route Active setting counterintuitive

2014-06-28 Thread Jacob Nevins
URL: http://gna.org/bugs/?22244 Summary: Illegal trade route Active setting counterintuitive Project: Freeciv Submitted by: jtn Submitted on: Sat 28 Jun 2014 22:32:08 BST Category: docs Severity: 3 -

[Freeciv-Dev] [bug #22244] Illegal trade route Active setting counterintuitive

2014-06-28 Thread Jacob Nevins
Follow-up Comment #1, bug #22244 (project freeciv): (this being the setting added in patch #3611) ___ Reply to this item at: http://gna.org/bugs/?22244 ___ Message sent via/by Gna!

[Freeciv-Dev] [bug #22243] City with more than max trade routes can't change them

2014-06-28 Thread Jacob Nevins
Follow-up Comment #1, bug #22243 (project freeciv): Also, can_establish_trade_route() checks for ==max, so currently gives the wrong answer in the face of excess routes. It should be updated for whatever the conclusion of this is. (establish_trade_route() also checks ==max, but in that case

[Freeciv-Dev] [bug #22236] Flag swapping for Barbarians Pirates ?

2014-06-28 Thread Marko Lindqvist
Update of bug #22236 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1341] Replace Improvement replaced_by with a requirements vector

2014-06-28 Thread Marko Lindqvist
Follow-up Comment #3, patch #1341 (project freeciv): Does this cause behavior changes? What happens in these situations: 1) You learn Gunpowder, but haven't built any Barracks II yet (all existing Barracks should be sold) 2) You conquer city with Barracks II, but don't know Gunpowder yourself,

[Freeciv-Dev] [bug #22188] civ2civ3: remove DiplomatDefense flag from Airbase

2014-06-28 Thread Marko Lindqvist
Update of bug #22188 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4857] Move tech_want data to default AI

2014-06-28 Thread Emmet Hikory
Follow-up Comment #3, patch #4857 (project freeciv): No, I just didn't understand why cai_created_by_civil_war() and twai_created_by_civil_war() were being defined in a patch that otherwise looks like a data storage migration patch, having not thought it through sufficiently to realise this copy

[Freeciv-Dev] [patch #4857] Move tech_want data to default AI

2014-06-28 Thread Marko Lindqvist
Follow-up Comment #4, patch #4857 (project freeciv): - Updated against svn (file #21189) ___ Additional Item Attachment: File name: AiTechWant-2.patch.bz2 Size:7 KB ___

[Freeciv-Dev] [patch #4870] Clearer error message when no client can be built

2014-06-28 Thread Marko Lindqvist
URL: http://gna.org/patch/?4870 Summary: Clearer error message when no client can be built Project: Freeciv Submitted by: cazfi Submitted on: Sun 29 Jun 2014 02:58:34 AM EEST Category: bootstrap Priority:

[Freeciv-Dev] [patch #4870] Clearer error message when no client can be built

2014-06-28 Thread Marko Lindqvist
Update of patch #4870 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.3, 2.5.0, 2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #1341] Replace Improvement replaced_by with a requirements vector

2014-06-28 Thread Emmet Hikory
Follow-up Comment #4, patch #1341 (project freeciv): I'll test these conditions to verify, but from code interpretation: 1) Because, unlike other requirements vectors, obsolete_by is disjunctive, Barracks is interpreted as obsolete by improvement_obsolete(), so handled appropriately. Thinking

[Freeciv-Dev] [patch #1341] Replace Improvement replaced_by with a requirements vector

2014-06-28 Thread Emmet Hikory
Follow-up Comment #5, patch #1341 (project freeciv): 1) is now tested, and indeed works as expected: learning Gunpowder causes one to sell all Barracks, even if one has not built any Barracks II 2) Is also tested: attempts to force worklist inclusion of the obsolete Barracks I in a city