[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-12 Thread pepeto
Follow-up Comment #4, bug #22455 (project freeciv):

I would like to investigate to see what changed exactly in savegame loading to
see if the path is fully correct. I think I can do it today.


___

Reply to this item at:

  http://gna.org/bugs/?22455

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-12 Thread pepeto
Update of bug #22455 (project freeciv):

  Status:None = Ready For Test 

___

Follow-up Comment #5:

Attaching a patch (not tested yet) which looks more correct:
* assign the cost only after all researches and embassies have been set (in
case of tech leakage) ;
* also do it in savegame.c.

 I would like to investigate to see what changed exactly in
 savegame loading

Previously, this value was not cached. That's the reason.


(file #21690)
___

Additional Item Attachment:

File name: load_savegame_init_researching_cost.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22455

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19848] assertion 'tech == (200-2) || (tech = 0 tech game.control.num_tech_types)' failed

2014-08-12 Thread pepeto
Update of bug #19848 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #2:

2 patches attached:
* send connection info when detaching to keep client synchronized before
sending player info packets ;
* enforce client science helpers to don't output error messages (only S2_4 and
S2_5 ; trunk is already protected).


(file #21691, file #21692)
___

Additional Item Attachment:

File name: connection_detach.patchSize:1 KB
File name: client_research_A_UNKNOWN_bulbs.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?19848

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

2014-08-12 Thread Sveinung Kvilhaugsvik
Update of patch #5020 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

unit_state_chache.patch is the patch. The other files are for testing.

To test it apply patch #4671, 0003-Test.patch (to allow spy units but not
diplomats to perform the action Establish embassy from non native terrain),
load the savegame spy_and_diplomat_in_ship.sav.bz2 and find the transport with
the diplomat and the spy next to a foreign city.

(file #21693, file #21694, file #21695)
___

Additional Item Attachment:

File name: unit_state_chache.patchSize:11 KB
File name: spy_and_diplomat_in_ship.sav.bz2 Size:14 KB
File name: 0003-Test.patchSize:0 KB


___

Reply to this item at:

  http://gna.org/patch/?5020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

2014-08-12 Thread Sveinung Kvilhaugsvik
Update of patch #4671 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #10:

Works when patch #5020 is applied

___

Reply to this item at:

  http://gna.org/patch/?4671

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5019] Document that hard action requiremetns may be appended

2014-08-12 Thread Sveinung Kvilhaugsvik
Update of patch #5019 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5019

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

2014-08-12 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #5020 (project freeciv):

Things that could be wrong:
 * the cache is a static array looked up by unit id. Alternatively it could be
a filed in the unit struct or some other data structure. (At the moment only
some unit types can perform action enabler controlled actions)
 * the cache is eagerly filled on ruleset load in stead of being filled
lazily. (At the moment only one unit state property is checked)
 * it lives in unittypes.c/h and not in actions.c/h

___

Reply to this item at:

  http://gna.org/patch/?5020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5030] Add metaknowledge for the remaining requirement ranges of CityTile

2014-08-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5030

 Summary: Add metaknowledge for the remaining requirement
ranges of CityTile
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 12 Aug 2014 03:23:11 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Tue 12 Aug 2014 03:23:11 PM UTC  Name:
0001-Add-metaknowledge-for-the-remaining-requirement-rang.patch  Size: 3kB  
By: sveinung

http://gna.org/patch/download.php?file_id=21696

___

Reply to this item at:

  http://gna.org/patch/?5030

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20892] unendliche Schleife bei der Zuweisung der Startpositionen

2014-08-12 Thread pepeto
Update of bug #20892 (project freeciv):

Category:None = general
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20892

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14775] The server appears to have gotten into an infinite loop in the allocation of starting positions.

2014-08-12 Thread pepeto
Follow-up Comment #10, bug #14775 (project freeciv):

See also bug #20892.

___

Reply to this item at:

  http://gna.org/bugs/?14775

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [task #7818] Windows packages for 2.4.3

2014-08-12 Thread Jacob Nevins
Update of task #7818 (project freeciv):

  Status:   Need Info = None   

___

Follow-up Comment #1:

2.4.3 tarball now up at Gna
http://download.gna.org/freeciv/stable/freeciv-2.4.3.tar.bz2 (still
uploading to Sourceforge).

___

Reply to this item at:

  http://gna.org/task/?7818

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22462] More logging around spawned server start

2014-08-12 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22462

 Summary: More logging around spawned server start
 Project: Freeciv
Submitted by: jtn
Submitted on: Tue 12 Aug 2014 21:25:00 BST
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

Debian bug 757876 http://bugs.debian.org/757876 highlights that we could do
with more logging around the process of starting a spawned server.
The specific problem is that the server can't bind to the port that the server
assigned, but we don't know what port that is.
# Client should log details of the server it's starting (probably just the
whole command line).
# Server should log the port number it's trying to listen on before bailing
out because it failed.




___

Reply to this item at:

  http://gna.org/bugs/?22462

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Freeciv 2.4.3 source code released

2014-08-12 Thread Jacob Nevins
A new stable release of Freeciv, 2.4.3, is available as source code for
download.

This release fixes a miscellaneous collection of bugs.
See the full list of changes: http://www.freeciv.org/wiki/NEWS-2.4.3.

Download the source tarball from one of our mirrors, linked from
http://www.freeciv.org/wiki/Download#Stable_2.4.
(Windows packages should follow shortly at the same location.)

Thanks to all contributors and bug reporters that helped with this
release. Enjoy it!

On behalf of the Freeciv Dev Team,
  Jacob Nevins

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5031] Qt client: Support diplomat actions against own tile.

2014-08-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5031

 Summary: Qt client: Support diplomat actions against own
tile.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 12 Aug 2014 10:02:40 PM UTC
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Tue 12 Aug 2014 10:02:40 PM UTC  Name:
0001-Qt-client-Support-diplomat-actions-against-own-tile.patch  Size: 2kB  
By: sveinung

http://gna.org/patch/download.php?file_id=21699

___

Reply to this item at:

  http://gna.org/patch/?5031

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5029] Add lua-5.3 under freeciv version control

2014-08-12 Thread Marko Lindqvist
Update of patch #5029 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5029

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22463] find_next_free_port() and server port bind() do not match

2014-08-12 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22463

 Summary: find_next_free_port() and server port bind() do not
match
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 13 Aug 2014 02:11:25 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0

___

Details:

Investigating https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757876 I
noticed (likely cause to it) that
find_next_free_port() considers port which is free in *any* interface, but
server actually wants to bind() to *all* interfaces.




___

Reply to this item at:

  http://gna.org/bugs/?22463

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22463] find_next_free_port() and server port bind() do not match

2014-08-12 Thread Marko Lindqvist
Update of bug #22463 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Fix.

(file #21700)
___

Additional Item Attachment:

File name: BindAll.patch  Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22463

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2203] [Metaticket] gold upkeep

2014-08-12 Thread Marko Lindqvist
Update of patch #2203 (project freeciv):

 Planned Release:   2.4.0 = 2.6.0  


___

Reply to this item at:

  http://gna.org/patch/?2203

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())

2014-08-12 Thread Marko Lindqvist
Update of bug #16864 (project freeciv):

 Assigned to: syntron = pepeto 
 Planned Release:   2.4.0 = 2.6.0  

___

Follow-up Comment #9:

pepeto was the last one to touch this, and only one involved currently active.

___

Reply to this item at:

  http://gna.org/bugs/?16864

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16887] do not list files twice in the save dialogs

2014-08-12 Thread Marko Lindqvist
Update of bug #16887 (project freeciv):

  Status:  Ready For Test = None   
 Planned Release:   2.4.0 =


___

Reply to this item at:

  http://gna.org/bugs/?16887

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1391] [Metaticket] new code to generate stats (graphics)

2014-08-12 Thread Marko Lindqvist
Update of patch #1391 (project freeciv):

  Status: In Progress = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1391

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2143] [RFC] AI interface using lua

2014-08-12 Thread Marko Lindqvist
Update of patch #2143 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?2143

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2310] AI traits patch

2014-08-12 Thread Marko Lindqvist
Update of patch #2310 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?2310

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2427] [metaticket] Add missing function headers

2014-08-12 Thread Marko Lindqvist
Update of patch #2427 (project freeciv):

 Planned Release:   2.5.0 = 3.0.0  


___

Reply to this item at:

  http://gna.org/patch/?2427

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2554] lua AI module

2014-08-12 Thread Marko Lindqvist
Update of patch #2554 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?2554

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2984] Make AI plan research to preserve its wonders and obsolete others'

2014-08-12 Thread Marko Lindqvist
Update of patch #2984 (project freeciv):

 Assigned to:  jorneg = None   


___

Reply to this item at:

  http://gna.org/patch/?2984

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2969] aicmd command

2014-08-12 Thread Marko Lindqvist
Update of patch #2969 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?2969

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3260] Show only airports in goto dialog

2014-08-12 Thread Marko Lindqvist
Update of patch #3260 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?3260

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3721] Getting rid of move_type dependency on unitselect dialog

2014-08-12 Thread Marko Lindqvist
Update of patch #3721 (project freeciv):

 Planned Release:   2.5.0 = 2.6.0  


___

Reply to this item at:

  http://gna.org/patch/?3721

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4860] Alien: Make Tunnels available from Smart Aliens already

2014-08-12 Thread Marko Lindqvist
Update of patch #4860 (project freeciv):

Priority:  5 - Normal = 3 - Low


___

Reply to this item at:

  http://gna.org/patch/?4860

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13943] Allow unit to choose which transport to load onto

2014-08-12 Thread Marko Lindqvist
Update of bug #13943 (project freeciv):

 Planned Release:   2.4.1 =


___

Reply to this item at:

  http://gna.org/bugs/?13943

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18243] Client hangs with with gtk+ 2.24.5 (and Ubuntu Oneiric's 2.24.6) and Freeciv theme

2014-08-12 Thread Marko Lindqvist
Update of bug #18243 (project freeciv):

Severity: 5 - Blocker = 3 - Normal 
 Planned Release:   2.4.0 =


___

Reply to this item at:

  http://gna.org/bugs/?18243

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22444] clean_pollution|fallout_time not documented

2014-08-12 Thread Marko Lindqvist
Update of bug #22444 (project freeciv):

  Status:None = Ready For Test 
 Planned Release:2.5.0, 2.4.3 = 2.5.0, 2.4.4   

___

Follow-up Comment #1:

Patches. Just the TRUNK text with TRUNK-specific parts removed.

(file #21701, file #21702)
___

Additional Item Attachment:

File name: PollutionTime-S2_5.patch   Size:5 KB
File name: PollutionTime-S2_4.patch   Size:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?22444

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5032] gtk3-client desktop file to specify it as gtk3-client in S2_5

2014-08-12 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5032

 Summary: gtk3-client desktop file to specify it as
gtk3-client in S2_5
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 13 Aug 2014 04:22:41 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2

___

Details:

Make name of the gtk3-client in S2_5 desktop file as Freeciv (gtk3) to match
gtk2-client's Freeciv (gtk2). Otherwise we have the weird situation that the
default client specifies what it is but non-default one has name like default.



___

File Attachments:


---
Date: Wed 13 Aug 2014 04:22:41 AM EEST  Name: DesktopGtk3Name-S2_5.patch 
Size: 782B   By: cazfi

http://gna.org/patch/download.php?file_id=21703

___

Reply to this item at:

  http://gna.org/patch/?5032

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14529] Separate LAN servers and metaserver's servers connection

2014-08-12 Thread Marko Lindqvist
Update of bug #14529 (project freeciv):

  Status:None = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?14529

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18732] [luaai] changes to lua AI makefile to force generation of tolua_server_gen.(c|h)

2014-08-12 Thread Marko Lindqvist
Update of bug #18732 (project freeciv):

 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/bugs/?18732

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19729] luasql (database.lua) threat model unclear, security measures get in the way

2014-08-12 Thread Marko Lindqvist
Update of bug #19729 (project freeciv):

 Planned Release:   2.5.0 = 2.6.0  


___

Reply to this item at:

  http://gna.org/bugs/?19729

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev