[Freeciv-Dev] [patch #5427] make doc

2014-11-13 Thread pepeto 
Follow-up Comment #1, patch #5427 (project freeciv):

Nobody has answered my comment  about
doxygen and code base comments. But it is still topical...


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22932] info_label::paint() crash when indicator icons not created

2014-11-13 Thread Marko Lindqvist 
Follow-up Comment #1, bug #22932 (project freeciv):

If patch #5127 makes it to S2_5, TRUNK version of this patch should be used
for S2_5 too (forgot the separate S2_5 version)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5429] freeciv-mp-qt nullptr

2014-11-13 Thread Marko Lindqvist 
Update of patch #5429 (project freeciv):

 Planned Release:   2.6.0 => 2.5.0, 2.6.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5127] Add check for C++11 nullptr and provide fallback if it's missing

2014-11-13 Thread Marko Lindqvist 
Update of patch #5127 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #4:

S2_5 version

(file #22892)
___

Additional Item Attachment:

File name: Nullptr-S2_5.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5127] Add check for C++11 nullptr and provide fallback if it's missing

2014-11-13 Thread Marko Lindqvist 
Update of patch #5127 (project freeciv):

  Status:Done => In Progress
 Open/Closed:  Closed => Open   
 Planned Release:   2.6.0 => 2.5.0, 2.6.0   

___

Follow-up Comment #3:

Better to port this to S2_5, as even without it we're quite likely to
accidentally port back code that uses 'nullptr'.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22955] Implicit declaration of function 'setlocale'

2014-11-13 Thread Marko Lindqvist 
Follow-up Comment #1, bug #22955 (project freeciv):

Only trunk affected, and even that I have built with these flags not long ago.
I assume this to be due to gettext changes, that include used to come
indirectly through gettext stuff.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5429] freeciv-mp-qt nullptr

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: freeciv-mp-qt nullptr
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 08:14:50 AM EET
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Use 'nullptr' instead of NULL in freeciv-mp-qt except when passing it to
C-code (not sure what our policy should be in those cases).



___

File Attachments:


---
Date: Fri 14 Nov 2014 08:14:50 AM EET  Name: FcmpQtNullptr.patch  Size: 3kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22955] Implicit declaration of function 'setlocale'

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: Implicit declaration of function 'setlocale'
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 08:06:34 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.4, 2.5.0, 2.6.0

___

Details:

Build with "CFLAGS=-std=gnu11" "CXXFLAGS=-std=c++11"

utility/shared.c: In function 'init_nls':
utility/shared.c:1462:3: error: implicit declaration of function 'setlocale'
[-Werror=implicit-function-declaration]
   (void) setlocale(LC_ALL, "");


Fix attached



___

File Attachments:


---
Date: Fri 14 Nov 2014 08:06:34 AM EET  Name: LocaleInclude.patch  Size: 988B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22954] Huge amounts of "Treaty can't have tech " from civ2civ3

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: Huge amounts of "Treaty  can't have tech
" from civ2civ3
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 03:19:24 AM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

civ2civ3 autogame with current TRUNK produces huge amounts of $subject
messages from diplhand.c:197.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5428] Remove unused parameter from print_usage()

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: Remove unused parameter from print_usage()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 01:58:41 AM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Remove argv0 parameter, unused in all guis, from print_usage()



___

File Attachments:


---
Date: Fri 14 Nov 2014 01:58:41 AM EET  Name: PrintUsageVoid.patch  Size: 8kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22926] freeciv-qt -- --help ignored

2014-11-13 Thread Marko Lindqvist 
Update of bug #22926 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.0, 2.6.0   

___

Follow-up Comment #1:

Fix

(file #22888)
___

Additional Item Attachment:

File name: QtOptions.patchSize:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5427] make doc

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: make doc
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 01:11:19 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add target 'doc' to main makefile to generate doxygen documentation



___

File Attachments:


---
Date: Fri 14 Nov 2014 01:11:19 AM EET  Name: MakeDoc.patch  Size: 1kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5426] Make fog_style specenum

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: Make fog_style specenum
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 14 Nov 2014 12:44:29 AM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Replace magic fogstyle numbers in tileset with names.

- Make fog_style an specenum
- Rename tileset entry from "fogstyle" to "fog_style"




___

File Attachments:


---
Date: Fri 14 Nov 2014 12:44:29 AM EET  Name: SpecenumFogstyle.patch  Size: 8kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22953] Server LAN advertisement IP

2014-11-13 Thread David Lowe 
Follow-up Comment #1, bug #22953 (project freeciv):

I guess i should put my Cisco training to work and look at this.  Offhand, i
wouldn't expect a typical residential LAN to even have a DNS.  It seems like
the advertisement should prefer IP over hostname.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17582] [metaticket] Headers depend on fc_config.h

2014-11-13 Thread Marko Lindqvist 
Update of bug #17582 (project freeciv):

Category:None => bootstrap  
 Summary: [metaticket] Headers depend on config.h =>
[metaticket] Headers depend on fc_config.h

___

Follow-up Comment #2:

> implementing such an include from freeciv build directory would
> be ugly.

It's not perfect, but from bad options this is probably the most usable one -
though not using the internal fc_config.h header but one built just for this
purpose - patch #5419

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17582] [metaticket] Headers depend on config.h

2014-11-13 Thread Marko Lindqvist 
Update of bug #17582 (project freeciv):

  Depends on: => patch #5419


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5419] freeciv_config.h

2014-11-13 Thread Marko Lindqvist 
Update of patch #5419 (project freeciv):

  Status: In Progress => Ready For Test 
 Summary: Include  to meta.h => freeciv_config.h 
 

___

Follow-up Comment #2:

Turn this ticket to first step towards bug #17582:

In addition to fc_config.h configuration headers used internally, create
gen_headers/freeciv_config.h header that contains only things that can be
sefely included to external packages (no default autoconf produced macros that
would conflict with packages own ones).
Define FREECIV_META_URL there.

(file #22885)
___

Additional Item Attachment:

File name: freeciv_config.patch   Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22944] Profiling of current SVN trunk

2014-11-13 Thread Andreas Røsdal 
Follow-up Comment #5, bug #22944 (project freeciv):

To measure the performance of Freeciv and Freeciv-web with various server
settings, I have created this github project:

https://github.com/freeciv/freeciv-benchmark


Here are the results from running freeciv-benchmark for me:
Default settings: 48s
Big map (size 18): 78s
XXL map (size 128): 229s
Big map, many AIs (size 18, 128 AIs): 616s
Many AIs (128 AIs): 125s
Easy AI: 49s
Hard AI: 50s
Freeciv-web (fcweb default settings): 33s

It would be interesting to measure these results over time. I also hope that
we use this to make performance improvements to the server settings which are
significantly slower than the others.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5420] adv_settlers_road_bonus(): assert road tgt of other units

2014-11-13 Thread Marko Lindqvist 
Update of patch #5420 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5425] List sdl2-client in client list of BUGS

2014-11-13 Thread Marko Lindqvist 
URL:
  

 Summary: List sdl2-client in client list of BUGS
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 13 Nov 2014 11:01:36 PM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Thu 13 Nov 2014 11:01:36 PM EET  Name: BugsSdl2.patch  Size: 469B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5414] Separate timeout packet

2014-11-13 Thread Marko Lindqvist 
Update of patch #5414 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22909] Global advances are not saved

2014-11-13 Thread pepeto 
Update of bug #22909 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22667] collect_eventually_buildable_targets bad behaviour

2014-11-13 Thread pepeto 
Update of bug #22667 (project freeciv):

Category:  client => general
  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #5:

Note this bug might have other effects: does the AI considering it could build
great wonder not available?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22951] Irrigation tile not showing on map

2014-11-13 Thread pepeto 
Follow-up Comment #2, bug #22951 (project freeciv):

On freeciv-dev, Damien Caillard wrote:
> but I'm surprised this box stayed unchecked even after two
> re-installations of the game
The option is registred in the client rc file. I don't think this file is
removed when reinstalling Freeciv. Should it be?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22953] Server LAN advertisement IP

2014-11-13 Thread anonymous 
URL:
  

 Summary: Server LAN advertisement IP
 Project: Freeciv
Submitted by: None
Submitted on: Thu 13 Nov 2014 07:55:23 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: knuckv...@gmail.com
 Open/Closed: Open
 Release: 2.4.3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The server seems to have trouble advertising its ip address to LAN, making the
client rely on the hostname, which will not resolve unless LAN DNS is working
properly. The following IRC log is the source.



___

File Attachments:


---
Date: Thu 13 Nov 2014 07:55:23 PM UTC  Name: fc_log.log  Size: 3kB   By: None



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22933] Observer client sends PACKET_SPACESHIP_PLACE

2014-11-13 Thread Marko Lindqvist 
Update of bug #22933 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22944] Profiling of current SVN trunk

2014-11-13 Thread Marko Lindqvist 
Follow-up Comment #4, bug #22944 (project freeciv):

btw.  is_req_active() is one of those functions with massive switch-cases I
wanted to optimize in patch #4949. I remember there was some disagreeing
comments, but apparently those are not in the ticket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5419] Include to meta.h

2014-11-13 Thread Marko Lindqvist 
Update of patch #5419 (project freeciv):

  Status:  Ready For Test => In Progress
 Planned Release:2.5.0, 2.6.0 => 2.6.0  

___

Follow-up Comment #1:

The patch I submitted earlier works to wrong direction in relation to bug
#17582

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev