[Freeciv-Dev] [patch #7273] Move packets.def to common/networking/

[Marko Lindqvist]

URL:
  

 Summary: Move packets.def to common/networking/
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 17 Jun 2016 07:18:52 AM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

In addition to applying this patch, move the actual file.



___

File Attachments:


---
Date: Fri 17 Jun 2016 07:18:52 AM EEST  Name: NetworkingPacketsDef.patch 
Size: 2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24654] Limit of 15 fragments

[Marko Lindqvist]

Update of bug #24654 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.6.0, 3.0.0   

___

Follow-up Comment #3:

Checking through related packets in S2_6/TRUNK, the only problem I saw was
that road move_cost is defined as SINT8, with a comment that '-1' must be
valid and ths MOVEFRAGS type cannot be used. Attached patch makes it SINT16,
so that max value has only one bit less than MOVEFRAGS, not 9.

(file #27567)
___

Additional Item Attachment:

File name: RoadSint16Move.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7272] game.ruleset 'froḿ' -> 'from'

[Marko Lindqvist]

URL:
  

 Summary: game.ruleset 'froḿ' -> 'from'
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 17 Jun 2016 06:49:41 AM EEST
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Replace typo 'ḿ' with 'm' in game.ruleset comment.



___

File Attachments:


---
Date: Fri 17 Jun 2016 06:49:41 AM EEST  Name: FroM.patch  Size: 5kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24721] MQTX music

[Frank]

Follow-up Comment #2, bug #24721 (project freeciv):

That should be reproducible, a broken link doesn't help (untested: web
archive). For
https://commons.wikimedia.org/wiki/File:CullamBruce-Lockhart--Dawning_Fanfare.oga
I'm confident that it should survive minor accidents like a shutdown of Gna!
and/or Wikia, when the original uploader (=me) + reviewer (=an admin checking
this, cf. file history) are not more alive/around.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7266] Document the UnitState req type's properties

[Sveinung Kvilhaugsvik]

Update of patch #7266 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24756] README.effects: minor formating fix

[Sveinung Kvilhaugsvik]

Update of bug #24756 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24749] tileset problem after 1st start

[Frank]

Follow-up Comment #1, bug #24749 (project freeciv):

Yes, that's a known problem for 2.5 and
http://freeciv.wikia.com/wiki/Ancients

If you want to start a ruleset needing a non-default tileset you need two
options: -r ruleset (for "read ruleset.serv" presumably containing command
"rulesetdir ruleset") AND -t tileset (for a corresponding file
"tileset.tilespec").

Many Freeciv issues boil down to unclear documentation, e.g., in theory
rulesets can define a preferred tileset, but in practice trying to grok
Freeciv for less than a decade I have no idea how this works, if it works at
all, or if it is an 1.x feature dropped more than 15 years ago. ;-)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7260] Action enabler control regular attacks

[Sveinung Kvilhaugsvik]

Update of patch #7260 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7264] unit order validate actions with 0 range

[Sveinung Kvilhaugsvik]

Update of patch #7264 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24654] Limit of 15 fragments

[Frank]

Follow-up Comment #2, bug #24654 (project freeciv):

The comment was in March, presumably I was talking about 2.5.3.

Quick 2.5.4 test changing 12 to 16 in a working ruleset: No bang, no crash.
100: No bang, no crash. 255: No bang, no crash. 

256: Bang, "Trying to put 256 into 8 bits; it will result 0 at receiving
side."

WORKSFORME (I'm interested in 100 to get percent)


  

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7271] Stop assuming unchangeable tech research reqs

[Sveinung Kvilhaugsvik]

Additional Item Attachment, patch #7271 (project freeciv):

File name: 0002-Stop-assuming-unchangeable-tech-research-reqs.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7271] Stop assuming unchangeable tech research reqs

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Stop assuming unchangeable tech research reqs
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 16 Jun 2016 10:53:29 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

The only reason the evaluation of a tech's research_reqs isn't horribly wrong
is that only unchangeable requirements are accepted. Correct the evaluation
code so it won't break in a surprising and hard to debug once it encounters
changeable requirements.



___

File Attachments:


---
Date: Thu 16 Jun 2016 10:53:29 PM UTC  Name:
0002-Stop-assuming-unchangeable-tech-research-reqs.patch  Size: 6kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24449] Windows Installer snapshot build versions always considered "modified"

[Marko Lindqvist]

Update of bug #24449 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Fix that svn reverts changes made under translation/ between builds of
packages.

(file #27563)
___

Additional Item Attachment:

File name: CleanupCheckout.patch  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24753] Typo "invididual" instead of "individual"

[Marko Lindqvist]

Update of bug #24753 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24711] The save game is wrong about what the closest relationship ...

[Sveinung Kvilhaugsvik]

Follow-up Comment #3, bug #24711 (project freeciv):

> It would be good to have bug number this is duplicate of listed here,
bug #23973

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24677] Modpack installer not respecting dir separator

[Marko Lindqvist]

Update of bug #24677 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7270] Log cleartext field range assert failure reason also when asserts enabled

[Marko Lindqvist]

URL:
  

 Summary: Log cleartext field range assert failure reason also
when asserts enabled
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 16 Jun 2016 07:20:02 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Only relying on fc_assert() itself to print out the message sometimes lead to
hard (impossible) to understand messages as some macros are already
preprocessed and not printed out like they are in the source code.
Attached patch adds cleartext logging.



___

File Attachments:


---
Date: Thu 16 Jun 2016 07:20:02 PM EEST  Name: FieldRangeAssertLogging.patch 
Size: 1005B   By: cazfi


---
Date: Thu 16 Jun 2016 07:20:02 PM EEST  Name:
FieldRangeAssertLogging-S2_6.patch  Size: 945B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24711] The save game is wrong about what the closest relationship ...

[Marko Lindqvist]

Update of bug #24711 (project freeciv):

Category:None => general
  Status:None => Duplicate  
 Assigned to:None => sveinung   
 Open/Closed:Open => Closed 
 Release:   2.5.4+ R32731 => 2.5.1  

___

Follow-up Comment #2:

It would be good to have bug number this is duplicate of listed here, but
closing anyway.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7238] Make action probability a range

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #7238 (project freeciv):

I have done some work. I hope to get it ready before the end of the coming
week.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status:None => Ready For Test 
 Contains string changes:None => Yes

___

Follow-up Comment #3:

S2_6 version

There's problems with the initial state of the setting in client side, but
those are likely to go to another ticket (have to investigate a bit more)


(file #27560)
___

Additional Item Attachment:

File name: EditorHaveResources-S2_6-2.patch Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7265] Action probability for the "Attack" action

[Sveinung Kvilhaugsvik]

Update of patch #7265 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: 0004-Action-probability-for-the-Attack-action-v2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Follow-up Comment #2, bug #21347 (project freeciv):

TRUNK commit candidate. S2_6 to follow.

(file #27558)
___

Additional Item Attachment:

File name: EditorHaveResources-2.patchSize:16 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7238] Make action probability a range

[Marko Lindqvist]

Follow-up Comment #1, patch #7238 (project freeciv):

Any progress on this? Out of current 3 S2_6 npf blocker tickets, this is the
only one that I don't have plans to close myself within a week.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24651] players_non_invade() & Armistice

[Marko Lindqvist]

Update of bug #24651 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24760] AI player production change penalty inconsistency

[Marko Lindqvist]

Update of bug #24760 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix

The H_AWAY part from the ai/default/ is not part of this, even if it exist.

(file #27555, file #27556, file #27557)
___

Additional Item Attachment:

File name: ProdPenaltyNoAi.patch  Size:0 KB
File name: ProdPenaltyNoAi-S2_6.patch Size:0 KB
File name: ProdPenaltyNoAi-S2_5.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] freeciv-2.7

[Marko Lindqvist]

I've been thinking possibility of freeciv-2.7 between freeciv-2.6 and
freeciv-3.0.
S2_7 would be branched from S2_6, some time after S2_6 npf (last freeze stage).

The idea of such a version would be providing some of the post-2.6 improvements
before 3.0 as wait between freeciv-2.6 and freeciv-3.0 is likely to be long.
As per our usual version numbering rules freeciv-2.7 would not need to
be compatible
with freeciv-2.6, except that it must be able to read old savegames
and 2.6 rulesets.

Some things that we may want to backport from TRUNK to S2_7:
- Data format fixes that we are not able to do in 2.6 due to d3f
- Network protocol fixes that we are not able to do in 2.6 due to npf
- Dropping xaw-client and sdl-client
- gtk3-client minimum gtk version bump (to 3.10) and improvements it allows
- Bootstrap update (m4 file updates and such)
- Compatibility loading of previous version rulesets (test it before
3.0 tries it)
- Msys2 based Installer builds for Windows as official builds
- New tilesets / rulesets



 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7267] Add the new UnitState property OnNativeTile

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, patch #7267 (project freeciv):

v2:
* fix translation comment

(file #27554)
___

Additional Item Attachment:

File name: 0008-Add-the-new-UnitState-property-OnNativeTile-v2.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24755] OnLivableTile doesn't equal OnNativeTile

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, bug #24755 (project freeciv):

v2:
* apply on current SVN
* fix translation comment

(file #27552, file #27553)
___

Additional Item Attachment:

File name: 3.0-OnLivableTile-doesn-t-equal-OnNativeTile-v2.patch Size:1 KB
File name: 2.6-OnLivableTile-doesn-t-equal-OnNativeTile-v2.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7269] Make AI to use change_build_target()

[Marko Lindqvist]

URL:
  

 Summary: Make AI to use change_build_target()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 16 Jun 2016 01:12:44 PM EEST
Category: ai
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Attached WIP (bug #24760 fix to be separated from it) patch makes default AI
to use change_build_target() instead of using implementation of its own. That
makes change_build_target() more centralized place of production changes.



___

File Attachments:


---
Date: Thu 16 Jun 2016 01:12:44 PM EEST  Name: ChooseBuildAi.patch  Size: 4kB  
By: cazfi


---
Date: Thu 16 Jun 2016 01:12:44 PM EEST  Name: ChooseBuildAi-S2_6.patch  Size:
4kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24760] AI player production change penalty inconsistency

[Marko Lindqvist]

URL:
  

 Summary: AI player production change penalty inconsistency
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 16 Jun 2016 01:07:07 PM EEST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.5, 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

(Default) AI players are not supposed to be subject to production change
penalty. Yet there's no check against the penalty when production change
happens via building advisor when one *must* change production.
There's likely also problems with H_AWAY players not being penalized under
some circumstances, but I'm yet to produce failing test case of that.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7217] Document FREECIV_LABEL_FORCE

[Marko Lindqvist]

Update of patch #7217 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6908] Some corrections to translatable strings

[Marko Lindqvist]

Follow-up Comment #5, patch #6908 (project freeciv):

New S2_6 and TRUNK versions, updated against svn

(file #27548, file #27549)
___

Additional Item Attachment:

File name: 6908-2.patch   Size:2 KB
File name: 6908-S2_6-2.patch  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24627] Property editor clears other game properties when others are changed

[Marko Lindqvist]

Update of bug #24627 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7268] Allocate slot for 2.7 client option file

[Marko Lindqvist]

URL:
  

 Summary: Allocate slot for 2.7 client option file
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 16 Jun 2016 11:52:48 AM EEST
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Prepare TRUNK client option client lookup to the possibility that there will
be freeciv 2.7 between 2.6 and 3.0 (what TRUNK will become)

It might be a good idea to fix some of the issues that we will not be able to
fix in S2_6 due to freeze states, in a new S2_7 branched from it, while
waiting for 3.0.



___

File Attachments:


---
Date: Thu 16 Jun 2016 11:52:48 AM EEST  Name: 27Space.patch  Size: 768B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev