[Freeciv-Dev] [patch #7866] Drop gtk_style_context_invalidate() call from S2_6 gtk3.22-client

2016-10-30 Thread Marko Lindqvist 
Update of patch #7866 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4101] Ability for bases to hide units

2016-10-30 Thread Marko Lindqvist 
Update of patch #4101 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #3:

WIP patch

Missing:
- Ruleset comments
- Handling of units on tile when extra appearas/disappears, extra_owner
changes, or alliance status between players changes

(file #29192)
___

Additional Item Attachment:

File name: UnitHidingExtras.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7894] Attack_Bonus effect

2016-10-30 Thread Marko Lindqvist 
URL:
  

 Summary: Attack_Bonus effect
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 30 Oct 2016 10:55:58 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Add effect type "Attack_Bonus".

It has bothered me that even negative "Defend_Bonus" cannot be given to give
attack bonus to specific player (e.g., "AI" requirement) since requirements of
the "Defend_Bonus" are about defending player. This patch should solve that
problem.



___

File Attachments:


---
Date: Sun 30 Oct 2016 10:55:58 PM EET  Name: AttackBonus.patch  Size: 6kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7893] Drop gtkpixcomm.[ch] from svn

2016-10-30 Thread Marko Lindqvist 
URL:
  

 Summary: Drop gtkpixcomm.[ch] from svn
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 30 Oct 2016 10:11:26 PM EET
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.g, 3.0.0
 Contains string changes: None

___

Details:

svn rm gtkpixcomm.[ch] from under version control from gui-gtk-3.0 and
gui-gtk-3.22 in TRUNK, and gui-gtk-3.22 only in S2_6




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25245] SDL diplomacy dialog mostly prevents treaty cancellation?

2016-10-30 Thread Marko Lindqvist 
Update of bug #25245 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.6, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Fix

(file #29188, file #29189, file #29190)
___

Additional Item Attachment:

File name: CanCancel.patchSize:1 KB
File name: CanCancel-S2_6.patch   Size:1 KB
File name: CanCancel-S2_5.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24860] Failed to draw map when main window initially shown

2016-10-30 Thread mir3x 
Follow-up Comment #16, bug #24860 (project freeciv):

Oh, I see there is screenshot, but that bug is about Qt-client and map, not
some area under unit label.
Have u tried with other themes ?
I would guess, its theme issue, mb never theme version could fix,
or switch to something new ( vertex is also nice for gtk , if u dont like
freeciv theme)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25246] usdlg memory leak

2016-10-30 Thread Marko Lindqvist 
Follow-up Comment #1, bug #25246 (project freeciv):

usdlg_tab_append_utype() -> gdk_pixbuf_new() is part of also other loss
records. For example:

==12941== 635,904 bytes in 23 blocks are indirectly lost in loss record 23,976
of 23,981
==12941==at 0x4C2ABAF: malloc (vg_replace_malloc.c:299)
==12941==by 0x813C0DC: gdk_pixbuf_new (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941==by 0x22506A: usdlg_tab_append_utype (unitselect.c:693)
==12941==by 0x22506A: usdlg_tab_update (unitselect.c:634)
==12941==by 0x22538D: usdlg_refresh (unitselect.c:353)
==12941==by 0x1EFB11: update_unqueue (update_queue.c:319)
==12941==by 0x161479: idle_callback_wrapper (gui_main.c:2177)
==12941==by 0x898A689: g_main_context_dispatch (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x898AA3F: ??? (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x898AD61: g_main_loop_run (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x6BC1804: gtk_main (in
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.2)
==12941==by 0x16414E: ui_main (gui_main.c:1821)
==12941==by 0x18C4C3: client_main (client_main.c:679)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25246] usdlg memory leak

2016-10-30 Thread Marko Lindqvist 
URL:
  

 Summary: usdlg memory leak
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 30 Oct 2016 08:28:15 PM EET
Category: client-gtk-3+
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_6 r34290
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

==12941== 1,664,160 (5,280 direct, 1,658,880 indirect) bytes in 60 blocks are
definitely lost in loss record 23,981 of 23,981
==12941==at 0x4C2ABAF: malloc (vg_replace_malloc.c:299)
==12941==by 0x898FDE8: g_malloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x89A8322: g_slice_alloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x89A894D: g_slice_alloc0 (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941==by 0x87202B3: g_type_create_instance (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941==by 0x87021FA: ??? (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941==by 0x870410D: g_object_new_valist (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941==by 0x87043B0: g_object_new (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941==by 0x813E9AF: gdk_pixbuf_new_from_data (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941==by 0x813C10D: gdk_pixbuf_new (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941==by 0x22506A: usdlg_tab_append_utype (unitselect.c:693)
==12941==by 0x22506A: usdlg_tab_update (unitselect.c:634)
==12941==by 0x22538D: usdlg_refresh (unitselect.c:353)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

2016-10-30 Thread Jacob Nevins 
Follow-up Comment #11, bug #23911 (project freeciv):

> remove the hopelessly broken feature of trying to turn "disband" > into
"help wonder" for some units
For the record: this behaviour had been present since at least 2004 (r9094
, PR#3989). (I
also support removing it rather than fixing it.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25245] SDL diplomacy dialog mostly prevents treaty cancellation?

2016-10-30 Thread Jacob Nevins 
URL:
  

 Summary: SDL diplomacy dialog mostly prevents treaty
cancellation?
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 30 Oct 2016 12:29:07 PM UTC
Category: client-sdl
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.5
 Discussion Lock: Any
Operating System: Any
 Planned Release: 
 Contains string changes: No

___

Details:

Noticed looking at bug #25085:

The SDL clients treat the return value from pplayer_can_cancel_treaty() as a
boolean (in popup_diplomacy_dialog()), but it's actually an enum, and not one
such that a nonzero return implies ability to cancel.

I think (but haven't tested) that this will prevent treaty cancellation except
when it's illegal; the only time it'll behave as intended is if a senate
blocks treaty cancellation (in which case we present a button, to consult the
server). But this seems like a rather major bug to have gone undetected, so
maybe I've misread it.

(The comments for pplayer_can_cancel_treaty() itself also incorrectly imply
that it returns a bool.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24860] Failed to draw map when main window initially shown

2016-10-30 Thread mir3x 
Follow-up Comment #15, bug #24860 (project freeciv):

If u encounter that, make screenshot and open bug for gtk3.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24860] Failed to draw map when main window initially shown

2016-10-30 Thread Christian Knoke 
Follow-up Comment #14, bug #24860 (project freeciv):

> Seems fit, with the exception, that I see this with GTK3 and Debian.

So, at first, I didn't see the MS Windows Tag, sorry for that. 

I see this with 2.5.5+ AND Gtk3 AND Debian Jessie. 

I do NOT see this with 2.5.5 plain AND Gtk2 AND Jessie.

Christian


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24860] Failed to draw map when main window initially shown

2016-10-30 Thread Christian Knoke 
Follow-up Comment #13, bug #24860 (project freeciv):


Seems fit, with the exception, that I see this with GTK3 and Debian.

Christian


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7888] Msys2: Build Qt-client installer

2016-10-30 Thread Marko Lindqvist 
Update of patch #7888 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6938] [Metaticket] Get rid of gtkpixcomm

2016-10-30 Thread Marko Lindqvist 
Update of patch #6938 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24860] Failed to draw map when main window initially shown

2016-10-30 Thread mir3x 
Update of bug #24860 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  

___

Follow-up Comment #12:

I found it on stack overflow:
"The very first time a process calls ShowWindow, the show command is ignored
and uses the command provided in the STARTUPINFO structure (which should
correspond with the nCmdShow parameter in WinMain).

This surprising behavior has a tendency to manifest itself in problems like
the one you describe. You may be able to resolve it by simply issuing QT's
showMaximized call twice if you don't want to use any Win32 API calls
directly."

So I added second call. Should work.


(file #29186, file #29187)
___

Additional Item Attachment:

File name: qt_smax.patch  Size:0 KB
File name: qt_smax_f25.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev