[Freeciv-Dev] (PR#40220) client/chatline_common.c not in POTFILES.in
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40220 Version S2_2 and trunk have a gettexted string in client/chatline_common.c, therefore this file must be included into POTFILES.in. Report by chomwitt, patch by me. Apply this thing to S2_2 and trunk: Index: po/POTFILES.in === --- po/POTFILES.in (revision 14611) +++ po/POTFILES.in (working copy) @@ -58,6 +58,7 @@ server/generator/startpos.c client/attribute.c client/audio.c +client/chatline_common.c client/citydlg_common.c client/cityrepdata.c client/civclient.c ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40209) A minor memory leak
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40209 Now I want a cookie! $ svn diff Index: server/sernet.c === --- server/sernet.c (revision 14605) +++ server/sernet.c (working copy) @@ -185,6 +185,7 @@ line_internal = local_to_internal_string_malloc(line); (void) handle_stdin_input(NULL, line_internal, FALSE); free(line_internal); + free(line); readline_handled_input = TRUE; } ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#30837) Savegame with broken research amounts
URL: http://bugs.freeciv.org/Ticket/Display.html?id=30837 Wednesday 17 October 2007 11:59:17 kirjutas Pepeto _: URL: http://bugs.freeciv.org/Ticket/Display.html?id=30837 Do you still get this kind of problem in newer Freeciv versions? Could you send more informations about the Freeciv version you used? How did you got this problem: - with normal research? - with changing the current target? - with a caravan bonus? - after a diplomatic treaty? - with something else? Ooh, it was SO long ago, I don't remember! I usually use SVN S2_1. I'll see if I can reproduce it with current S2_1, but this'll have to wait, because I've got school stuff coming up fast. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fwd: Re: (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 We held some correspondence with Stefan about the crash. Here's what he says: -- Forwarded message -- On Wed, Sep 12, 2007 at 05:12:59PM +0200, Stefan Dirsch wrote: On Wed, Sep 12, 2007 at 06:01:59PM +0300, Elmo Todurov wrote: Whose fault it is, GCC, glib2/gtk2 or FreeCiv? And, most importantly, how to fix it? Honestly. I have no idea. I'm afraid we need a gcc expert here to compare the assembler output of -O1 and -O2. :-( [snip: Stefan asks someone] According to our gcc expert this is a undefinedness of signed overflow in freeciv, since -O2 --fno-tree-vrp fixes it as well. [he means here that compiling ONLY the wldlg.c with --fno-tree-vrp fixes it] ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 gcc 4.x miscompiles gtk producing strange crashes that seem to originate in libc (strlen). I don't know if there are some special compiler switches one can use to make gcc 4 compile without this bug; the problem goes away if you compile gtk (and glib, etc.) with gcc 3.x (tested with gcc 3.4.6 gtk 2.10.13 glib 2.12.12). Hope that helps. My tests show that you're wrong. Compiling gtk2 and glib2 with gcc-3.3 didn't change anything. On the other hand, compiling FreeCiv with gcc-3.3 seems to fix or work around the bug. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 Some more testing proved that -O2 results in a segfault on city window popup, -O1 doesn't, -fschedule-insns results in a compile error. My gcc: gcc (GCC) 4.2.1 20070704 (prerelease) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459 Some debugging says that the faulty place is client/gui-gtk-2.0/wldlg.c function cell_render_func line 1008 (this might change because of commits to SVN): column = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(rend), column)); column is set to -1 and this makes this code segfault: g_object_set(rend, text, row[column], NULL); It might be that my GTK2 is bad.. How to check? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39459) Segfault when founding a city
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39459
Pre Scriptum: Two guys weren't able to reproduce this on different distros
(Gentoo and another Gentoo), so this might be connected to my building
environment on Arch Linux.
The problem:
Segfault when founding a city (it probably tries to display the dialogue, but
fails.
The environment:
Arch Linux (2 different boxes)
KDE (also happens with absolutely no WM in VNC)
GTK2 client (doesn't happen with SDL client)
The build:
branches/S2_1, revision 13105
The trace:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1219548976 (LWP 7814)]
0xb777d0d3 in strlen () from /lib/libc.so.6
(gdb) bt full
#0 0xb777d0d3 in strlen () from /lib/libc.so.6
No symbol table info available.
#1 0xb79ba09e in g_strdup () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#2 0xb7a3ce4a in value_collect_string () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#3 0xb7a1da16 in g_object_set_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#4 0xb7a1df76 in g_object_set () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#5 0x0812819c in cell_render_func (col=0x8da5640, rend=0xc508958,
model=0xadc1dd0, it=0xbf860e84, data=0xc6b20f4) at wldlg.c:1011
buf = {
[EMAIL PROTECTED],
\000\206��\024\000\000\000`\220'[EMAIL PROTECTED],
\r\206�\000\000\000\000�\f\206, [EMAIL
PROTECTED]@zP\fd\r\206��\027[EMAIL PROTECTED],
[EMAIL PROTECTED]@�d\fX\211P\f\030\r\206}
i = value optimized out
plr = value optimized out
row = {0xbf860bec Kasarmud, 0xbf860c2c , 0xbf860c6c 30,
0xbf860cac 30}
useless = value optimized out
cid = 3
target = {is_unit = 88, value = 3}
#6 0xb7e44eff in gtk_tree_view_column_cell_set_cell_data ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#7 0xb7e29ed1 in validate_row () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#8 0xb7e2e2ae in do_validate_rows () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#9 0xb7e3753e in gtk_tree_view_size_request ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#10 0xb7a23799 in g_cclosure_marshal_VOID__BOXED ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#11 0xb7a15659 in g_type_class_meta_marshal ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#12 0xb7a16f2c in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
---Type return to continue, or q return to quit---
#13 0xb7a27cb4 in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#14 0xb7a28d37 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#15 0xb7a2b45e in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#16 0xb7da5516 in do_size_request () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#17 0xb7da5536 in compute_base_dimension () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#18 0xb7da561d in compute_dimension () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#19 0xb7da571e in _gtk_size_group_compute_requisition ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#20 0xb7e58d1c in gtk_widget_size_request () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#21 0xb7d9a01f in gtk_scrolled_window_size_request ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#22 0xb7a23799 in g_cclosure_marshal_VOID__BOXED ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#23 0xb7a15659 in g_type_class_meta_marshal ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#24 0xb7a16f2c in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#25 0xb7a27cb4 in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#26 0xb7a28d37 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#27 0xb7a2b45e in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#28 0xb7da5516 in do_size_request () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#29 0xb7da574a in _gtk_size_group_compute_requisition ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#30 0xb7e58d1c in gtk_widget_size_request () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#31 0xb7dbfa13 in gtk_table_size_request () from /usr/lib/libgtk-x11-2.0.so.0
---Type return to continue, or q return to quit---
No symbol table info available.
#32 0xb7a23799 in g_cclosure_marshal_VOID__BOXED ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#33 0xb7a15659 in g_type_class_meta_marshal ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info
[Freeciv-Dev] (PR#39363) Another fix for PR#12232
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39363
This transaction appears to have no content
The original patch introduces a nasty bug where you can't enter your
allies' territory. The fix is attached.
Index: common/player.c
===
--- common/player.c (revision 12929)
+++ common/player.c (working copy)
@@ -741,7 +741,7 @@
const struct player *pplayer2)
{
assert(pplayer1 != pplayer2);
- return pplayers_in_peace(pplayer1, pplayer2);
+ return pplayers_in_peace(pplayer1, pplayer2) !pplayers_allied(pplayer1, pplayer2);
}
/***
pgp3zcQJ5uReT.pgp
Description: PGP signature
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
