[Freeciv-Dev] [bug #21134] Gtk3: Centering from overview map moves twice the distance wanted

2013-10-11 Thread RafałMużyło
Follow-up Comment #1, bug #21134 (project freeciv): Are there any special conditions involved, cause it seems I can't reproduce this behavior ? ___ Reply to this item at: http://gna.org/bugs/?21134

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2013-06-11 Thread RafałMużyło
Follow-up Comment #14, patch #3550 (project freeciv): Well, technically - patch #3469 comment #37. ___ Reply to this item at: http://gna.org/patch/?3550 ___ Message sent via/by Gna!

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2013-06-10 Thread RafałMużyło
Follow-up Comment #12, patch #3550 (project freeciv): I've missed a thing - what about the second patch (file #16748) ? ___ Reply to this item at: http://gna.org/patch/?3550 ___ Message

[Freeciv-Dev] [patch #3560] Use standard button interface (patch 21/60)

2013-05-03 Thread RafałMużyło
Follow-up Comment #5, patch #3560 (project freeciv): As with any other gtk-setting, gtk-button-images can be set in settings.ini accompanying gtk.css. Though I stand by what I wrote in patch #3889 (and a few other places) on this topic. ___

[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-05-01 Thread RafałMużyło
Follow-up Comment #3, patch #3889 (project freeciv): One other thing regarding patch #3560: while there is gtk_button_set_always_show_image, it's only since 3.6 and IMHO title of the button is descriptive enough in the context anyway if one has a theme that turns off images on buttons. As for

[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread RafałMużyło
Follow-up Comment #2, patch #3889 (project freeciv): In random order: - gtk_rc_get_theme_dir is an annoyance: it was a concept change in gtk3, css themes are read from by default from paths hardcoded on (gtk+) build time (i.e. ${prefix}/share/themes), so there's no real equivalent for it -

[Freeciv-Dev] [bug #20772] City dialog unit lists too short vertically if unpopulated, don't grow if a unit is added

2013-04-29 Thread RafałMużyło
Follow-up Comment #1, bug #20772 (project freeciv): I think the rows should be of constant height regardless of whether they contain any units First of all, it seems these scrolled windows *can't* be of constant height, not with GTK_POLICY_AUTOMATIC, unless you want to query the theme for

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2013-04-08 Thread RafałMużyło
Follow-up Comment #141, patch #3469 (project freeciv): OK, this is the patch fixing the typo. Should be god for both S2_4 and trunk. (file #17714) ___ Additional Item Attachment: File name: 0001-fix-rates-dialog-typo.patch Size:0 KB

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

2013-04-08 Thread RafałMużyło
Follow-up Comment #2, bug #20706 (project freeciv): Ah, no. 110% is deliberate - not by my design, it's freeciv that reports 110% to indicate a special condition. I remember stumbling upon this back when I was writing those patches, but I no longer recall what condition exactly was it.

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

2013-04-08 Thread RafałMużyło
Follow-up Comment #4, bug #20706 (project freeciv): Well, it would be much easier if I could remember where I've seen that special condition (IIRC, 110% was not a real value, but an indicator of a special status (civil war ?)), nevertheless 110% was already valid before my patch - the marks just

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

2013-04-08 Thread RafałMużyło
Follow-up Comment #6, bug #20706 (project freeciv): open rates dialog and rates setting icons in left panel are no way linked They never were AFAIK. Rates dialog checks the values only upon its creation. Trying to synchronize them would make the code much more complicated for very little gain.

[Freeciv-Dev] [bug #20097] Use GtkOrientation (migrate from gtk2) and fix GdkModifierType mask handling

2013-04-07 Thread RafałMużyło
Follow-up Comment #6, bug #20097 (project freeciv): Do we expect that to have fixed all issues reported in this ticket? Well, yes and no. As I repeated in a few bugs here, the way freeciv is using 'row-activated' signal was never was never really correct, so I don't see any proper fix for that

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2013-03-27 Thread RafałMużyło
Follow-up Comment #140, patch #3469 (project freeciv): ...and this is why having your own patches rechecked by someone else is a good thing. Back in trunk patches, I've made a minor typo, that I've later noticed and fixed in S2_4 branch, but the fix never made trunk and as such the typo is still

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2013-03-02 Thread RafałMużyło
Follow-up Comment #91, patch #3469 (project freeciv): This is what I have on my 2.4 branch. It includes all the patches that got into trunk and a few that didn't. Obviously, cherry-picking Use g_strdup_printf() or g_strdup()... patch has muddled the patchset a bit and is probably not really

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-28 Thread RafałMużyło
Follow-up Comment #6, bug #20565 (project freeciv): Well, of course it's a reserved name - that's why it was used there. EXTRA is a valid *prefix* for _DEPENDENCIES variables - see i.e. 'info automake1.11 Linking'. ___ Reply to this item

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-27 Thread RafałMużyło
Follow-up Comment #4, bug #20565 (project freeciv): Which version of automake are you using ? AFAICT, while the construct does look redundant in this particular case, it's nevertheless valid (that is, it shouldn't trigger an error). Regarding the fixes: while they look OK, it seems that

[Freeciv-Dev] [bug #20534] Worklist glitch: unit icons bleed past their boundaries

2013-02-27 Thread RafałMużyło
Follow-up Comment #2, bug #20534 (project freeciv): Going deeper into the code, it could hint to a problem with gdk_pixbuf_composite in canvas_put_sprite, but hard to tell without more testing. My guess would be you're hitting following documented case: When the destination rectangle contains

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2013-02-27 Thread RafałMużyło
Follow-up Comment #89, patch #3469 (project freeciv): Actually, most of my testing was done on 2.4 branch, so I still have my changes rebased on top of S2_4 branch. Though I did cherry-pick a few other patches from trunk, including one or two that I probably didn't need that much, so you'd need

[Freeciv-Dev] [patch #3572] Use grids for voteinfo_bar

2012-12-11 Thread RafałMużyło
Follow-up Comment #1, patch #3572 (project freeciv): Actually, I couldn't really test it either - didn't really know how to force displaying that bar for longer than a moment it appears during a single player game. I don't see anything that would be *obviously* wrong with it though. However,

[Freeciv-Dev] [patch #3561] Use grids for supported/present units (patch 27/60)

2012-11-16 Thread RafałMużyło
Follow-up Comment #1, patch #3561 (project freeciv): A screenshot please. I don't see that on trident, cimpletoon nor amplio2. ___ Reply to this item at: http://gna.org/patch/?3561 ___

[Freeciv-Dev] [patch #3564] Use grids in helpdlg (patch 28/60)

2012-11-16 Thread RafałMużyło
Follow-up Comment #1, patch #3564 (project freeciv): Oops. I had that correct on S2_4 - not quite sure why wasn't that cherry-picked there correctly. Anyway, it seems to be just a matter of a single line. (file #16764) ___ Additional

[Freeciv-Dev] [patch #3566] Use grids for worklists (patch 31/60)

2012-11-16 Thread RafałMużyło
Follow-up Comment #1, patch #3566 (project freeciv): Are you sure this patch plays a role here ? It shouldn't affect anything but packing (and nothing in its content suggests it could). While at the first I seem to have reproduced the problem, I've noticed a warning in the terminal:

[Freeciv-Dev] [patch #3561] Use grids for supported/present units (patch 27/60)

2012-11-16 Thread RafałMużyło
Follow-up Comment #3, patch #3561 (project freeciv): Ahthis thing. IIRC, when combined with use grids in citydlg overview page patch, the size goes back to something reasonable - all that's left is (a gap for) the scrollbar. ___ Reply

[Freeciv-Dev] [patch #3560] Use standard button interface (patch 21/60)

2012-11-16 Thread RafałMużyło
Follow-up Comment #3, patch #3560 (project freeciv): Well, we could just set this to true in the theme. Note, that there are other places already affected by this setting - that screenshot in patch #3561 suggests you didn't notice that.

[Freeciv-Dev] [patch #3558] Fix applying font style (patch 19/60)

2012-11-13 Thread RafałMużyło
Follow-up Comment #1, patch #3558 (project freeciv): Actually, this is a dupe of a part of bug #19900, though this patch might be more recent. Also, I need to change this patch a bit - using GtkSettings wasn't needed, there's a more straightforward way to get the needed PangoFontDescription.

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-11-13 Thread RafałMużyło
Follow-up Comment #46, patch #3469 (project freeciv): In the meanwhile, patch 25/60 has slightly changed. Attaching updated version. (file #16756) ___ Additional Item Attachment: File name: 0025-use-grids-in-gui_main.c.patch Size:16 KB

[Freeciv-Dev] [patch #3558] Fix applying font style (patch 19/60)

2012-11-13 Thread RafałMużyło
Follow-up Comment #2, patch #3558 (project freeciv): OK, this is the updated version. It gets PangoContext from toplevel widget, instead of checking GtkSettings. (file #16757) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #3560] Use standard button interface (patch 21/60)

2012-11-13 Thread RafałMużyło
Follow-up Comment #1, patch #3560 (project freeciv): Actually, that probably means it does work. The answer may lie in gtk-button-images from GtkSettings. As it's a standard button now, it follows the theme. ___ Reply to this item at:

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-11-12 Thread RafałMużyło
Follow-up Comment #7, patch #3550 (project freeciv): Made a minor thinko in file #16747 - corrected now. (file #16752) ___ Additional Item Attachment: File name: 0001-modify-selection-rectangle-drawing.patch Size:2 KB

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-11-11 Thread RafałMużyło
Follow-up Comment #3, patch #3550 (project freeciv): In case of update_rect_at_mouse_pos, the problem comes down to a simple thing - the function signature is 'void update_rect_at_mouse_pos(*void*)'. The already stated reason comes into play, the same one I was against

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-11-11 Thread RafałMużyło
Follow-up Comment #5, patch #3550 (project freeciv): Well, it seems we don't quite understand each other, but OK. I went with the extreme duplication instead. You'll see what I mean once I'll attach updated version of both patches. ___

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-11-11 Thread RafałMużyło
Follow-up Comment #6, patch #3550 (project freeciv): As noted, I've decided if there's no good way to do it, I'll stick with a model that sort of works. I've still merged the active content of update_rect_at_mouse_pos into the calbacks that used it, but updated the old code in regard of

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-10-20 Thread RafałMużyło
Follow-up Comment #1, patch #3550 (project freeciv): Well, TBH, there's one major catch here: while things work as-is both in gtk2 and gtk3 clients, technically they only do that due to luck. Even back in gtk2 its devs stressed that *all* of the drawing should be done in 'expose-event' handler.

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-09-09 Thread RafałMużyło
Follow-up Comment #24, patch #3469 (project freeciv): When looking at row-selected description, it seems to me it can't be made to both act as it currently does and coded correctly: * The row-activated signal is emitted when the method * gtk_tree_view_row_activated() is called or the user

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-09-08 Thread RafałMużyło
Follow-up Comment #23, patch #3469 (project freeciv): This tarball carries complete patchset against r21858 trunk. There are quite a few patches here, that are already attached to other bugs/patches here, but there are just too many changes already to show the current state in any other way.

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-09-03 Thread RafałMużyło
Follow-up Comment #22, patch #3469 (project freeciv): I've been a little busy lately, so the progress is a bit slower than I expected. On the other hand, as I'm reviewing my own changes, I notice a few places I can improve them. I.e., for all those little rants about TOCTOU, I was doing the

[Freeciv-Dev] [patch #3519] sound.m4 CFLAGS vs CPPFLAGS issue

2012-09-01 Thread RafałMużyło
Follow-up Comment #1, patch #3519 (project freeciv): This change looks correct - probably it was meant to look like that in the first place. ___ Reply to this item at: http://gna.org/patch/?3519

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-28 Thread RafałMużyło
Follow-up Comment #14, bug #20095 (project freeciv): Well, on S2_4 the patch looks differently, mainly due to tree moves and freciv-web. This one is same revision, for S2_4. Your new error regards readline. (file #16448) ___ Additional

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-28 Thread RafałMużyło
Follow-up Comment #15, bug #20095 (project freeciv): The last part of my last comment was a bit silly. I should have said the new problem is due to the change from patch #3436 and regards readline. ___ Reply to this item at:

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-28 Thread RafałMużyło
Follow-up Comment #18, bug #20095 (project freeciv): On an interesting note, each of these patches seems to make those three lua *_AS_DEPENDENCY vars redundant for their respective trees. I wonder though: is there any reason (other than not compiling the file twice) for not simply listing

[Freeciv-Dev] [bug #20097] Use GtkOrientation (migrate from gtk2) and fix GdkModifierType mask handling

2012-08-27 Thread RafałMużyło
Follow-up Comment #3, bug #20097 (project freeciv): @comment #2: That's exactly what I've meant by I can't reproduce - this works correctly here, even if the code isn't really correct. ___ Reply to this item at:

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-27 Thread RafałMużyło
Follow-up Comment #6, bug #20095 (project freeciv): Perhaps a silly question, but does OS X have a *separate* libm ? (IIRC, that's a valid question for i.e. OpenBSD (or was that just about were *some* of math functions are ?)) Also, both LUA_AS_DEPENDENCY and LUA_LIBS carry '-lm'. As for the

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-27 Thread RafałMużyło
Follow-up Comment #7, bug #20095 (project freeciv): Looking at tolua-5.1/src/bin/Makefile.am again, *unless* I'm missing something, after changing _LDFLAGS to _LDADD it would seem tolua_DEPENDENCIES are redundant - see if removing it helps.

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-27 Thread RafałMużyło
Follow-up Comment #10, bug #20095 (project freeciv): What about what I've wrote in comment #7 ? After all, the reason dependencies were not computed correctly before was exactly that those libs were passed via _LDFLAGS instead of _LDADD.

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-27 Thread RafałMużyło
Follow-up Comment #11, bug #20095 (project freeciv): ...also passing '-lm' to libtolua_la_LIBADD (if it's actually needed there and not for liblua itself) should make it easier to propagate it down the tree. ___ Reply to this item at:

[Freeciv-Dev] [bug #20095] Compilation fails during tolua-5.1

2012-08-27 Thread RafałMużyło
Follow-up Comment #12, bug #20095 (project freeciv): OK, it's better to write the patch on your own. This is against trunk r21843. freeciv-server, freeciv-manual, freeciv-modpack and gtk2/gtk3 clients seems to build correctly with it. Please test. (file #16445)

[Freeciv-Dev] [bug #19900] Font preferences not respected

2012-08-26 Thread RafałMużyło
Follow-up Comment #8, bug #19900 (project freeciv): I've looked at the patch from comment #7 again and noticed it could be simplified. At the same time I've decided to split it into two parts - one for the font and the other for style unrelated to the font. A word of explanation about

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-25 Thread RafałMużyło
Follow-up Comment #21, patch #3469 (project freeciv): News update: git 1.7.12 was released. It's with svn 1.7 patch here, so I'm slowly working on separating the changes I've already made (and tweaking them a little) into a series of git patches. Unless something significant happens, within a

[Freeciv-Dev] [bug #20097] Use GtkOrientation (migrate from gtk2) and fix GdkModifierType mask handling

2012-08-25 Thread RafałMużyło
Follow-up Comment #1, bug #20097 (project freeciv): Take note of patch #3469, thank you. As for that part about Control key, I can't reproduce, but I'm aware of the problem; there's no good solution yet - that signal wasn't meant to be used that way.

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-12 Thread RafałMużyło
Follow-up Comment #20, patch #3469 (project freeciv): Due to previously mentioned reasons, things are a bit stuck right now, but I've ran a little test today in regard of create_line_at_mouse_pos. It's already redundant - move_mapcanvas and move_overviewcanvas already cover it. Though it might

[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-08-11 Thread RafałMużyło
Follow-up Comment #3, bug #19846 (project freeciv): Well, right now I've got the client nearly in pieces (mostly due to gridding - nearly done now, just restoring the spacing and minor tweaks left), but it seems my first comment was on the spot - due to the order of signals being undefined,

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-05 Thread RafałMużyło
Follow-up Comment #11, patch #3469 (project freeciv): Well, here's a funny thing: while tinkering with update_rect_at_mouse_pos, I thought I've made a regression, but gtk2 client seems to have the same problem. Holding right mouse button, select an area. Without releasing the button, scroll with

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-05 Thread RafałMużyło
Follow-up Comment #13, patch #3469 (project freeciv): Now, for something bit annoying, for a change: kind of similar test, but in c case, in gtk3 client leads to not quite correct display till mapcanvas gets redrawn - I'm not sure if it's related to my changes or not. But in gtk2 client, it

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-05 Thread RafałMużyło
Follow-up Comment #14, patch #3469 (project freeciv): @comment 12: I want to put something like: { GdkModifierType state; gdk_device_get_state(ev-device, ev-window, NULL, state); if (rbutton_down (state GDK_BUTTON3_MASK)) { update_selection_rectangle(ev-x, ev-y); } } in

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-05 Thread RafałMużyło
Follow-up Comment #16, patch #3469 (project freeciv): I've made those changes in gtk3 client, not gtk2, where the permanent grab happens. (and I didn't exactly ask what does center_tile_mapcanvas do ?, but more along the lines of is there anything I should know about update_rect_at_mouse_pos in

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-05 Thread RafałMużyło
Follow-up Comment #19, patch #3469 (project freeciv): Seems a more detailed description is necessary: - select a unit - right click on a tile, that's far enough to make a visible difference but still being able to see the unit - press and hold right mouse button, drag to select an area - without

[Freeciv-Dev] [patch #3472] Road help browsing

2012-08-04 Thread RafałMużyło
Follow-up Comment #4, patch #3472 (project freeciv): OK, as it seems this one will get merged long before I'm done with grids, I'll just edit it after it's merged. I hope git 1.7.12 will once again have a fully functional 'git svn' module.

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-04 Thread RafałMużyło
Follow-up Comment #10, patch #3469 (project freeciv): I've made not-quite-a-typo in the first version of the second - it worked, but generated new compiler warnings. (file #16300) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-03 Thread RafałMużyło
Follow-up Comment #8, patch #3469 (project freeciv): I'm tempted to do something really annoying from common client code side of view - implement update_rect_at_mouse_pos as '{}' and just handle it in move_mapcanvas. Initial tests look good - that is as I select things with mouse, the rectangle

[Freeciv-Dev] [patch #3478] Salt water filling freshwater lake when connected

2012-08-03 Thread RafałMużyło
Follow-up Comment #1, patch #3478 (project freeciv): With tongue in cheek, I'd say that's what would happen in the real world, barring significant height difference. ___ Reply to this item at: http://gna.org/patch/?3478

[Freeciv-Dev] [patch #3478] Salt water filling freshwater lake when connected

2012-08-03 Thread RafałMużyło
Follow-up Comment #2, patch #3478 (project freeciv): Ah, sorry - should have read the patch first. You meant this patch should implement this effect. ___ Reply to this item at: http://gna.org/patch/?3478

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-03 Thread RafałMużyło
Follow-up Comment #9, patch #3469 (project freeciv): I hope that whatever issues there are lately in 'git svn', they'll going to get reasonably fixed soon, cause that's likely the most simple solution on my side - I'll simply import svn repo into git then. Anyway, there has been some progress in

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-02 Thread RafałMużyło
Follow-up Comment #4, patch #3469 (project freeciv): I think I'll use this place for a staging ground. step 1: some of the trivial things (scrolbars, separators) and simple things (gdk_pointer_grab,gdk_display_pointer_ungrab - simple due to being done in the right calbacks) (those two .drawable

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-02 Thread RafałMużyło
Follow-up Comment #5, patch #3469 (project freeciv): So, step 2 will regard the simple part of gdk_window_get_pointer - in chatline .c, one call was doing nothing, the other was connected to a signal that seems to have been redundant (AFAICT, things work correctly without handling that signal) -

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-08-02 Thread RafałMużyło
Follow-up Comment #7, patch #3469 (project freeciv): It's bit hard to separate, as I'm a bit low on on disk space on this machine and svn is not git, so I've only have branch-2.4 checked out. ___ Reply to this item at:

[Freeciv-Dev] [patch #3472] Road help browsing

2012-08-01 Thread RafałMużyło
Follow-up Comment #2, patch #3472 (project freeciv): As I already mentioned in patch #3469, as gtk+ 3.4 is the target, grids should be used instead of tables - in such simple case, there's very little difference API-wise. Also, a question: in regard of a different patch/bug (can't find the

[Freeciv-Dev] [bug #19882] Help browser opening on turn change if help checkbox checked in research dialog

2012-08-01 Thread RafałMużyło
Follow-up Comment #1, bug #19882 (project freeciv): Just a note, so *I* won't forget it - this seems to affect gtk2 client too. The signal is connected to the changed signal of the combobox - that one can be emitted not just on interactive changes, but (AFAICT) also if i.e. model gets changed,

[Freeciv-Dev] [patch #3376] fix for premultiplied alpha

2012-08-01 Thread RafałMużyło
Follow-up Comment #4, patch #3376 (project freeciv): gna tends to fail at a few things - i.e. its mail/svn hooks tend to mangle utf8 strings quite a bit. ___ Reply to this item at: http://gna.org/patch/?3376

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-07-31 Thread RafałMużyło
Follow-up Comment #2, patch #3469 (project freeciv): Thank you, but I'd rather not. First of all, the list of deprecation warnings is a bit incomplete, as we're targeting 3.4 and the list covers only 3.2 (due to a quirk of how are bounds for those warnings defined). Second, related to first,

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-07-31 Thread RafałMużyło
Follow-up Comment #3, patch #3469 (project freeciv): Also, there's a little thing I've missed in the initial port (mainly cause it was still hybrid then) - except for most gdk_window_get_pointer calls, those calls can be made far more simple via the content of events they handle.

[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong

2012-07-29 Thread RafałMużyło
Follow-up Comment #1, bug #2 (project freeciv): I suspect the only mistake could be relying on some side effect of running in expose-event. Attaching something that seems to fix the problem. The second block is just a minor gtk3 cleanup. (file #16233)

[Freeciv-Dev] [bug #19900] Font preferences not respected

2012-07-26 Thread RafałMużyło
Follow-up Comment #5, bug #19900 (project freeciv): OK, as patch #3433 was merged, it's time to polish this one. It does what the initial one did and cleans up old API. It also touches info_label_style in citydialog.c, as while it's not quite topic related, it *is* API related. On that note:

[Freeciv-Dev] [bug #19900] Font preferences not respected

2012-07-26 Thread RafałMużyło
Follow-up Comment #6, bug #19900 (project freeciv): ...and for a difference, on a topic related note, a minor fix for help label colors - value taken from old Freeciv.h. (that line for font in tooltip doesn't seem to work, but the colors do) (file #16199)

[Freeciv-Dev] [bug #19900] Font preferences not respected

2012-07-26 Thread RafałMużyło
Follow-up Comment #7, bug #19900 (project freeciv): Alright, it's hard to affect a tooltip, if it's not really a tooltip. I was looking at the info popups in city dialog - setting them to monospace makes the formating work again. (file #16201)

[Freeciv-Dev] [patch #3442] limit the use of sprite_get_pixbuf

2012-07-24 Thread RafałMużyło
URL: http://gna.org/patch/?3442 Summary: limit the use of sprite_get_pixbuf Project: Freeciv Submitted by: galtgendo Submitted on: Tue 24 Jul 2012 11:20:30 PM CEST Category: client-gtk-3.0 Priority: 5 -