Re: [Freeciv-Dev] (PR#40113) multi-player connection missing client.playing during nation selection

2008-02-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Madeline Book wrote: ... In the case where the client's player is then created (attach_connection_to_player(pconn, NULL) returns TRUE, server/connecthand.c +137) the server does not notify the client that its game.info.player_idx has

Re: [Freeciv-Dev] (PR#40113) connection missing client.playing during nation selection

2008-02-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 I indicated earlier in the discussion thread where you added the revised test that is now failing, because the two pointers are updated by different packets and apparently aren't always equal I assumed you had a reason for making

[Freeciv-Dev] (PR#40115) vestigial game.info.player_idx removal

2008-02-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40115 Almost all references to game.info.player_idx were eliminated in PR#39872. This removes the remaining 9 instances in 6 files. While investigating, another bug was discovered! When players are renumbered during pre-game,

Re: [Freeciv-Dev] (PR#40115) vestigial game.info.player_idx removal

2008-02-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40115 Committed trunk revision 14425. Committed S2_2 revision 14426. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40113) multi-player connection missing client.playing during nation selection

2008-02-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 It was too hard to do it all in one patch. Please check whether the current revision fixes your problem? I'll finish removing the duplicates later ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#40113) connection missing client.playing during nation selection

2008-02-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Madeline Book wrote: If only I knew of some way to find the relevant PR#s (besides PR#39872)! How do you suggest I go about doing that? I am not very good yet with RT's search capabilities. Please re-read the thread, either in your

Re: [Freeciv-Dev] (PR#40114) vestigial city_map removal from client/agents/cma_core.c

2008-02-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40114 Committed trunk revision 14423. Committed S2_2 revision 14424. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40111) Diplomatic immunity

2008-02-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40111 Per I. Mathisen wrote: It is not a bug. Also, making diplomats partially invisible would upset a game balanced already tilted too much in favour of diplomats and spies as it is. Madeline didn't write that. I did. And we already

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Now that I've had some sleep Madeline Book wrote: Yes, I was afraid of something like that. So what are the semantics of client.playing? It is set from game.info.player_idx -- exclusively. Is it supposed to be NULL when the

Re: [Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 Madeline Book wrote: I mean a server setting (in server/settings.c) like savepalace or killcitizen, I don't see why this should be for things (?) that change only from ruleset to ruleset Neither should be server

[Freeciv-Dev] (PR#40111) Diplomatic immunity

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40111 Madeline Book wrote: Spies and diplomats do not have the Partial_Invis flag. This is a bug. These units should not show up until adjacent to cities, and should be completely invisible to passing units.

[Freeciv-Dev] (PR#40112) air units and submarines affecting city workers

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40112 Madeline Book wrote: for stealth fighters/bombers, consider that submarines can in fact be detected by their effect on city workers when their controlling player is foolish enough to move them into the field of the enemy city

[Freeciv-Dev] (PR#40114) vestigial city_map removal from client/agents/cma_core.c

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40114 This is the last substantive use on the client side. For unknown reasons, it parallels code in common/aicore/cm.c -- which is called and over-writes the calculations! The only advantage is this code has some debug counting and logging;

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Cannot duplicate, running client with internal server. Tried random nation button (my usual test), random nation button on nation dialog, and picking specific nation. All work. ___

Re: [Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 Madeline Book wrote: Unfortunately for you, posting a comment about a side-effect of your patch does not imply that the person posting the comment tested your patch. But never fear, there is PR#40113. Unfortunately for all of us,

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 This appears to be wrong. This might set client.playing for an observer, which would violate quite a bit of existing logic. It should not be possible for an observer to pick a nation. Is that what you tried? (You didn't mention that

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 I have examined all instances of send_conn_info(), and with one exception, they seem to come after send_player_info() -- which is how client.playing is set. Please post the exact commands that you send. And have you tested with any

[Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 The first and most obvious part of the patch updates the tile/vision documentation somewhat, as it was woefully out of date! Renamed some of the enum known_type to reflect their source, and replaced the order dependent = = tests.

Re: [Freeciv-Dev] (PR#40110) tile_info worked, enum known_type, city_can_work_tile(), and invisible cities

2008-02-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40110 Madeline Book wrote: And as for appealing to realism (I assume that is what you mean by usual expectations, I meant the actual behavior of civ1/2/3. We only need options for things that change from ruleset to ruleset. Does an air

Re: [Freeciv-Dev] (PR#39872) Re: game.player_ptr should be moved to client.playing

2008-02-22 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39872 Originally had thought about client.player, but changed it to .playing after considering the meaning. In freeciv, player is the civilization, not the user. That's what's somewhat confusing. The clients are playing (or observing) the

Re: [Freeciv-Dev] (PR#40106) tile_info with worked, adjust field order and size

2008-02-22 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40106 Committed trunk revision 14419. Committed S2_2 revision 14420. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40105) vestigial tile spec_sprite removal

2008-02-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40105 I'm completely unable to find anywhere that documents why spec_sprite is actually useful?!?! /* Skip the normal drawing process. */ /* FIXME: this should avoid calling load_sprite since it's slow and * increases the refcount

[Freeciv-Dev] (PR#40106) tile_info with worked, adjust field order and size

2008-02-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40106 Currently, the worked tile fields are not sent. Instead, the worked pointers are set using the city_info packet city_map[]. This patch merely passes the worked city id value. A future patch will change the client to use the field.

Re: [Freeciv-Dev] (PR#40101) minplayers typo

2008-02-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40101 I tried to figure out how that came into the code base, and wasn't successful. It's not in 2.0, and none of my searching found it. Ah well, I wish all our problems were so easy to solve Thanks! Committed trunk revision 14412.

Re: [Freeciv-Dev] (PR#40100) vestigial city_map removal

2008-02-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40100 Just noting in passing that there's Yet Another Copy of the city worker in citymap.c, this time as an -(pcity-id). What a mess! We have a citymap (whole world), city_map for each city, the world tiles, and player tiles With

[Freeciv-Dev] (PR#40098) BUG: 2.2-test myrandomly() range check

2008-02-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40098 In PR#40073, I moved the code from client/tilespec.c into utility/rand.c, but now it seems to assert() on larger maps. Changed the assert() to allow larger values. And use standard header definitions! Index: utility/rand.c

Re: [Freeciv-Dev] (PR#40098) BUG: 2.2-test myrandomly() range check

2008-02-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40098 Committed trunk revision 14405. Committed S2_2 revision 14406. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40099) BUG: 2.1 assert() failure attacking a city

2008-02-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40099 An assert() failure is *always* a bug! It's something the developer added to test and any such failure should never happen. Could you reply with the message, and attach the savegame? ___

Re: [Freeciv-Dev] (PR#40096) deterministic borders (part 2)

2008-02-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40096 After more testing, the previous patch still expanded the range much too quickly, so I've scaled it some more, with every size having some effect. Here's the list for borders 4: City 2.1now Size r**2 r**2 1 4 2

[Freeciv-Dev] (PR#40100) vestigial city_map removal

2008-02-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40100 I've asked on the developers list, and nobody knows a reason for this anachronistic structure. Any time there are 2 different copies of the same data, there's bound to be trouble keeping them synchronized. The server side doesn't

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Thank you for finding my mistake in PR#39553! This worthless function is only called 4 places, and the first place I've looked is: ai/advmilitary.c:1223: if (best_choice.want choice-want) { /* We want attacker more than what

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Here's my proposed patch to rid us of this troublesome beast Index: ai/advdomestic.c === --- ai/advdomestic.c(revision 14391) +++ ai/advdomestic.c(working copy)

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 OK, seems reasonable. I'd say commit. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40092) 2.2-test: fix update_dumb_city() missing update_vision_site_from_city()

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40092 In PR#40072, the second reported error has Teotitlan shown with the wrong owner. This patch does not fix the underlying issue, but is a step toward making the savegame playable. The savegame.c:2800 code tries to fix inconsistent games.

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything (fix)

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Not having seen anything in 12 hours, and the proposed patch being so trivial, Committed trunk revision 14396. Committed S2_2 revision 14397. Thanks, Marko! ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#40086) city center tiles not worked, bad sanity check repair?

2008-02-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40086 Define FREE_WORKED_TILES for counting is_free_worked_tile(), currently only 1! Should generalize in rulesets? Fix real_sanity_check_city() to prevent removing city workers for any is_free_worked_tile(). Should consolidate with other

[Freeciv-Dev] (PR#40088) 2.2-test: wrong city size after attack

2008-02-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40088 This is implied by the sanitycheck repair in PR#40086, that presumably happened in the PR#40072 savegame. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#40086) city center tiles not worked, bad sanity check repair?

2008-02-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40086 Leaving open, as this needs to to be retrofitted for 2.1, too. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40087) client needs sanity check and other server log messages

2008-02-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40087 Moved the existing ruleset_error() intercept into the con_handle_log() callback, so that server log messages can be sent to all connections. Currently, only LOG_FATAL and LOG_ERROR. Renamed E_MESSAGE_WALL to E_LOG_FATAL, as that was

[Freeciv-Dev] (PR#40087) client needs sanity check and other server log messages

2008-02-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40087 Rewrite sanitycheck, and intercept other freelog() error and fatal messages. Send via the Chat/Event message interface. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#40086) 2.2-test: city center tiles not worked

2008-02-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40086 Jason Dorje Short wrote: The CM code is in common/aicore/cm.c. Well, I've spent a bit of time looking at that, and its pretty difficult. Whomever wrote that was a genius, or an idiot Anyway, using the old tried and true

Re: [Freeciv-Dev] (PR#40085) add maxconnectionsperhost option

2008-02-06 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40085 Somebody had sent me private email bragging about his/her DoS against some game server, and telling me this was needed. I didn't bother to reply. Anyway, per host blocking will adversely affect NATs and VPNs. The real DoS problem is

Re: [Freeciv-Dev] (PR#40072) 2.2-test: map displays wrong nation for enemy city

2008-02-06 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40072 An interesting savegame -- it reproducibly demonstrates three different bugs! Two of which are detailed in the report. In the savegame file, Tenochtitlan: the city id (176) hasn't changed. originally owned by player1 Aztec

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40075 Michael Kaufman wrote: On Mon, Feb 04, 2008 at 07:49:58PM -0800, Jason Dorje Short wrote: ... Why not just use the ptile-index as the city id? ... ... without knowing the tile location that the city sits on (the capital city?)

[Freeciv-Dev] (PR#40080) replace city id with tile pointer or index

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40080 In PR#40075, Jason Dorje Short wrote: ... Why not just use the ptile-index as the city id? Cities can't ever move and there can't ever be more than once city on a tile...right? ___

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything (log)

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 #defined LOG_WANT symbol, moved other local LOG_* to front of file Does not fix anything other than logging! Committed trunk revision 14384. Committed S2_2 revision 14385. Leaving open for future examination by others. This code is

Re: [Freeciv-Dev] (PR#40080) [tracking] replace city id with tile pointer or index

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40080 William Allen Simpson wrote: There are at least 148 *city-id references in 44 files (and untold others with other pointer names). This is a seriously daunting task! The agents.c code passes city ids around. 284 references

[Freeciv-Dev] (PR#40084) identity_number, server.game_identifier, city_tile(), unit_tile()

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40084 Some of the preliminary steps toward the PR#40080 long-term goal. This patch mostly clears the decks for shorter-term crashing bug fixes. It includes some code already in 2.1 (PR#39980), used for initializing the game_identifier.

Re: [Freeciv-Dev] (PR#40084) identity_number, server.game_identifier, city_tile(), unit_tile()

2008-02-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40084 Forgot to mention that it fixes the bug already reported in PR#40080, increasing the ai-stats.diplomat_reservations bit vector from 32767 (wrong) to 65536. Better not to overflow, even as a better solution may be developed in the

[Freeciv-Dev] (PR#40079) BUG! city unit ids not reserved, counter not saved/restored

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40079 While poking at the memory problems, tried moving city ids to avoid the possible overrun, and was checking how ids were allocated. Discovered that the running game never marks the used id numbers! And never checks they've run out of id

Re: [Freeciv-Dev] (PR#40079) BUG! city unit ids not reserved, counter not saved/restored

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40079 Committed trunk revision 14381. Committed S2_2 revision 14382. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Found the old report and merged with it. Added some PR# links, instead of the revision numbers Marko used in the report. Funny, I've been waiting for Marko to fix this, as it's his original report, but now I see that Per flagged it

Re: [Freeciv-Dev] (PR#40069) end_turn() = map_calculate_borders() has bad site-location

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40069 Jason Dorje Short wrote: If this value is on the stack, what is right next to it that might be overrun in memory? It's on the heap. It could be anything I've tried swapping the name back to front so that gets overrun instead,

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40075 Jason Dorje Short wrote: I got this with chris's recent savegame but I have no idea if it's related. Attached is the previous savegame; no clue if it's reproducable. It helps pinpoint one of the potential problems from PR#40068

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40075 William Allen Simpson wrote: ==12774== Address 0x5391ca0 is 0 bytes inside a block of size 76 free'd ==12774==at 0x402365C: free (vg_replace_malloc.c:323) ==12774==by 0x80E6669: reality_check_city (citytools.c:1792

Re: [Freeciv-Dev] (PR#40070) common/effect.c get_city_bonus() with NULL city

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40070 This will be applicable to all branches! In 2.1, has 60 occurrences in 20 files. In 2.2, has 63 occurrences in 23 files. In this case, the code already has a FIXME over two years old! It clearly indicates: /* It is a virtual

Re: [Freeciv-Dev] (PR#40069) end_turn() = map_calculate_borders() has bad site-location

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40069 In this report, tile0=0x2b. In PR#40068, tile0=0x4, and the client crashed, too. Let's keep this separate, to deal with the border recalculation issue. ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#40070) common/effects.c get_city_bonus() with NULL city

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40070 In this case, the traceback clearly shows the NULL city: city_owner (pcity=0x0) at city.c:654 That's properly failing checks added by PR#39998 and PR#39895 respectively: assert(NULL != pcity NULL != pcity-owner); But for the

Re: [Freeciv-Dev] (PR#40068) client gtk_progress_set_percentage() assertion

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40068 Jason Short wrote: Saving and loading doesn't generally give identical AI behavior so if this is caused by AI units moving or something then you won't get the same behavior from the savegame most likely. I've argued about this

Re: [Freeciv-Dev] (PR#40068) client gtk_progress_set_percentage() assertion

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40068 Christian Knoke wrote: These 2 messages needn't necessarly be connected. I just copied the outbut on the terminal after the crash. Yes, and that's excellent bug reporting practice! That tells us that the client asserted sometime

Re: [Freeciv-Dev] (PR#40071) i18n: review LOG_FATAL and freeciv.org

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40071 Committed trunk revision 14376. Committed S2_2 revision 14377, with update-po to add TRANS comments. Reminder, ./autogen.sh before make! ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#40073) BUG: 2.2-test AI building_want random interval not saved/restored

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40073 There's a problem with reproducing reports for 2.2 savegames. Over the past 9 months, I've spent considerable time improving the reproducibility of 2.1 (PR#39365, PR#39572, etc.) Searching for myrand() differences between 2.1 and 2.2,

Re: [Freeciv-Dev] (PR#40072) map displays wrong nation for enemy city

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40072 Thanks, looking ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40025) Happiness plurals

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40025 Christian Knoke wrote: This is in there since some time of 2.1. Something has been changed intendedly, I don't remember what it was. Wasn't paying much attention at the time, but it made the empire happiness code actually work! As

Re: [Freeciv-Dev] Request: Option for behavior of specials while terraforming in game setup?

2008-02-03 Thread William Allen Simpson
Jonathan Kaplan wrote: ... but what would be ideal would be putting a *large* range of options available as a user-controlled setting. Shudder. That's horrible. How do you test? Remember, this has to handle civ1/2/3-like games, so civ1 Swamp resource Oil has to turn into civ2 Peat, and

Re: [Freeciv-Dev] (PR#40073) BUG: 2.2-test AI building_want random interval not saved/restored

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40073 Committed trunk revision 14378. Committed S2_2 revision 14379. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40069) end_turn() = map_calculate_borders() has bad site-location

2008-02-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40069 I've poked and prodded this, and cannot get it to crash again. My guess is that it's an array overrun of some kind from elsewhere, as the -location is the first entry in the common/vision.h struct vision_site{}. The values in the

Re: [Freeciv-Dev] (PR#40068) server crash

2008-02-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40068 Jason Short wrote: Looks to me like this means dsite-location is invalid. I have no familiarity with this code however. That's (my) very new border code. I'll take a look at it. What I don't understand is why it's not

Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages

2008-02-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=10400 This has been waiting since 2004 Oct -- really shouldn't let better be the enemy of good. There are many more LOG_FATAL and LOG_ERROR than LOG_NORMAL. Will do others later, as they are likely reductions in translation rather than more

Re: [Freeciv-Dev] (PR#40063) RFE: increase historian levels to prime number

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40063 Added +1 to ensure only top rank is rated Supreme (unless tied). Added clamp to final entry. Committed S2_2 revision 14364. Committed trunk revision 14365. Index: server/report.c

Re: [Freeciv-Dev] (PR#40064) historian report passes NULL format to cat_snprintf()

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40064 Jason Short wrote: Looks like this is cause by 40063. That would be highly surprising, as PR#40063 had not been committed yet! Anyway, I've just committed it minutes ago, and I'll do some testing now with the savegame provided

Re: [Freeciv-Dev] (PR#40064) historian report passes NULL format to cat_snprintf()

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40064 My trivial patch was only meant to change an existing array from sentence fragments for easier translation. Then, it ballooned from fixed size to variable, and fancier, and Used sizeof() instead of ARRAY_SIZE(). Fixed. Excellent

Re: [Freeciv-Dev] (PR#40062) server/stdinhand.c duplicates server/command.c text

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40062 I looked at cmd_reply_prefix(), and chose not to use it for the Usage: lines. It really isn't multi-lingual friendly. Saved for another ticket. I looked at command_named(). It should be re-written to be more like

[Freeciv-Dev] (PR#40066) i18n: commands and settings text should work for LtR and RtL, and wordwrap

2008-01-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40066 In PR#40043, the disfunctional wordwrap was removed for server/stdinhand.c (stdout) and others. In PR#40062, the Usage: could sometimes use some wordwrap and prettifying. Ideally, the server/commands.c and server/settings.c text should

Re: [Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40058 Jason Short wrote: Patch is fine but the comment is a bit misleading - generally the returned value is passed off to GTK which wants it in UTF-8 (aka the internal encoding). When used in the server this may not be the case. Changed

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 Jason Dorje Short wrote: If you are asking about encodings, gui-sdl uses the call inside freelog which expects the string in the internal encoding (utf-8). OK. Can we remove gui-mui? Already done (2.2 and beyond).

Re: [Freeciv-Dev] (PR#40036) 2.1.2 savegame data loss on rapid saves

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40036 Jason Dorje Short wrote: Unfortunately I don't seem to get this behavior anymore, though people keep reporting its symptoms. Every time I kill my client the server saves the game properly, without aitoggling the human. That

Re: [Freeciv-Dev] (PR#40006) Placeholder strings like %d for gold amount isn't replaced

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40006 As I mentioned in PR#40007, I cannot even get them to display, other than for the OK, Yes, No, and Cancel buttons. Jason says ... the GTK library is using japanese correctly, but freeciv is still using the untranslated strings. I have

Re: [Freeciv-Dev] (PR#40006) Placeholder strings like %d for gold amount isn't replaced

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40006 Christian Prochaska wrote: Did you make install before starting the client? Nope, should not be needed. I'm running the client (with ./civ) in the build directory itself. All the default paths seem to be working: ./data, etc. The

Re: [Freeciv-Dev] (PR#40060) civserver core dump on debug command

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40060 Christian Knoke wrote: debug Speicherzugriffsfehler (core dumped) Unable to reproduce. Works here for both 2.1 and 2.2. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#40062) server/stdinhand.c duplicates server/command.c text

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40062 Originally reported in PR#40061 for the debug command, investigation showed that many of the commands had duplicate command usage synopses. Moreover, the server/commands.c version was often out-of-date. Merge all usage synopses into

Re: [Freeciv-Dev] (PR#40059) BUG: i18n: Publishing year on historian reports

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40059 Based on discussion on the -i18n list, it seems that removing the possessive names is highly desirable. And, that swapping the fields is common. Also, there's a list of sentence fragments immediately following the header. Changed to

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 Marko, the requisite time has passed -- are you committing this, or am I? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 Jason, the requisite time has passed -- are you committing this, or am I? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40020) dead unit in server/plrhand.c maybe_make_contact()

2008-01-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40020 Committed S2_1 revision 14348. Committed S2_2 revision 14349. Committed trunk revision 14350. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 Marko Lindqvist wrote: Includes some generic cleanup-style changes I made while debugging problem. Actual fix is citydlg.c:1621. It was storing improvement pointer instead of number. Original report referring to TRUNK only is

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 Marko Lindqvist wrote: That's why I don't like GTK's generic APIs. You don't have type checking with them. Yeah, and I'm not a gui expert enough to catch them. Here's a slightly better version of the patch, telling the interface a

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40028 Madeline Book wrote: Ha! So that is how it posts duplicate messages. After I submit my reply if I refresh the resulting page it posts the message again. Bleh RT tries hard to be disliked... Firefox tells me that I cannot refresh

Re: [Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40058 After much discussion, here's the simpler version. Examining the actual mystrerror() code, it appears that there are already WIN32_NATIVE and other variants that are non-reentrant. The reentrant version should be separate (as it is on

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 Jason Dorje Short wrote: mystrerror is included in support.c. Two places don't use this but access strerror directly. This patch fixes it (for 2.1). Yes, but gui-mui isn't used anymore, and gui-sdl has it in its local version of

[Freeciv-Dev] (PR#40059) BUG: i18n: Publishing year on historian reports

2008-01-28 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40059 PR#34192 added a trailing year. Not only does that make no sense as English grammar, the patch didn't update all (any) of the translations, and thus creates a msgstr error report. The existing reports use a possessive for the names of

[Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40028 Jason Short wrote: # ... I thought I had written this up somewhere in the code, but I can find # nothing. Where should it be documented? Documenting the code and README.* files. Committed trunk revision 14330. Committed S2_2 revision

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40028 I put the workaround into the doc/README -- and just (re-)discovered that's the *only* method described at: http://freeciv.wikia.com/wiki/Install-MacOSX#Localization_Support There's a different procedure at:

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units = plrhand.c maybe_make_contact()

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40020 Jason Short wrote: make_contact kills the unit because of the broken treaty and bouncing (strange in itself but whatever). Then since maybe_make_contact doesn't use a proper iterator it breaks the loop. Attached patch should fix it

Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40054 Joan Creus wrote: I've noticed that, in the last remodelation of helpdata.c, for trunk and 2.2, three strings which contained 50%% have been changed to 50%. But two of them are still flagged as c-format, That's very odd. The other

[Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40032 Committed as part of trunk revision 14337. Committed as part of S2_2 revision 14338. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40054) Percentages in client/helpdata.c

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40054 Committed as part of trunk revision 14337. Committed as part of S2_2 revision 14338. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40032 Probably should attach the patch as applied to trunk for posterity! (Also in 2.2, an update-po and vigorous line-by-line po massaging.) Index: server/citytools.c === ---

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40028 Jason Short wrote: Here is a quick and partial fix. I assume that strerror() is one of the most common offending functions, so I quickly went through and converted all mystrerror users in client/ and server/ directories to use the

[Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40058 Followup of PR#40028. See earlier patch and objections there. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

  1   2   3   4   5   6   7   8   >