Follow-up Comment #7, bug #18086 (project freeciv):
comment #6 is for S2_3; in trunk the bug is present. Could you please test
the attached patch?
(file #12953)
___
Additional Item Attachment:
File name: 0004-fix-city_repair_size.patch
Follow-up Comment #6, bug #18086 (project freeciv):
That revision do you use? For svn19602 the function header looks like:
/**
Repair the city population without affecting city size.
Used by savegame.c and
URL:
http://gna.org/bugs/?18086
Summary: comparison is always false due to limited range of
data type
Project: Freeciv
Submitted by: akfaew
Submitted on: Sat 30 Apr 2011 08:30:27 AM GMT
Category: None
Follow-up Comment #1, bug #18086 (project freeciv):
This is a bug! I'm woundering why you get an error message and I never did
see it? Do you use special compiler options or the default ones for debug?
Which gcc / distribution do you use?
Some background: I had citizens equal to short int but
Follow-up Comment #2, bug #18086 (project freeciv):
Standard compile with --disable-nls. I don't use debug since warnings are
treated as errors and I get hundereds of warnings from those NULLS in
printfs.
[12:11:pts/10][dude@hopek:~:74] gcc --version
gcc (GCC) 4.2.1 20070719 [FreeBSD]
Follow-up Comment #3, bug #18086 (project freeciv):
692 void city_repair_size(struct city *pcity, citizens change)
I think error is in that change is of type citizens in the first place. I
would try to change it to int.
___
Reply to
Follow-up Comment #4, bug #18086 (project freeciv):
692 void city_repair_size(struct city *pcity, citizens change)
I think error is in that change is of type citizens in the
first place. I would try to change it to int.
Yes; I think this is that I have done for the function citizens_add()
Follow-up Comment #5, bug #18086 (project freeciv):
Also here:
vision_site_size_set found in ./common/vision.c:
134: void vision_site_size_set(struct vision_site *psite, citizens size)
135: {
136: fc_assert_ret(psite != NULL);
137: fc_assert_ret(size = MAX_CITY_SIZE);
138:
