[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-05-03 Thread Marko Lindqvist
Update of bug #19846 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-05-01 Thread Marko Lindqvist
Update of bug #19846 (project freeciv):

  Status:None = Ready For Test 
 Planned Release:2.4.0, 2.5.0 = 2.4.0, 2.5.0, 2.6.0

___

Follow-up Comment #12:

Attached patch avoids the crash. Supposedly this leaves a minor bug that
cursor is sometimes not correctly changed, but I didn't notice any situation
where that happened in my testing. Also, it shouldn't be happening with any
gtk+ version where the code was not crashing before.

(file #17872, file #17873)
___

Additional Item Attachment:

File name: Gtk3UDlgClosed.patch   Size:0 KB
File name: Gtk3UDlgClosed-S2_4.patch  Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-04-27 Thread Jacob Nevins
Follow-up Comment #10, bug #19846 (project freeciv):

 Ubuntu Precise:3.4.2
FWIW, I run this and I get the assertion failures but haven't had the crash
yet.
(Precise is an LTS release, so like Debian Wheezy it will be with us for a
while.)

Comment #6 in January:
 Now works perfectly with my crosser build that uses gtk+-3.6.4. 
 Maybe this is fixed in gtk+ 3.6?
But the note on the upstream bug
https://bugzilla.gnome.org/show_bug.cgi?id=671939 about a patch being
committed was in March (I haven't tried to track down the actual commit and
what releases it went into).

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-04-27 Thread Marko Lindqvist
Follow-up Comment #11, bug #19846 (project freeciv):

 (I haven't tried to track down the actual commit and what
 releases it went into).

commit 5e2c23214564f7dcc687fa8467020eeb6b9407a9
Author: John Lindgren john.lindg...@aol.com
Date:   Wed Mar 13 02:03:45 2013 +0100

treeview: Don't emit cursor-changed in destruction

This is a workaround until we have a good idea on how we want to handle
signal disconnection before/during/after dispose and destroy vfunc
calls.

https://bugzilla.gnome.org/show_bug.cgi?id=671939


So yes, some other change had already fixed the crash problem for our crosser
builds before.


___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-04-23 Thread Marko Lindqvist
Follow-up Comment #8, bug #19846 (project freeciv):

gtk+ bug is now RESOLVED FIXED. That leaves us to figure out how to live with
buggy versions.
What distributions are affected? I know all too well that Debian Wheezy (to be
released 4/5 May weekend) is. Probably recent Ubuntu versions are too
(assuming they have inherited from Debian gtk+ version that has been frozen
for a long time - once Wheezy is out we hopefully get a new version soon).

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-04-23 Thread Emmet Hikory
Follow-up Comment #9, bug #19846 (project freeciv):

Ubuntu and Debian historically diverge in libgtk update timing and history. 
Current revisions in releases:

Debian Wheezy: 3.4.2
Debian Experimental: 3.8.0
Ubuntu Oneiric: 3.2.0
Ubuntu Precise:3.4.2
Ubuntu Quantal: 3.6.0
Ubuntu Raring: 3.6.4

I don't have tooling to get release history for other distributions
installed.  I don't know what to do about Wheezy (would need to meet a fairly
high set of criteria to get applied), but the patch in bugzilla looks small
enough, focused enough, and safe enough that it could probably be released as
part of Precise updates, if that meets the local need.  As with the tooling,
I'm less certain how to arrange this for other distributions.

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

2013-04-21 Thread Marko Lindqvist
Update of bug #19846 (project freeciv):

 Summary: Closing unit select dialog asserts = Closing unit
select dialog asserts or crashes


___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2013-02-07 Thread Marko Lindqvist
Follow-up Comment #7, bug #19846 (project freeciv):

Gnome bug mentioned in comment #4 is still open, but the related gtk+ code has
changed in 3.6, maybe unintentionally fixing this.

Obvious solution for us would be to make gtk+-3.6 the minimum requirement.
Problem with that solution is that it would make gtk3-client unavailable to
almost everyone (even not-yet-released Debian Wheezy has only 3.4, so it will
be another release cycle before Debian has at least 3.6) That's not
catastrophic from end-user point of view as we still have equally fully
functional gtk2-client, and it will be a long time before freeciv-2.5 (with
gtk3-client as default) is to be released anyway. However, it would make
development work harder for now.

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2013-01-20 Thread Marko Lindqvist
Follow-up Comment #6, bug #19846 (project freeciv):

Now works perfectly with my crosser build that uses gtk+-3.6.4. Maybe this is
fixed in gtk+ 3.6?

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-12-10 Thread Marko Lindqvist
Update of bug #19846 (project freeciv):

Severity:  3 - Normal = 5 - Blocker
 Planned Release:   2.4.0 = 2.4.0, 2.5.0   

___

Follow-up Comment #5:

See also bug #20224 - presumably because of newer gtk+ this is no longer mere
gtk+ assert, but crashes the client.

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-12-01 Thread Marko Lindqvist
Follow-up Comment #4, bug #19846 (project freeciv):

patch #3469#comment24 points to
https://bugzilla.gnome.org/show_bug.cgi?id=671939

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-08-11 Thread RafałMużyło
Follow-up Comment #3, bug #19846 (project freeciv):

Well, right now I've got the client nearly in pieces (mostly due to gridding -
nearly done now, just restoring the spacing and minor tweaks left), but it
seems my first comment was on the spot - due to the order of signals being
undefined, instead of 
fc_assert_ret(pdialog);
it should just be
if (!pdialog) return;

Though I might have broken something else (unrelated to the above fix), as
Select/Deselect seems to cease to work altogether.

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-06-29 Thread anonymous
Follow-up Comment #1, bug #19846 (project freeciv):

There's quite a bit more:
- the original problem: AFAICT, it comes down to cursor-changed callback
getting run *after* row-activated callback, so that usdlg_get(FALSE) returns
NULL, as the dialog has already been destroyed
- the second part: Select button of this dialog seems to work only while in
first tab (I suspect other buttons to be affected too, though row-activated
callback works regardless of the tab)

Assertions don't seem to happen in gtk2 client (even if the buttons still fail
in the same way) - it seems that either it's a minor problem in gtk3 or
treeview is simply less strict there (i.e. I've noticed (IIRC in a different
project) that treeselection returned by a treeview seems to be initially NULL
in gtk3, while I haven't seen checks for such case in gtk2-based code).

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-06-29 Thread anonymous
Follow-up Comment #2, bug #19846 (project freeciv):

OK, partially wrong call in the second case - I was testing a different thing
than I though I was.

It seems to only affect Select button.
For whatever the reason, unit_focus_update() called after USDLG_CMD_SELECT
makes it not work properly.

On that note: it would likely make sense to turn the first tab of the dialog
to a pastebin - that is to allow to select more than one unit in the dialog
and put the selection into this first tab as it gets build.
Also, it would be nice if selecting a unit from that dialog wouldn't select
units from the same field. As a corollary, perhaps center action (one called
on map by c) could cycle through the list of selected units (instead of just
focusing on the first unit of the list) ?

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-06-24 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?19846

 Summary: Closing unit select dialog asserts
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Jun 2012 11:43:57 AM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Closing unit select dialog is closed, either by selecting unit or by Close
button:

1: in usdlg_cmd_cursor_changed() [client/gui-gtk-3.0/unitselect.c::1163]:
assertion 'pdialog != ((void *)0)' failed.






___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-06-24 Thread Jacob Nevins
Update of bug #19846 (project freeciv):

 Planned Release: = 2.4.0  


___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev