[Freeciv-Dev] [bug #21549] Bulbs / turn sent as unsigned

[Marko Lindqvist]

Update of bug #21549 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21549] Bulbs / turn sent as unsigned

[Marko Lindqvist]

Update of bug #21549 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #2:

Fixes

In S2_4 version change to sint32 with optional capability, but even without
the capability type changed to signed one. Even old server is putting the
negative value there, albeit with the warning. Of course this breaks the case
where old server sends value higher than fits in 15 bits (but fits in 16 bits)
to a new client, which now takes it as negative value - we could have some
arbitrary limit which valus with high bit set are considered negative and
which ones uint16 (it's more likely that value is uint16 than below -100)

(file #19887, file #19888, file #19889)
___

Additional Item Attachment:

File name: Sint32TurnBulbs.patch  Size:0 KB
File name: Sint32TurnBulbs-S2_5.patch Size:0 KB
File name: Sint32TurnBulbs-S2_4.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21549] Bulbs / turn sent as unsigned

[Marko Lindqvist]

Follow-up Comment #1, bug #21549 (project freeciv):

When changing this should also make it 32 bit value, 16/15 bits is kind of low
(I've had values well over 1 bulbs/turn, so adjusting settings/rulesets a
bit further...)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21549] Bulbs / turn sent as unsigned

[Marko Lindqvist]

URL:
  

 Summary: Bulbs / turn sent as unsigned
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 28 Jan 2014 07:56:28 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

David Fernandez  reports in bug #19589:

"Testing S2_5 (rev 24279) with Tech upkeep = Cities, it sometimes appear the
error message:
>Trying to put -29 into 16 bits

being -29 (in this example) the bulbs produced per turn after taking the tech
upkeep into account."


So it seems like bulbs / turn is being sent as uint16, despite requireing
signed type.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev