[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-26 Thread Sveinung Kvilhaugsvik
Update of bug #21718 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 

___

Follow-up Comment #5:

Alternative 2 committed.

___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-24 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, bug #21718 (project freeciv):

Both patches are in the git patch format (so they should work with git am). I
have a slight preference for alternative 2 since it avoids any regressions.
Alternative 1 is there in case saving work when the Freeciv svn version is
updated is more important.

___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-24 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, bug #21718 (project freeciv):

New version of alternative 2 that include the new version of patch #4539.

(file #20180)
___

Additional Item Attachment:

File name: 0001-Alternative-2.patch   Size:17 KB


___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-23 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?21718

 Summary: Can't steal tech without embassy
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 24 Feb 2014 07:07:51 AM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

The check that the victim has a technology to steal in the steal tech spy
action returns false when the owner of the diplomat didn't have access to a
list of the victim's techs. That list requires an embassy to the victim.




___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-23 Thread Sveinung Kvilhaugsvik
Update of bug #21718 (project freeciv):

  Depends on: = patch #4539

___

Follow-up Comment #1:

Solution alternative 1: Drop the checks. Wait for patch #4539 to bring them
back.

(file #20168)
___

Additional Item Attachment:

File name: 0001-Allow-stealing-a-tech-from-a-victim-without-establis.patch
Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21718] Can't steal tech without embassy

2014-02-23 Thread Sveinung Kvilhaugsvik
Update of bug #21718 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #2:

Solution alternative 2: Drop the checks in the client. Patch the server so it
takes care of the checks.

(file #20169)
___

Additional Item Attachment:

File name: 0001-Allow-stealing-a-tech-from-a-victim-without-establis.patch
Size:17 KB


___

Reply to this item at:

  http://gna.org/bugs/?21718

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev