[Freeciv-Dev] [bug #21892] AI fails to consider Carriers threatening to cities

2014-04-19 Thread Marko Lindqvist
Follow-up Comment #2, bug #21892 (project freeciv):

Sorry for late reaply (and actually matter of new ticket, if you agree), but
could this entire iteration

 unit_class_iterate(punitclass) {
-  if (dai_uclass_move_type(punitclass) == UMT_LAND
+  if (uclass_has_flag(punitclass, UCF_CAN_OCCUPY_CITY)
can_unit_type_transport(unit_type(punit), punitclass)) {
-/* It can transport some land moving units! */

be made cached boolean variable in S2_5/TRUNK, where ai type can easily cache
data specific to it for each unit_type?


___

Reply to this item at:

  http://gna.org/bugs/?21892

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21892] AI fails to consider Carriers threatening to cities

2014-04-19 Thread Emmet Hikory
Update of bug #21892 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 
 Release: 2.3.6, 2.4.3, 2.5.0, 2.6.0 = 2.4.2, 2.5.0, 2.6.0   

 Planned Release: = 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #5:

That would indeed improve things, but yes, a new ticket sounds right (I've
created patch #4658 for this).  There's lots of other places in the AI code
that we're wasting cycles iterating over possibly long lists checking for a
single condition.

___

Reply to this item at:

  http://gna.org/bugs/?21892

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21892] AI fails to consider Carriers threatening to cities

2014-04-15 Thread Emmet Hikory
Update of bug #21892 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = persia 
 Release: = 2.3.6, 2.4.3, 2.5.0,
2.6.0


___

Reply to this item at:

  http://gna.org/bugs/?21892

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21892] AI fails to consider Carriers threatening to cities

2014-04-04 Thread Emmet Hikory
URL:
  http://gna.org/bugs/?21892

 Summary: AI fails to consider Carriers threatening to cities
 Project: Freeciv
Submitted by: persia
Submitted on: Fri 04 Apr 2014 11:54:23 PM JST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

The AI only considers transports threatening when they carry units with
move_type of UMT_LAND.  As a result, Carriers potentially carrying Helicopters
are not considered a threat.

This is a parallel change to bug #20785.  Patches are attached for S2_3
(r24391), S2_4 (r24747), S2_5 (r24746), and trunk (r24748).



___

File Attachments:


---
Date: Fri 04 Apr 2014 11:54:23 PM JST  Name:
occupier-transport-threatens.patch  Size: 1kB   By: persia

http://gna.org/bugs/download.php?file_id=20471
---
Date: Fri 04 Apr 2014 11:54:23 PM JST  Name:
occupier-transport-threatens.S2_4.patch  Size: 1kB   By: persia

http://gna.org/bugs/download.php?file_id=20472
---
Date: Fri 04 Apr 2014 11:54:23 PM JST  Name:
occupier-transport-threatens.S2_3.patch  Size: 1kB   By: persia

http://gna.org/bugs/download.php?file_id=20473
---
Date: Fri 04 Apr 2014 11:54:23 PM JST  Name:
occupier-transport-threatens.S2_5.patch  Size: 1kB   By: persia

http://gna.org/bugs/download.php?file_id=20474

___

Reply to this item at:

  http://gna.org/bugs/?21892

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev