[Freeciv-Dev] [patch #4139] tile_extra_apply() to handle recursive extra requirements
Update of patch #4139 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4139 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4139] tile_extra_apply() to handle recursive extra requirements
Follow-up Comment #2, patch #4139 (project freeciv): - Added explanation about partial adjustments in case of failure to tile_extra_apply() function header. Is that documentation good enough? (file #18898) ___ Additional Item Attachment: File name: TileExtraApplyDeps-2.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?4139 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4139] tile_extra_apply() to handle recursive extra requirements
Follow-up Comment #3, patch #4139 (project freeciv): Is that documentation good enough? Yes. ___ Reply to this item at: http://gna.org/patch/?4139 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4139] tile_extra_apply() to handle recursive extra requirements
Follow-up Comment #1, patch #4139 (project freeciv): Should its behavior when some branches of the dependency tree can be added and others not be documented? ___ Reply to this item at: http://gna.org/patch/?4139 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4139] tile_extra_apply() to handle recursive extra requirements
URL: http://gna.org/patch/?4139 Summary: tile_extra_apply() to handle recursive extra requirements Project: Freeciv Submitted by: cazfi Submitted on: Wed 04 Sep 2013 12:47:45 AM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: - Move add_recursive_extras() from server/edithand.c to common/tile.c - Made tile_extra_apply() to add requirement extras with add_recursive_extras() - Call tile_extra_apply() instead of add_recursive_extras() from editor code This means both that also old callers of tile_extra_apply() get requirement handling too, and editor code gets conflicts handling that was already present in tile_extra_apply(). Latter is real, functional, user-visible change, while latter is more theoretical with current callers. ___ File Attachments: --- Date: Wed 04 Sep 2013 12:47:45 AM EEST Name: TileExtraApplyDeps.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=18850 ___ Reply to this item at: http://gna.org/patch/?4139 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
