[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Update of bug #13869 (project freeciv): Status:None => Wont Fix Assigned to: cazfi => pepeto Open/Closed:Open => Closed

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #16, bug #13869 (project freeciv): OK by me. ___ Reply to this item at: ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Update of bug #13869 (project freeciv): Planned Release: => 2.3.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #15, bug #13869 (project freeciv): > The other patches are changes 'nice to have'. I really think it's clearer to keep different validation callback for every type of settings supported. Any, it doesn't change the space of the memory since it's in an union now. I suggest to d

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #14, bug #13869 (project freeciv): > > it seems now that it doesn't work at all. > > My mistake. I committed it without properly testing it myself. It was my error to send the patch without really thinking about the logic used in the code. > I don't think this is a fundamenta

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #13, bug #13869 (project freeciv): > My mistake. I committed it without properly testing it myself. Someone who don't make mistake is not human! The greatest quality of man is to recognize to make mistakes. ;) > I'm a bit undecided whether this patch makes code simpler or > le

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Update of bug #13869 (project freeciv): Status: Fixed => None Open/Closed: Closed => Open ___ Reply to this item at:

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #11, bug #13869 (project freeciv): > it seems now that it doesn't work at all. My mistake. I committed it without properly testing it myself. ___ Reply to this item at: __

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #10, bug #13869 (project freeciv): Hm, this is crazy, I didn't look at this patch, but it seems now that it doesn't work at all. I didn't understand this was to replace the validation function, I thought it was about the action callback. I am strongly against. It is normal to

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Update of bug #13869 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Update of bug #13869 (project freeciv): Status:Wont Fix => In Progress Planned Release:None => 2.3.0 ___ Follow-up Comment #8: This new implement

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #7, bug #13869 (project freeciv): use the setting struct as argument to the validation functions as proposed by pepeto; this way it is a simplification as only one prototype is needed for all validation (and action) functions (file #7255) ___

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #4, bug #13869 (project freeciv): * use _one_ function prototype for all validation callbacks (and later also action callbacks) (file #6955) ___ Additional Item Attachment: File name: settings20091010-0003-simplify-valid

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #3, bug #13869 (project freeciv): After the encapsulation and the specialization of the setting structure, I don't see why changing this, it would be very more messy. Those callback should be called only from the settings.c file. And then we should already know what is the typ

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #2, bug #13869 (project freeciv): rebased version of the patch: simplify validation functions - use union bisval - use pointer in the callback functions (file #6683) ___ Additional Item Attachment: File name: 0003-simp

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

Follow-up Comment #1, bug #13869 (project freeciv): updated patch changes: - add 'const' flag - use a pointer for the variable pbisval (file #6191) ___ Additional Item Attachment: File name: 0003-simplify-validation-functions.patch Size:

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

URL: Summary: [patch 03/07] simplify validation functions Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:16 Category: general Severity: 2 - Minor