[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
Update of bug #16778 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3.0 ___ Follow-up Comment #3: Attached 2 fixes: * the first to remove the store merging that doesn't work when the stores are sorted (+miscellaneous cleanup); * the second to fix the city report sorting. Note that the crash you reported only happen when the city report is sorted. (file #10552, file #10553) ___ Additional Item Attachment: File name: trunk_remove_store_merging.diff Size:47 KB File name: trunk_fix_cityrep_sorting.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
Additional Item Attachment, bug #16778 (project freeciv): File name: freeciv-T0002-Y-3998-manual.sav.bz2 Size:19 KB ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
Follow-up Comment #2, bug #16778 (project freeciv): Seems to be hapening in just any game. Attached a game anyway. Load game, press f4, sort by Currently Building, select Michelangelos Chapel and press buy. ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
Update of bug #16778 (project freeciv): Severity: 3 - Normal = 4 - Important ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
Follow-up Comment #1, bug #16778 (project freeciv): Do you have a savegame I could reproduce the first crash? ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16778] Client segfaults when buying while the cities report is open
URL: http://gna.org/bugs/?16778 Summary: Client segfaults when buying while the cities report is open Project: Freeciv Submitted by: mrvn Submitted on: Tuesday 09/28/2010 at 19:51 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.2.99+svn18101 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Opening the cities report (F4), sorting by Currently Building and then buying something causes a segfault. The problem seems to be that the client stores NULL entries in the gtk tree in merge_list_stores(). This causes the compare function to be called with a NULL string which segfaults when it tries to split it. As a workaround I patched int cityrepfield_compare(const char *str1, const char *str2) to handle NULL strings. This avoids the segfault but then GTK complains about (freeciv-gtk2:6001): Gtk-CRITICAL **: gtk_list_store_move_after: assertion `!GTK_LIST_STORE_IS_SORTED (store)' failed and the list of cities shown in the report becomes incomplete. Closing and reopening the report fixes that. Patch attached. MfG Goswin ___ File Attachments: --- Date: Tuesday 09/28/2010 at 19:51 Name: freeciv-cities-segfault.patch Size: 525B By: mrvn Prevent segfault when buying things. Does not fix the real problem. http://gna.org/bugs/download.php?file_id=10494 ___ Reply to this item at: http://gna.org/bugs/?16778 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
