[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Update of bug #17031 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Update of bug #17031 (project freeciv): Status: Confirmed => Ready For Test Assigned to:None => syntron ___ Reply to this item at:

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #9, bug #17031 (project freeciv): another patch attached; comment of the patch: set MAP_MIN_SIZE to 0 * increase MAP_MIN_LINEAR_SIZE to 16 * add macro map_size_checked() which returns the map size based on the number of tiles; the value is >= 1 * replace usage of map.server.si

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #8, bug #17031 (project freeciv): I thought it was set to avoid maps of size 0. However, there is probably no reason to keep it. ___ Reply to this item at: ___

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #7, bug #17031 (project freeciv): > PS: I don't understand why xsize * yxisze must be >= 1000. This I also don't understand but it is writen in the code. The minimum size for the map is 1; thus, the number of tiles must be >= 1 * 1000.

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #6, bug #17031 (project freeciv): I have miss-understood what you said. However, I think the best way would be to allow the savegame to restore the previous settings. PS: I don't understand why xsize * yxisze must be >= 1000. __

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #5, bug #17031 (project freeciv): I tested what is really described in this item and it really fails. This is not linked with starting with a small map. It is because restoring the settings 'xsize' and 'ysize' when loading the map fails. Just save your game and try to load it,

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #4, bug #17031 (project freeciv): I don't think that this is the problem for the map size. Starting a new game with the right options will result in a map size lower than the minimum. There is no need to load/save the map: > set minp 0 Option: minplayers has been set to 0. > s

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #3, bug #17031 (project freeciv): The reason is that it fails to restore the 'xsize' or 'ysize' because the combination of the both settings fail ('ysize' or 'xsize' was not set yet). It is close to bug #17032. ___ Reply

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Follow-up Comment #2, bug #17031 (project freeciv): I think the reason is that the size of the map is to small, i.e. xsize * ysize < MIN_MAP_SIZE * 1000. The attached patch fixes it by increasig i_size by 1 for such cases. (file #11182) ___

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

Update of bug #17031 (project freeciv): Status:None => Confirmed Planned Release: => 2.3.0 ___ Follow-up Comment #1: It is because it d

[Freeciv-Dev] [bug #17031] Small maps corrupt save files

URL: Summary: Small maps corrupt save files Project: Freeciv Submitted by: asplode Submitted on: Sunday 11/07/2010 at 14:15 Category: general Severity: 3 - Normal