[Freeciv-Dev] [bug #17564] Negative endturn
Update of bug #17564 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17564] Negative endturn
URL: http://gna.org/bugs/?17564 Summary: Negative endturn Project: Freeciv Submitted by: cazfi Submitted on: Mon 24 Jan 2011 07:58:11 PM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: In the options with non-default values listing I noticed that minimal value for endturn option is said to be -32768. Negative endturn simply makes no sense, as game starts at turn 0 and it can never decrease. ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17564] Negative endturn
Follow-up Comment #1, bug #17564 (project freeciv): It's not a bug, it's a feature. (C) Negative endturn means neverending game, I guess. ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17564] Negative endturn
Follow-up Comment #2, bug #17564 (project freeciv): It's not a bug, it's a feature. (C) Just in case you are not joking, I answer in serious manner. Negative endturn would mean immediately ending game. We don't need 32770 different ways to say so (values (-32768) - (1) ). Allowing game to go beyond current max endturn is a bad idea. Max endturn exist for a reason; freeciv cannot handle turn numbers beyond it. Game would most likely crash in turn 32769 (max endturn + 1). In addition to all that, my testing showed that there is callback check that in fact prevents anybody from really setting negative endturn. Attempt to do so resulted in error message Cannot set endturn earlier than current turn. This negative enturn stuff was probably oversight when old endyear (which could be negative) setting was replaced by endturn. ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17564] Negative endturn
Update of bug #17564 (project freeciv): Status:None = Ready For Test Planned Release: = 2.2.5, 2.3.0, 2.4.0 ___ Follow-up Comment #3: Fix attached (file #12074) ___ Additional Item Attachment: File name: MinEndTurn0_17564.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17564] Negative endturn
Follow-up Comment #4, bug #17564 (project freeciv): So theoretically this could be declared as unsigned, though it's unlikely we'll ever need that many turns. ___ Reply to this item at: http://gna.org/bugs/?17564 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
