[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Update of bug #19989 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Update of bug #19989 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #6: Attached patch moves unit_move_consequences() after send_unit_info_to_onlookers(). There's several things happening between old unit_move_consequeces() call place and send_unit_info_to_onlookers(), but I don't think any of them require consequences() to be handled before them - if they do, we have a cyclic dependency, as send_..._onlookers() needs those things to be done to send correct information. (file #17660) ___ Additional Item Attachment: File name: MoveConsequencesLater.patchSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Update of bug #19989 (project freeciv): Planned Release: = 2.5.0 ___ Follow-up Comment #2: Still reproducible with latest trunk (r22533) -- hit Turn Done, and the relevant Warriors (id 220) will take over Trondheim. Seems to be to do with the Warriors entering the city -- the assertion is asserting that when a tile becomes fogged, at that point it has no units on it (and the Warriors have indeed just moved off it to take the city, which is why the tile has become fogged). ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Follow-up Comment #3, bug #19989 (project freeciv): Yes, unit_move() calls unit_move_consequences(), which eventually handles city changing hands and old owner losing vision, before send_unit_info_to_onlookers() to update client knowledge about unit location. ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Follow-up Comment #4, bug #19989 (project freeciv): Comments above send_unit_info_to_onlookers() make it clear that it should be called before unit_move_consequences() but the regardless the order of the calls was schanged in r20388, patch #2547 ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Update of bug #19989 (project freeciv): Planned Release: 2.5.0 = 2.4.0, 2.5.0 ___ Follow-up Comment #5: Faulty commit was made to trunk only, but just before S2_4 branching. ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
URL:
http://gna.org/bugs/?19989
Summary: client assertion unit_list_size(ptile-units) failed
Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 27 Jul 2012 06:51:11 PM CEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: trunk
Discussion Lock: Any
Operating System: GNU/Linux
Planned Release:
___
Details:
( It's related to all clients, not Qt, I checked with gtk2 )
it repeatable. Save game attached.
failed assertion:
in handle_tile_info() [../../client/packhand.c::2670]: assertion '0 ==
unit_list_size(ptile-units)' failed.
2: 0: ./client/freeciv-gtk2() [0x5d02a8]
2: 1: ./client/freeciv-gtk2(vdo_log+0x88) [0x5d5018]
2: 2: ./client/freeciv-gtk2(do_log+0x7d) [0x5d50cd]
2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x9f) [0x5d52ff]
2: 4: ./client/freeciv-gtk2(handle_tile_info+0x8fd) [0x4a25bd]
2: 5: ./client/freeciv-gtk2(client_handle_packet+0x611) [0x4a6c21]
debug=4 shows before -
4: client_remove_city() 172, Trondheim
4: game_remove_city() at (24,27) city 172, Holy Roman Trondheim
4: (24,27) creating city 172, Burgundian Trondheim
4: A: agents_city_changed(city 172=Trondheim) owner=Burgundian
3: got packet type=(PACKET_TILE_INFO)15 len=11 from server
4: incoming packet={type=15, size=11}
3: packet_tile_info_100: got info about (2051)
3: got field 'known'
4: remove_packet_from_buffer: remove 11; remaining 756
0x9597980 220 Warriors at (23,26) Henri le Grand
in handle_tile_info() [../../client/packhand.c::2670]: assertion '0 ==
unit_list_size(ptile-units)' failed.
after that everything goes ok:
4: A: agents_tile_remove(tile=(23, 26))
3: got packet type=(PACKET_UNIT_SHORT_INFO)64 len=20 from server
4: incoming packet={type=64, size=20}
___
Reply to this item at:
http://gna.org/bugs/?19989
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile-units) failed
Follow-up Comment #1, bug #19989 (project freeciv): forgot to attach sav (file #16213) ___ Additional Item Attachment: File name: unit_list_size_assert_failed.sav.bz2 Size:24 KB ___ Reply to this item at: http://gna.org/bugs/?19989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
