[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-05 Thread Jacob Nevins
Update of bug #20020 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-03 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?20020

 Summary: civ1: Communism veteran-diplomats effect, but
diplomats are NoVeteran
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Aug  3 23:11:21 2012
Category: rulesets
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:

civ1/effects.ruleset has the usual communist-veteran-build effect for unitflag
Diplomat units, but the only such buildable unit (the Diplomat) is flagged
as NoVeteran.

This is mostly harmless, but leads to misleading government help for Communism
(Veteran Diplomat units.)




___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-03 Thread Marko Lindqvist
Update of bug #20020 (project freeciv):

  Status:  Ready For Test = In Progress

___

Follow-up Comment #1:

Do you have civ1 reference to check which side is the bug, or is this
something where we are not compatible no matter what way we choose? It's
possible that NoVeteran was originally added just to avoid Barracks
producing veteran diplomats, but they still should be produced under
Communism.

___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-03 Thread Jacob Nevins
Update of bug #20020 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-civ1-communist-diplomat-no-veteran.patch Size:0 KB
File name: S2_4-civ1-communist-diplomat-no-veteran.patch Size:0 KB
File name: S2_3-civ1-communist-diplomat-no-veteran.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-03 Thread Jacob Nevins
Follow-up Comment #2, bug #20020 (project freeciv):

I don't have an authoritative reference, but this thread
http://forums.civfanatics.com/showthread.php?t=200093 suggests that you
could built veteran Diplomats in cities with Barracks, but that their
veterancy was cosmetic and had no effect.

We could arrange to be bug-compatible in that regard, but it seems cleaner not
to allow veterancy.

___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20020] civ1: Communism veteran-diplomats effect, but diplomats are NoVeteran

2012-08-03 Thread Jacob Nevins
Update of bug #20020 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?20020

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev