URL:
http://gna.org/bugs/?21301
Summary: Possible network stall with short packets at start
of connection
Project: Freeciv
Submitted by: jtn
Submitted on: Sun Nov 24 15:51:14 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: In Progress
Assigned to: jtn
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Any
Planned Release: 2.5.0,2.6.0
___
Details:
Since patch #2789 (16-bit packet type), get_packet_from_connection() has
insisted on at least four bytes (length + type) before proceeding.
if (pc-buffer-ndata 2+2) {
/* length and type not read */
return NULL;
}
However, as of bug #19943, 3-byte packets (those with no payload) are still
valid at the start of a connection. So, this could in theory cause a stall, if
there's any case where the sender sends a short packet and waits for a
response.
I've not seen or heard of such a stall in practice, but we may as well fix it.
(Probably becomes more important with patch #4274.)
___
Reply to this item at:
http://gna.org/bugs/?21301
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
