[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

Update of bug #21725 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

Update of bug #21725 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #3:

- Use virtual tile that has the extras we're working on rather than those from
the real tile
- Handle savegame.c too


(file #25141, file #25142)
___

Additional Item Attachment:

File name: SpecialToExtra-2.patch Size:10 KB
File name: SpecialToExtra-S2_6-2.patchSize:10 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

Update of bug #21725 (project freeciv):

  Status:  Ready For Test => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

Follow-up Comment #2, bug #21725 (project freeciv):

1) The bug exist
2) With the patch issue is gone from the main map
3) With the patch there's issues with FoW maps

For example if there's an Irrigation both currently and in the FoW map, extra
to add to FoW is determined by applying EC_IRRIGATE to real tile that already
has Irrigation -> FoW map gets Farmland.
Other extras usually do not show at all since applying the extra cause to a
real tile that already has the extra does nothing.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

Update of bug #21725 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:   2.6.0 => 2.6.0, 3.0.0   

___

Follow-up Comment #1:

Still untested, but reading the savegame loading code, attached is a
theoretical fix for the theoretical problem - will test practice before
committing.

(file #25075, file #25076)
___

Additional Item Attachment:

File name: SpecialToExtra.patch   Size:3 KB
File name: SpecialToExtra-S2_6.patch  Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21725] Loading old savegames with Mines instead of Oil Wells

[Marko Lindqvist]

URL:
  http://gna.org/bugs/?21725

 Summary: Loading old savegames with Mines instead of Oil
Wells
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 26 Feb 2014 08:26:32 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

I have not tested what happens, but loading old savegames with Mines on
Deserts on rulesets where Oil Well is now used cannot work. I assume Mine will
simply be discarded as illegal extra for Desert.




___

Reply to this item at:

  http://gna.org/bugs/?21725

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev