[Freeciv-Dev] [bug #22232] Rulesave fails to save pythagorean_diagnonal==FALSE for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources

2014-06-24 Thread Emmet Hikory
Update of bug #22232 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22232

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22232] Rulesave fails to save pythagorean_diagnonal==FALSE for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources

2014-06-22 Thread Emmet Hikory
URL:
  http://gna.org/bugs/?22232

 Summary: Rulesave fails to save pythagorean_diagnonal==FALSE
for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources
 Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 12:20:10 AM JST
Category: editor
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: persia
Originator Email: 
 Open/Closed: Open
 Release: r25227
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Reported by Marko Lindqvist in review of patch #4819.

The attached patch fixes only this, but looking at the number of magic values
in the rulesave code, I wonder if it makes sense to move most of these to RS_*
values, and defaulting to them on ruleset load, so that ruledit-saved rulesets
contain the minimum entries.



___

File Attachments:


---
Date: Mon 23 Jun 2014 12:20:10 AM JST  Name:
confirm-default-pythagorean_diagonal.patch  Size: 922B   By: persia

http://gna.org/bugs/download.php?file_id=21115

___

Reply to this item at:

  http://gna.org/bugs/?22232

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev