Follow-up Comment #15, bug #22381 (project freeciv):
(FWIW, the original description of this change I wrote for release notes
before it was reverted: Units can now attack out of cities on non-native
terrain regardless of whether their class has the AttFromNonNative flag. For
instance, land units
Update of bug #22381 (project freeciv):
Planned Release:2.6.0, 2.5.0 = 2.6.0
___
Reply to this item at:
http://gna.org/bugs/?22381
___
Message sent
Follow-up Comment #13, bug #22381 (project freeciv):
Raised bug #22794 to resolve whether this should be reverted or modified.
Please discuss / make proposals there.
___
Reply to this item at:
http://gna.org/bugs/?22381
Update of bug #22381 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #2, bug #22381 (project freeciv):
_ For the source tile in unit_attack_unit_at_tile_result(), changing to
can_exist_at_tile() would be better._
Another benefit of testing for can exist is that it becomes consistent with
spy actions.
Follow-up Comment #3, bug #22381 (project freeciv):
That the source tile isn't checking can_exist_at_tile() now is an oversight
(and a bug). I'm unsure of the right solution for the destination tile
though. Should the source bug just be fixed, and we can discuss the
destination more? Should
Follow-up Comment #4, bug #22381 (project freeciv):
_Should the source bug just be fixed, and we can discuss the destination
more?_
I think that is a good idea. I raised patch #4984 for discussing that issue.
I could start working on this bug today (unless you already have started).
_As for
Update of bug #22381 (project freeciv):
Status: In Progress = None
Assigned to:sveinung = None
___
Follow-up Comment #6:
I wrote the source
URL:
http://gna.org/bugs/?22381
Summary: Inconsistent nativity limits on source tile for
regular attacks
Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 22 Jul 2014 12:18:46 PM UTC
Category: None
Follow-up Comment #1, bug #22381 (project freeciv):
This is a bit complicated. For the source tile in
unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be
better. For the destination tile, we may need a new test (or to refactor the
existing ones), because UTYF_TRIREME
10 matches
Mail list logo